From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68338: 30.0.50; Repeat mode and input methods Date: Thu, 11 Jan 2024 22:51:52 -0500 Message-ID: References: <87cyubtr3u.fsf@gautierponsinet.xyz> <87frz52ksc.fsf@ledu-giraud.fr> <86o7dsnz5a.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7393"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68338@debbugs.gnu.org, Gautier Ponsinet , Manuel Giraud To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 04:53:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rO8bj-0001kW-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 04:53:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rO8bS-0000PY-Kw; Thu, 11 Jan 2024 22:53:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rO8bR-0000OG-Fl for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 22:53:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rO8bR-0004wR-5j for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 22:53:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rO8bO-0008B7-Iw for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 22:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 03:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68338 X-GNU-PR-Package: emacs Original-Received: via spool by 68338-submit@debbugs.gnu.org id=B68338.170503152331358 (code B ref 68338); Fri, 12 Jan 2024 03:53:02 +0000 Original-Received: (at 68338) by debbugs.gnu.org; 12 Jan 2024 03:52:03 +0000 Original-Received: from localhost ([127.0.0.1]:34537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO8aR-00089i-4G for submit@debbugs.gnu.org; Thu, 11 Jan 2024 22:52:03 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO8aM-00089B-Aa for 68338@debbugs.gnu.org; Thu, 11 Jan 2024 22:52:02 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6B114100068; Thu, 11 Jan 2024 22:51:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1705031513; bh=mNlWwWwx8yRi4KVd/4urgG8forqLoazszhcOsmyAOCM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jYPCZKmqJMMs6U/QOO5g8tGtBJYJ94HUDf60acKmj6Caj6k1U2KTKog1CjEQLqpgV RHW0zGXzU5Xk4ky9ynlFh7kdF2YGlz6poLNFNXfynuqgCFGTPcl0kbl6EFpvJK3te1 3rwow0bCy6JBDt5zhi3611dzR30trN0pp6+1L6WUdiLC+TiQoulDOmRWsOD2OYo154 Jo5whQursxdSxhpP7kFonIJMhtUxxHT96DYZZlzWMfuRWnzkq4ari7IZMyGMsl5l0o rC1gFTTTxFuAsblFLW1+6aLich8PIN/sNZu/r04ot+Imy8NocOmsw28okH+p/TN4Xf dV+xV2W7rRzPQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6523410004C; Thu, 11 Jan 2024 22:51:53 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 30B23120611; Thu, 11 Jan 2024 22:51:53 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Thu, 11 Jan 2024 22:31:33 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277983 Archived-At: > I suspect all it takes is to change the: > > (not (eq (cadr overriding-terminal-local-map) > universal-argument-map)) BTW, this is hence related to Bug#22958 where we fixed it for the specific case of `C-u` but we now need to fix it more generally. > IOW define something like a `keymap-transient-p` function, use it there, > and make sure the keymaps installed by `set-transient-map` are recognized > by that new function. Maybe we can treat all `overriding-terminal-local-map` as "transient" in this respect, as in the patch below. It's a bit risky, admittedly. But it would be useful to know what breaks when we do that, to get a better understanding about what the condition above should really test. Stefan diff --git a/lisp/international/quail.el b/lisp/international/quail.el index 56f049aedf5..af1335118a1 100644 --- a/lisp/international/quail.el +++ b/lisp/international/quail.el @@ -1324,9 +1324,7 @@ quail-input-method ;; binding in `universal-argument-map' just return ;; (list KEY), otherwise act as if there was no ;; overriding map. - (or (not (eq (cadr overriding-terminal-local-map) - universal-argument-map)) - (lookup-key overriding-terminal-local-map (vector key)))) + (lookup-key overriding-terminal-local-map (vector key))) overriding-local-map) (list key) (quail-setup-overlays (quail-conversion-keymap))