* bug#13139: 24.3.50; vc-git: Suppress load message
@ 2012-12-11 14:31 Christopher Schmidt
2012-12-11 14:44 ` Andreas Schwab
0 siblings, 1 reply; 9+ messages in thread
From: Christopher Schmidt @ 2012-12-11 14:31 UTC (permalink / raw)
To: 13139
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: vc-git-suppress-load-msg.diff --]
[-- Type: text/x-diff, Size: 884 bytes --]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-12-11 07:49:06 +0000
+++ lisp/ChangeLog 2012-12-11 14:28:26 +0000
@@ -1,3 +1,8 @@
+2012-12-11 Christopher Schmidt <christopher@ch.ristopher.com>
+
+ * vc/vc-git.el (vc-git-registered): Suppress load message of
+ vc-git.
+
2012-12-11 Eli Zaretskii <eliz@gnu.org>
* makefile.w32-in (compile4-SH): Fix a typo that caused term
=== modified file 'lisp/vc/vc-git.el'
--- lisp/vc/vc-git.el 2012-11-30 07:43:05 +0000
+++ lisp/vc/vc-git.el 2012-12-11 14:16:15 +0000
@@ -168,7 +168,7 @@
;;;###autoload "Return non-nil if FILE is registered with git."
;;;###autoload (if (vc-find-root file ".git") ; Short cut.
;;;###autoload (progn
-;;;###autoload (load "vc-git")
+;;;###autoload (load "vc-git" nil t)
;;;###autoload (vc-git-registered file))))
(defun vc-git-registered (file)
[-- Attachment #2: Type: text/plain, Size: 21 bytes --]
Christopher
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2012-12-11 14:31 bug#13139: 24.3.50; vc-git: Suppress load message Christopher Schmidt
@ 2012-12-11 14:44 ` Andreas Schwab
2012-12-11 14:55 ` Christopher Schmidt
2012-12-11 17:05 ` Glenn Morris
0 siblings, 2 replies; 9+ messages in thread
From: Andreas Schwab @ 2012-12-11 14:44 UTC (permalink / raw)
To: 13139
Christopher Schmidt <christopher@ch.ristopher.com> writes:
> + * vc/vc-git.el (vc-git-registered): Suppress load message of
> + vc-git.
Why only vc-git?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2012-12-11 14:44 ` Andreas Schwab
@ 2012-12-11 14:55 ` Christopher Schmidt
2012-12-11 17:05 ` Glenn Morris
1 sibling, 0 replies; 9+ messages in thread
From: Christopher Schmidt @ 2012-12-11 14:55 UTC (permalink / raw)
To: 13139
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
Andreas Schwab <schwab@linux-m68k.org> writes:
> Christopher Schmidt <christopher@ch.ristopher.com> writes:
>
>> + * vc/vc-git.el (vc-git-registered): Suppress load message of
>> + vc-git.
>
> Why only vc-git?
:D
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: vc-suppress-load-msg.diff --]
[-- Type: text/x-diff, Size: 4030 bytes --]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-12-11 07:49:06 +0000
+++ lisp/ChangeLog 2012-12-11 14:51:07 +0000
@@ -1,3 +1,13 @@
+2012-12-11 Christopher Schmidt <christopher@ch.ristopher.com>
+
+ * vc/vc-arch.el (vc-arch-registered):
+ * vc/vc-bzr.el (vc-bzr-registered):
+ * vc/vc-cvs.el (vc-cvs-registered):
+ * vc/vc-git.el (vc-git-registered):
+ * vc/vc-hg.el (vc-hg-registered):
+ * vc/vc-mtn.el (vc-mtn-registered):
+ * vc/vc-svn.el (vc-svn-registered): Suppress load messages.
+
2012-12-11 Eli Zaretskii <eliz@gnu.org>
* makefile.w32-in (compile4-SH): Fix a typo that caused term
=== modified file 'lisp/vc/vc-arch.el'
--- lisp/vc/vc-arch.el 2012-07-11 23:13:41 +0000
+++ lisp/vc/vc-arch.el 2012-12-11 14:48:36 +0000
@@ -101,7 +101,7 @@
;;;###autoload (defun vc-arch-registered (file)
;;;###autoload (if (vc-find-root file "{arch}/=tagging-method")
;;;###autoload (progn
-;;;###autoload (load "vc-arch")
+;;;###autoload (load "vc-arch" nil t)
;;;###autoload (vc-arch-registered file))))
(defun vc-arch-add-tagline ()
=== modified file 'lisp/vc/vc-bzr.el'
--- lisp/vc/vc-bzr.el 2012-09-29 23:13:29 +0000
+++ lisp/vc/vc-bzr.el 2012-12-11 14:48:43 +0000
@@ -291,7 +291,7 @@
;;;###autoload (defun vc-bzr-registered (file)
;;;###autoload (if (vc-find-root file vc-bzr-admin-checkout-format-file)
;;;###autoload (progn
-;;;###autoload (load "vc-bzr")
+;;;###autoload (load "vc-bzr" nil t)
;;;###autoload (vc-bzr-registered file))))
(defun vc-bzr-registered (file)
=== modified file 'lisp/vc/vc-cvs.el'
--- lisp/vc/vc-cvs.el 2012-08-29 15:11:51 +0000
+++ lisp/vc/vc-cvs.el 2012-12-11 14:48:40 +0000
@@ -198,7 +198,7 @@
;;;###autoload "Return non-nil if file F is registered with CVS."
;;;###autoload (when (file-readable-p (expand-file-name
;;;###autoload "CVS/Entries" (file-name-directory f)))
-;;;###autoload (load "vc-cvs")
+;;;###autoload (load "vc-cvs" nil t)
;;;###autoload (vc-cvs-registered f)))
(defun vc-cvs-registered (file)
=== modified file 'lisp/vc/vc-git.el'
--- lisp/vc/vc-git.el 2012-11-30 07:43:05 +0000
+++ lisp/vc/vc-git.el 2012-12-11 14:16:15 +0000
@@ -168,7 +168,7 @@
;;;###autoload "Return non-nil if FILE is registered with git."
;;;###autoload (if (vc-find-root file ".git") ; Short cut.
;;;###autoload (progn
-;;;###autoload (load "vc-git")
+;;;###autoload (load "vc-git" nil t)
;;;###autoload (vc-git-registered file))))
(defun vc-git-registered (file)
=== modified file 'lisp/vc/vc-hg.el'
--- lisp/vc/vc-hg.el 2012-12-05 01:49:31 +0000
+++ lisp/vc/vc-hg.el 2012-12-11 14:48:34 +0000
@@ -176,7 +176,7 @@
;;;###autoload "Return non-nil if FILE is registered with hg."
;;;###autoload (if (vc-find-root file ".hg") ; short cut
;;;###autoload (progn
-;;;###autoload (load "vc-hg")
+;;;###autoload (load "vc-hg" nil t)
;;;###autoload (vc-hg-registered file))))
;; Modeled after the similar function in vc-bzr.el
=== modified file 'lisp/vc/vc-mtn.el'
--- lisp/vc/vc-mtn.el 2012-08-15 19:20:26 +0000
+++ lisp/vc/vc-mtn.el 2012-12-11 14:48:30 +0000
@@ -72,7 +72,7 @@
;;;###autoload (defun vc-mtn-registered (file)
;;;###autoload (if (vc-find-root file vc-mtn-admin-format)
;;;###autoload (progn
-;;;###autoload (load "vc-mtn")
+;;;###autoload (load "vc-mtn" nil t)
;;;###autoload (vc-mtn-registered file))))
(defun vc-mtn-revision-granularity () 'repository)
=== modified file 'lisp/vc/vc-svn.el'
--- lisp/vc/vc-svn.el 2012-11-18 01:52:36 +0000
+++ lisp/vc/vc-svn.el 2012-12-11 14:48:24 +0000
@@ -123,7 +123,7 @@
;;;###autoload "_svn")
;;;###autoload (t ".svn"))))
;;;###autoload (when (vc-find-root f admin-dir)
-;;;###autoload (load "vc-svn")
+;;;###autoload (load "vc-svn" nil t)
;;;###autoload (vc-svn-registered f))))
(defun vc-svn-registered (file)
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2012-12-11 14:44 ` Andreas Schwab
2012-12-11 14:55 ` Christopher Schmidt
@ 2012-12-11 17:05 ` Glenn Morris
2012-12-11 17:46 ` Christopher Schmidt
2012-12-11 19:03 ` Stefan Monnier
1 sibling, 2 replies; 9+ messages in thread
From: Glenn Morris @ 2012-12-11 17:05 UTC (permalink / raw)
To: 13139
Andreas Schwab wrote:
> Christopher Schmidt <christopher@ch.ristopher.com> writes:
>
>> + * vc/vc-git.el (vc-git-registered): Suppress load message of
>> + vc-git.
>
> Why only vc-git?
The more obvious question is: why do this at all?
I can only assume "because I found it slightly irritating", which
doesn't seem like a good reason to me. I'd say that the loading message
is a slightly useful diagnostic, eg in case something goes unexpectedly
wrong. It's a once-per-session message, so surely it's easy to ignore if
it bothers you.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2012-12-11 17:05 ` Glenn Morris
@ 2012-12-11 17:46 ` Christopher Schmidt
2012-12-11 19:03 ` Stefan Monnier
1 sibling, 0 replies; 9+ messages in thread
From: Christopher Schmidt @ 2012-12-11 17:46 UTC (permalink / raw)
To: 13139
Glenn Morris <rgm@gnu.org> writes:
> Andreas Schwab wrote:
>
>> Christopher Schmidt <christopher@ch.ristopher.com> writes:
>>
>>> + * vc/vc-git.el (vc-git-registered): Suppress load message of
>>> + vc-git.
>>
>> Why only vc-git?
>
> The more obvious question is: why do this at all? I can only assume
> "because I found it slightly irritating", which doesn't seem like a
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
That's it. The message does not provide any value to me and it might
override previous messages which are actually important.
> good reason to me. I'd say that the loading message is a slightly
> useful diagnostic, eg in case something goes unexpectedly wrong. It's
> a once-per-session message, so surely it's easy to ignore if it
> bothers you.
How is this message useful in case something goes wrong?
Christopher
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2012-12-11 17:05 ` Glenn Morris
2012-12-11 17:46 ` Christopher Schmidt
@ 2012-12-11 19:03 ` Stefan Monnier
2013-01-13 8:59 ` Christopher Schmidt
1 sibling, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2012-12-11 19:03 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13139
> The more obvious question is: why do this at all?
I guess for consistency with all other loading messages, since we
"recently" made autoloads slient; and also since vc-hooks.el can also
trigger loading of vc-BACKEND.el but if it does, it does it via
`require' rather than `load', so it's also silent in that case.
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2012-12-11 19:03 ` Stefan Monnier
@ 2013-01-13 8:59 ` Christopher Schmidt
2013-01-13 14:23 ` Stefan Monnier
0 siblings, 1 reply; 9+ messages in thread
From: Christopher Schmidt @ 2013-01-13 8:59 UTC (permalink / raw)
To: 13139
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The more obvious question is: why do this at all?
>
> I guess for consistency with all other loading messages, since we
> "recently" made autoloads slient; and also since vc-hooks.el can also
> trigger loading of vc-BACKEND.el but if it does, it does it via
> `require' rather than `load', so it's also silent in that case.
Ping?
It would be great if someone applied my patch (attached to
<87boe08wpx@ch.ristopher.com>) or got me green light so I can apply it
myself.
Christopher
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2013-01-13 8:59 ` Christopher Schmidt
@ 2013-01-13 14:23 ` Stefan Monnier
2013-02-01 17:34 ` Christopher Schmidt
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2013-01-13 14:23 UTC (permalink / raw)
To: 13139
>>> The more obvious question is: why do this at all?
>> I guess for consistency with all other loading messages, since we
>> "recently" made autoloads slient; and also since vc-hooks.el can also
>> trigger loading of vc-BACKEND.el but if it does, it does it via
>> `require' rather than `load', so it's also silent in that case.
> Ping?
> It would be great if someone applied my patch (attached to
> <87boe08wpx@ch.ristopher.com>) or got me green light so I can apply it
> myself.
Go ahead for this one (the other ones should come soon),
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#13139: 24.3.50; vc-git: Suppress load message
2013-01-13 14:23 ` Stefan Monnier
@ 2013-02-01 17:34 ` Christopher Schmidt
0 siblings, 0 replies; 9+ messages in thread
From: Christopher Schmidt @ 2013-02-01 17:34 UTC (permalink / raw)
To: 13139-done
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> It would be great if someone applied my patch (attached to
>> <87boe08wpx@ch.ristopher.com>) or got me green light so I can apply
>> it myself.
>
> Go ahead for this one (the other ones should come soon),
Thank you. Installed in trunk.
Christopher
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-02-01 17:34 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-11 14:31 bug#13139: 24.3.50; vc-git: Suppress load message Christopher Schmidt
2012-12-11 14:44 ` Andreas Schwab
2012-12-11 14:55 ` Christopher Schmidt
2012-12-11 17:05 ` Glenn Morris
2012-12-11 17:46 ` Christopher Schmidt
2012-12-11 19:03 ` Stefan Monnier
2013-01-13 8:59 ` Christopher Schmidt
2013-01-13 14:23 ` Stefan Monnier
2013-02-01 17:34 ` Christopher Schmidt
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).