From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: 45345@debbugs.gnu.org
Subject: bug#45345: [elpa-archive] "make build/<package>" should not pull unconditionally
Date: Sun, 20 Dec 2020 18:31:01 -0500 [thread overview]
Message-ID: <jwv8s9sgiyj.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <875z4wi5i6.fsf@bernoul.li> (Jonas Bernoulli's message of "Sun, 20 Dec 2020 21:31:29 +0100")
>> - Another advantage is that the new code makes it much easier to build
>> your own tarballs, for example to test them before pushing to code.
>> You can just do `make build/[PKGNAME]` and the resulting package will
>> be built in `archive/[PKGNAME]-[VERSION].tar.
> That almost worked. "make build/<package>" (or `elpaa--make-one-package')
> calls `elpaa--external-package-sync', which pulls. That of course is not
> desirable when one wants to test some other revision of the package than
> what would end up being pulled.
Could you give some detail about the situation in which doing `git pull`
was a problem for you?
I mean, obviously I could just move that call to
`elpaa--external-package-sync` elsewhere, but `elpaa--make-one-package'
is supposed to make packages from *commits* (it normally makes two
packages, one from the head of the branch and another from the last
commit that changed `Version:` line) so it "inherently" moves between
different commits.
Stefan
next prev parent reply other threads:[~2020-12-20 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 20:31 bug#45345: [elpa-archive] "make build/<package>" should not pull unconditionally Jonas Bernoulli
2020-12-20 23:31 ` Stefan Monnier [this message]
2020-12-21 10:47 ` Jonas Bernoulli
2020-12-21 14:33 ` Stefan Monnier
2020-12-21 17:26 ` Jonas Bernoulli
2020-12-22 3:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv8s9sgiyj.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=45345@debbugs.gnu.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).