From: Jonas Bernoulli <jonas@bernoul.li>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 45345@debbugs.gnu.org
Subject: bug#45345: [elpa-archive] "make build/<package>" should not pull unconditionally
Date: Mon, 21 Dec 2020 18:26:18 +0100 [thread overview]
Message-ID: <87mty7vznp.fsf@bernoul.li> (raw)
In-Reply-To: <jwv8s9rfde4.fsf-monnier+emacs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> `elpaa--external-package-sync` won't actually fetch anything
> from the remote server and will just do `git merge` which will
> presumably do nothing at all unless you've `git fetched` something into
> `origin/externals/transient` since the last sync or you manually moved
> the `externals/transient` branch back to some earlier commit.
Now that you mention it, yes I did move back to some earlier commit.
I just tried with some new local-only commits and without rewinding
first and that indeed worked just fine.
I don't expect to rewind history going forward so this likely won't
cause me any issues anymore. (I had to rewind because I had not yet
discarded the special "for-gnu-elpa" branch that moved the library to
the top-level. In this case I did have to "rewrite history", but I
don't plan to do that again.)
> So, I think your diagnostic pointing at `elpaa--external-package-sync`
> was a red herring and the problem is rather that:
>
>>> `elpaa--make-one-package'
>>> is supposed to make packages from *commits*
>
> whereas you wanted to make a tarball from whatever was currently in
> `packages/transient`, including uncommitted changes. Is that right?
No, I did in fact create a commit named "[WIP]".
> IOW the function that got in the way of your goal wasn't
> `elpaa--external-package-sync` but `elpaa--clean`.
Had I not created a commit, then yes, that would have been a problem,
but apparently I anticipated this complication. ;)
> I think the solution will be to make a new kind of make target which
> just builds one tarball and skips `elpaa--clean` (and will also skip
> `elpaa--external-package-sync` while we're at it).
Something like "make archive/<package>"
and "make archive-devel/<package>"?
That might be useful.
Jonas
next prev parent reply other threads:[~2020-12-21 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 20:31 bug#45345: [elpa-archive] "make build/<package>" should not pull unconditionally Jonas Bernoulli
2020-12-20 23:31 ` Stefan Monnier
2020-12-21 10:47 ` Jonas Bernoulli
2020-12-21 14:33 ` Stefan Monnier
2020-12-21 17:26 ` Jonas Bernoulli [this message]
2020-12-22 3:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mty7vznp.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=45345@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).