From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 9401@debbugs.gnu.org
Subject: bug#9401: 24.0.50; Crash during fontification
Date: Wed, 31 Aug 2011 08:42:00 -0400 [thread overview]
Message-ID: <jwv7h5t7og0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87mxeq8qnl.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 30 Aug 2011 18:45:34 -0400")
> I've found the bug, and committed a fix. It was a problem with
> find_defun_start not updating its cache variables consistently. (Is
> that optimization really necessary? I guess we can re-examine it some
> other time.)
IIRC this optimization is sometimes important, but it's re-implemented
(in a more sophisticated way) in syntax.el for syntax-ppss, so it would
be good to make the C code somehow use the syntax.el cache. Maybe the
best way is to change back_comment so that in `lossage' it just calls
a Lisp function (that we'd put in syntax.el), so we can throw away
find_defun_start (and even open_paren_in_column_0_is_defun_start).
Stefan
prev parent reply other threads:[~2011-08-31 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 16:10 bug#9401: 24.0.50; Crash during fontification Chong Yidong
2011-08-29 18:59 ` Stefan Monnier
2011-08-29 21:16 ` Chong Yidong
2011-08-30 3:54 ` Leo
2011-08-30 22:45 ` Chong Yidong
2011-08-31 12:42 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7h5t7og0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=9401@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).