From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9401: 24.0.50; Crash during fontification Date: Wed, 31 Aug 2011 08:42:00 -0400 Message-ID: References: <87obz8i4gr.fsf@stupidchicken.com> <87mxeq8qnl.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1314794581 1045 80.91.229.12 (31 Aug 2011 12:43:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 31 Aug 2011 12:43:01 +0000 (UTC) Cc: 9401@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 31 14:42:57 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qyk88-0007Ws-IU for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Aug 2011 14:42:56 +0200 Original-Received: from localhost ([::1]:46842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyk87-0005Z4-M4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Aug 2011 08:42:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyk84-0005Yz-Af for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2011 08:42:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qyk83-0001TD-7X for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2011 08:42:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qyk83-0001T9-4w for bug-gnu-emacs@gnu.org; Wed, 31 Aug 2011 08:42:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QykB9-0007Ay-AW; Wed, 31 Aug 2011 08:46:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Aug 2011 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9401-submit@debbugs.gnu.org id=B9401.131479472025940 (code B ref 9401); Wed, 31 Aug 2011 12:46:02 +0000 Original-Received: (at 9401) by debbugs.gnu.org; 31 Aug 2011 12:45:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QykAR-0006k8-VT for submit@debbugs.gnu.org; Wed, 31 Aug 2011 08:45:20 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QykAM-0006gT-Q2 for 9401@debbugs.gnu.org; Wed, 31 Aug 2011 08:45:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAP8qXk64rwMJ/2dsb2JhbABCqEd4gUABAQQBViMFCwsOJhIUGA0kiAW5SYZVBKAKhD4 X-IronPort-AV: E=Sophos;i="4.68,307,1312171200"; d="scan'208";a="133663974" Original-Received: from 184-175-3-9.dsl.teksavvy.com (HELO ceviche.home) ([184.175.3.9]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 31 Aug 2011 08:42:01 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B415B66108; Wed, 31 Aug 2011 08:42:00 -0400 (EDT) In-Reply-To: <87mxeq8qnl.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 30 Aug 2011 18:45:34 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 31 Aug 2011 08:46:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50469 Archived-At: > I've found the bug, and committed a fix. It was a problem with > find_defun_start not updating its cache variables consistently. (Is > that optimization really necessary? I guess we can re-examine it some > other time.) IIRC this optimization is sometimes important, but it's re-implemented (in a more sophisticated way) in syntax.el for syntax-ppss, so it would be good to make the C code somehow use the syntax.el cache. Maybe the best way is to change back_comment so that in `lossage' it just calls a Lisp function (that we'd put in syntax.el), so we can throw away find_defun_start (and even open_paren_in_column_0_is_defun_start). Stefan