From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: "John Eaton" <jwe@octave.org>,
"Jordi Gutiérrez Hermoso" <jordigh@octave.org>,
14285@debbugs.gnu.org
Subject: bug#14285: 24.3; New octave feature: octave-update-function-file-comment
Date: Sat, 27 Apr 2013 09:19:30 -0400 [thread overview]
Message-ID: <jwv61z8unf5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1obd05r19.fsf@gmail.com> (Leo Liu's message of "Sat, 27 Apr 2013 16:14:26 +0800")
[ FWIW, I use neither Octave nor Matlab and so I never use octave-mode.
I just chose it as a kind of test for SMIE. So I don't have any
opinion on the feature you suggest. ]
> - "Normal hook that is run before a buffer is saved to its file."
> + "Normal hook that is run before a buffer is saved to its file.
> +Any error from the hook prevents saving the buffer."
Maybe rather than fix the doc, we should fix the code and wrap the
run-hook with a with-demote-errors?
> + (cl-destructuring-bind (&optional start _end name-start name-end)
> + (octave-function-file-p)
I recommend you try
(pcase-let ((`(,start ,_end ,name-start ,name-end) (octave-function-file-p)))
instead.
Stefan
next prev parent reply other threads:[~2013-04-27 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 8:14 bug#14285: 24.3; New octave feature: octave-update-function-file-comment Leo Liu
2013-04-27 13:19 ` Stefan Monnier [this message]
2013-04-27 13:35 ` Leo Liu
2013-04-27 17:50 ` Leo Liu
2013-05-02 7:20 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv61z8unf5.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=14285@debbugs.gnu.org \
--cc=jordigh@octave.org \
--cc=jwe@octave.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).