From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14285: 24.3; New octave feature: octave-update-function-file-comment Date: Sat, 27 Apr 2013 09:19:30 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367068804 22677 80.91.229.3 (27 Apr 2013 13:20:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Apr 2013 13:20:04 +0000 (UTC) Cc: John Eaton , Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso , 14285@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 27 15:20:07 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UW52p-0001JO-0W for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2013 15:20:03 +0200 Original-Received: from localhost ([::1]:45718 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UW52o-0006EA-7Y for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2013 09:20:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UW52k-0006E5-OL for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2013 09:19:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UW52i-00040f-2W for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2013 09:19:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UW52h-00040U-W3 for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2013 09:19:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UW52n-0006tJ-PU for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2013 09:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2013 13:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14285-submit@debbugs.gnu.org id=B14285.136706877826456 (code B ref 14285); Sat, 27 Apr 2013 13:20:01 +0000 Original-Received: (at 14285) by debbugs.gnu.org; 27 Apr 2013 13:19:38 +0000 Original-Received: from localhost ([127.0.0.1]:46289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UW52Q-0006sf-HD for submit@debbugs.gnu.org; Sat, 27 Apr 2013 09:19:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:2375) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UW52P-0006sY-9y for 14285@debbugs.gnu.org; Sat, 27 Apr 2013 09:19:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpYYW/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFFpYYW/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="8787127" Original-Received: from 69-165-134-22.dsl.teksavvy.com (HELO pastel.home) ([69.165.134.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Apr 2013 09:19:26 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1FE7D67970; Sat, 27 Apr 2013 09:19:30 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Sat, 27 Apr 2013 16:14:26 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73771 Archived-At: [ FWIW, I use neither Octave nor Matlab and so I never use octave-mode. I just chose it as a kind of test for SMIE. So I don't have any opinion on the feature you suggest. ] > - "Normal hook that is run before a buffer is saved to its file." > + "Normal hook that is run before a buffer is saved to its file. > +Any error from the hook prevents saving the buffer." Maybe rather than fix the doc, we should fix the code and wrap the run-hook with a with-demote-errors? > + (cl-destructuring-bind (&optional start _end name-start name-end) > + (octave-function-file-p) I recommend you try (pcase-let ((`(,start ,_end ,name-start ,name-end) (octave-function-file-p))) instead. Stefan