* bug#4671: `read-passwd' does not recognize keypad enter key
@ 2009-10-08 5:36 Michael Ernst
2009-10-09 19:25 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ernst @ 2009-10-08 5:36 UTC (permalink / raw)
To: bug-gnu-emacs
My Kinesis keyboard's "enter" key is read by Emacs as kp-enter. As a
result, the enter key does not terminate a password as read by
`read-passwd'. This patch corrects that problem.
-Michael Ernst
Changelog entry:
2009-10-08 Michael Ernst <mernst@alum.mit.edu>
* subr.el (read-passwd): Add 'kp-enter to stop-keys.
--- /homes/gws/mernst/bin/src/emacs-22/Linux-i686/emacs/lisp/subr.el 2009-10-01 10:47:42.000000000 -0700
+++ - 2009-10-07 22:31:51.839795567 -0700
@@ -1940,7 +1940,7 @@
(echo-keystrokes 0)
(cursor-in-echo-area t)
(message-log-max nil)
- (stop-keys (list 'return ?\r ?\n ?\e))
+ (stop-keys (list 'return ?\r ?\n ?\e 'kp-enter))
(rubout-keys (list 'backspace ?\b ?\177)))
(add-text-properties 0 (length prompt)
minibuffer-prompt-properties prompt)
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#4671: `read-passwd' does not recognize keypad enter key
2009-10-08 5:36 bug#4671: `read-passwd' does not recognize keypad enter key Michael Ernst
@ 2009-10-09 19:25 ` Stefan Monnier
2009-10-13 23:25 ` Michael Ernst
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2009-10-09 19:25 UTC (permalink / raw)
To: Michael Ernst; +Cc: bug-gnu-emacs, 4671
> My Kinesis keyboard's "enter" key is read by Emacs as kp-enter.
Which version of Emacs is that?
I've installed a few weeks ago a patch that makes read-passwd use the
read-key rather than read-char, so AFAIK such problems should have
been fixed.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#4671: `read-passwd' does not recognize keypad enter key
2009-10-09 19:25 ` Stefan Monnier
@ 2009-10-13 23:25 ` Michael Ernst
2009-10-14 2:56 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ernst @ 2009-10-13 23:25 UTC (permalink / raw)
To: monnier; +Cc: bug-gnu-emacs, 4671
> Which version of Emacs is that?
> I've installed a few weeks ago a patch that makes read-passwd use the
> read-key rather than read-char, so AFAIK such problems should have
> been fixed.
My patch was against the latest CVS version. (I would have mentioned the
version otherwise, but I should have mentioned it even then; sorry for the
omission.)
I noticed the problem in Debian's emacs-snapshot package:
GNU Emacs 23.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1) of 2009-07-31 on lansones, modified by Debian
-Michael Ernst
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#4671: `read-passwd' does not recognize keypad enter key
2009-10-13 23:25 ` Michael Ernst
@ 2009-10-14 2:56 ` Stefan Monnier
2009-10-16 4:50 ` Michael Ernst
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2009-10-14 2:56 UTC (permalink / raw)
To: Michael Ernst; +Cc: bug-gnu-emacs, 4671
>> Which version of Emacs is that?
>> I've installed a few weeks ago a patch that makes read-passwd use the
>> read-key rather than read-char, so AFAIK such problems should have
>> been fixed.
> My patch was against the latest CVS version. (I would have mentioned the
> version otherwise, but I should have mentioned it even then; sorry for the
> omission.)
That's very odd. What does M-: (read-key) RET <kp-enter> return?
What about C-h k <kp-enter> ?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#4671: `read-passwd' does not recognize keypad enter key
2009-10-14 2:56 ` Stefan Monnier
@ 2009-10-16 4:50 ` Michael Ernst
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ernst @ 2009-10-16 4:50 UTC (permalink / raw)
To: monnier; +Cc: bug-gnu-emacs, 4671
Stefan-
As I mentioned, I am running the Ubuntu emacs-snapshot version (but I
submitted a patch against the CVS version, assuming the two wouldn't be
much different). Perhaps the explanation is that it had not yet
incorporated your latest patch. In any event, my version does not have the
`read-key' function. I'll re-submit if the problem persists in the next
official Emacs release.
-Mike
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-10-16 4:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-08 5:36 bug#4671: `read-passwd' does not recognize keypad enter key Michael Ernst
2009-10-09 19:25 ` Stefan Monnier
2009-10-13 23:25 ` Michael Ernst
2009-10-14 2:56 ` Stefan Monnier
2009-10-16 4:50 ` Michael Ernst
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).