* bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window
@ 2013-11-10 14:21 Darren Hoo
2013-11-10 18:06 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Darren Hoo @ 2013-11-10 14:21 UTC (permalink / raw)
To: 15857
C-c , g then press q on the *Symref buffer should close window as
describe-function does, the behavior should be consistent across
different packages.
=== modified file 'lisp/cedet/semantic/symref/list.el'
--- lisp/cedet/semantic/symref/list.el 2013-09-17 15:50:33 +0000
+++ lisp/cedet/semantic/symref/list.el 2013-11-10 14:12:59 +0000
@@ -192,7 +192,7 @@
(defun semantic-symref-hide-buffer ()
"Hide buffer with semantic-symref results."
(interactive)
- (bury-buffer))
+ (quit-window))
(defcustom semantic-symref-results-summary-function 'semantic-format-tag-prototype
"Function to use when creating items in Imenu.
In GNU Emacs 24.3.50.8 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
of 2013-11-09 on Darren-rMBP.local
Bzr revision: 115046 xfq.free@gmail.com-20131109023646-nqoo2uv3hfjwoxiw
Windowing system distributor `Apple', version 10.3.1265
Configured using:
`configure --with-ns'
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window
2013-11-10 14:21 bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window Darren Hoo
@ 2013-11-10 18:06 ` Stefan Monnier
2013-11-11 5:57 ` Darren Hoo
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2013-11-10 18:06 UTC (permalink / raw)
To: Darren Hoo; +Cc: 15857
> (defun semantic-symref-hide-buffer ()
> "Hide buffer with semantic-symref results."
> (interactive)
> - (bury-buffer))
> + (quit-window))
Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window
2013-11-10 18:06 ` Stefan Monnier
@ 2013-11-11 5:57 ` Darren Hoo
2013-11-11 13:35 ` Stefan Monnier
2018-04-15 21:45 ` Lars Ingebrigtsen
0 siblings, 2 replies; 7+ messages in thread
From: Darren Hoo @ 2013-11-11 5:57 UTC (permalink / raw)
To: 15857
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (defun semantic-symref-hide-buffer ()
>> "Hide buffer with semantic-symref results."
>> (interactive)
>> - (bury-buffer))
>> + (quit-window))
>
> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>
or just
(define-key km "q" 'quit-window)
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window
2013-11-11 5:57 ` Darren Hoo
@ 2013-11-11 13:35 ` Stefan Monnier
2018-04-15 21:45 ` Lars Ingebrigtsen
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2013-11-11 13:35 UTC (permalink / raw)
To: Darren Hoo; +Cc: 15857
> or just
> (define-key km "q" 'quit-window)
Which would code for free if the mode derived from special-mode.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window
2013-11-11 5:57 ` Darren Hoo
2013-11-11 13:35 ` Stefan Monnier
@ 2018-04-15 21:45 ` Lars Ingebrigtsen
2018-04-16 6:06 ` martin rudalics
1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2018-04-15 21:45 UTC (permalink / raw)
To: Darren Hoo; +Cc: 15857
Darren Hoo <darren.hoo@gmail.com> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> (defun semantic-symref-hide-buffer ()
>>> "Hide buffer with semantic-symref results."
>>> (interactive)
>>> - (bury-buffer))
>>> + (quit-window))
>>
>> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>>
>
> or just
> (define-key km "q" 'quit-window)
I've now done this in Emacs 27.1.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window
2018-04-15 21:45 ` Lars Ingebrigtsen
@ 2018-04-16 6:06 ` martin rudalics
2018-04-16 11:48 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: martin rudalics @ 2018-04-16 6:06 UTC (permalink / raw)
To: Lars Ingebrigtsen, Darren Hoo; +Cc: 15857
>>> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>>>
>>
>> or just
>> (define-key km "q" 'quit-window)
>
> I've now done this in Emacs 27.1.
I'm afraid not.
- (define-key km "q" 'semantic-symref-hide-buffer)
+ (define-key km "q" 'quit-buffer)
The function is called 'quit-window' not 'quit-buffer'.
martin
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window
2018-04-16 6:06 ` martin rudalics
@ 2018-04-16 11:48 ` Lars Ingebrigtsen
0 siblings, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2018-04-16 11:48 UTC (permalink / raw)
To: martin rudalics; +Cc: 15857, Darren Hoo
martin rudalics <rudalics@gmx.at> writes:
>>>> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>>>>
>>>
>>> or just
>>> (define-key km "q" 'quit-window)
>>
>> I've now done this in Emacs 27.1.
>
> I'm afraid not.
>
> - (define-key km "q" 'semantic-symref-hide-buffer)
> + (define-key km "q" 'quit-buffer)
>
> The function is called 'quit-window' not 'quit-buffer'.
Oops, thanks. I've pushed a fix now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-16 11:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-10 14:21 bug#15857: 24.3.50; semantic-symref-hide-buffer should use quit-window Darren Hoo
2013-11-10 18:06 ` Stefan Monnier
2013-11-11 5:57 ` Darren Hoo
2013-11-11 13:35 ` Stefan Monnier
2018-04-15 21:45 ` Lars Ingebrigtsen
2018-04-16 6:06 ` martin rudalics
2018-04-16 11:48 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).