unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: 16346@debbugs.gnu.org
Subject: bug#16346: 24.3; electric-pair-mode close-paren issue
Date: Fri, 10 Jan 2014 12:20:49 -0500	[thread overview]
Message-ID: <jwv38kvbvvi.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <m11u0fpyxe.fsf@gmail.com> (Leo Liu's message of "Sat, 11 Jan 2014 00:46:37 +0800")

>>> But maybe eldoc-post-insert-mode (maybe even a new name
>>> eldoc-edit-mode?) can check on char changes instead?
>> I don't understand what you mean by "char changes".
>> Ah, you mean using an after-change-function?  I don't really like that.
>> I'm not sure what problem it is supposed to avoid.
> The SPC DEL thing that you mentioned

Ah, right, it would cause the DEL to also emit the eldoc info.

> and this bug.

Using a buffer-local eldoc-message-commands which only contains
self-insert-command would also fix this bug.

> OK I don't mind taking eldoc-post-insert-mode out completely.  Let me
> know if you want me to.  It is new in 24.4 so better go now if it has to
> go.  I can put it in my init file if I need it.

I think the idea is fine, but using post-self-insert-hook turns out to
be a bad idea, I think (tho I liked it, initially).
Could you try and re-implement it as a minor mode that enables
eldoc-mode and tweaks eldoc-message-commands buffer-locally, to see if
that works better?


        Stefan





  reply	other threads:[~2014-01-10 17:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-05  2:57 bug#16346: 24.3; electric-pair-mode close-paren issue Leo Liu
2014-01-05 11:49 ` João Távora
2014-01-05 15:30   ` Leo Liu
2014-01-05 19:25     ` João Távora
2014-01-05 23:13     ` Stefan Monnier
2014-01-06  0:48       ` Leo Liu
2014-01-09 16:12         ` Stefan Monnier
2014-01-10  3:24           ` Leo Liu
2014-01-10  4:11             ` Leo Liu
2014-01-10 14:14             ` Stefan Monnier
2014-01-10 16:46               ` Leo Liu
2014-01-10 17:20                 ` Stefan Monnier [this message]
2014-01-11  4:38                   ` Leo Liu
2014-01-11  5:35                     ` Stefan Monnier
2014-01-11  6:11                       ` Leo Liu
2014-01-12  3:35                         ` Stefan Monnier
2014-01-12  4:21                           ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv38kvbvvi.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=16346@debbugs.gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).