From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 13425@debbugs.gnu.org, Tom Tromey <tom@tromey.com>
Subject: bug#13425: close this bug?
Date: Sun, 29 Jan 2017 13:15:42 -0500 [thread overview]
Message-ID: <jwv1svlhh57.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <1485711505.6518.0@smtp.gmail.com> ("Simen Heggestøyl"'s message of "Sun, 29 Jan 2017 18:38:25 +0100")
>> The above problem is trivially fixed with the patch below, but it seems
>> too easy, so it probably introduces problems elsewhere.
> Indeed, that causes problems with selectors that contain colons, like:
Then we need to change css-smie--forward-token and
css-smie--backward-token. Two ways to fix it:
- either make them distinguish between ", between selector" and ",
between values".
- or make them distinguish between ": for selectors" and ": for values".
Then we can change the grammar to give different precedences for the two
different cases.
E.g.
(defun css-smie--backward-token ()
[...]
(if (css--colon-inside-selector-p)
":-selector" ":"))
and then
(defconst css-smie-grammar
(smie-prec2->grammar
(smie-precs->prec2 '((assoc ";") (left ":") (assoc ",")
(left ":-selector")))))
So the question is mostly: whether it's easier to distinguish the two
different kinds of commas, or whether it's easier to distinguish the two
different kinds of colons.
Stefan
next prev parent reply other threads:[~2017-01-29 18:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 7:43 bug#13425: new css-mode indenter E Sabof
2013-01-15 5:00 ` Stefan Monnier
2013-01-15 19:32 ` E Sabof
2013-01-17 0:17 ` E Sabof
2017-01-25 23:06 ` bug#13425: close this bug? Tom Tromey
2017-01-29 14:01 ` Simen Heggestøyl
2017-01-29 17:16 ` Stefan Monnier
2017-01-29 17:38 ` Simen Heggestøyl
2017-01-29 18:15 ` Stefan Monnier [this message]
2017-02-02 19:12 ` Simen Heggestøyl
2017-02-03 0:02 ` Stefan Monnier
2017-02-04 19:31 ` Simen Heggestøyl
2017-01-30 22:17 ` Tom Tromey
2017-01-30 22:28 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1svlhh57.fsf-monnier+Inbox@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13425@debbugs.gnu.org \
--cc=simenheg@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).