From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13425: close this bug? Date: Sun, 29 Jan 2017 13:15:42 -0500 Message-ID: References: <87efzqhh93.fsf@tromey.com> <1485711505.6518.0@smtp.gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485713777 8829 195.159.176.226 (29 Jan 2017 18:16:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 18:16:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 13425@debbugs.gnu.org, Tom Tromey To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 29 19:16:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXu1M-0001yP-SI for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 19:16:12 +0100 Original-Received: from localhost ([::1]:56276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXu1P-00043W-7p for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jan 2017 13:16:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXu1H-000428-PW for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 13:16:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXu1C-00089J-Pq for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 13:16:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXu1C-00089C-Mk for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 13:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cXu1C-0003n1-Ex for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2017 13:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2017 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13425 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13425-submit@debbugs.gnu.org id=B13425.148571374714536 (code B ref 13425); Sun, 29 Jan 2017 18:16:02 +0000 Original-Received: (at 13425) by debbugs.gnu.org; 29 Jan 2017 18:15:47 +0000 Original-Received: from localhost ([127.0.0.1]:50420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXu0w-0003mO-Tl for submit@debbugs.gnu.org; Sun, 29 Jan 2017 13:15:47 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:55354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXu0u-0003mF-MH for 13425@debbugs.gnu.org; Sun, 29 Jan 2017 13:15:45 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v0TIFhl8028167; Sun, 29 Jan 2017 13:15:43 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id EC91366261; Sun, 29 Jan 2017 13:15:42 -0500 (EST) In-Reply-To: <1485711505.6518.0@smtp.gmail.com> ("Simen =?UTF-8?Q?Heggest=C3=B8yl?="'s message of "Sun, 29 Jan 2017 18:38:25 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5934=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5934> : inlines <5665> : streams <1730772> : uri <2367074> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128764 Archived-At: >> The above problem is trivially fixed with the patch below, but it seems >> too easy, so it probably introduces problems elsewhere. > Indeed, that causes problems with selectors that contain colons, like: Then we need to change css-smie--forward-token and css-smie--backward-token. Two ways to fix it: - either make them distinguish between ", between selector" and ", between values". - or make them distinguish between ": for selectors" and ": for values". Then we can change the grammar to give different precedences for the two different cases. E.g. (defun css-smie--backward-token () [...] (if (css--colon-inside-selector-p) ":-selector" ":")) and then (defconst css-smie-grammar (smie-prec2->grammar (smie-precs->prec2 '((assoc ";") (left ":") (assoc ",") (left ":-selector"))))) So the question is mostly: whether it's easier to distinguish the two different kinds of commas, or whether it's easier to distinguish the two different kinds of colons. Stefan