From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 48492@debbugs.gnu.org
Cc: Gong Qijian <gongqijian@gmail.com>
Subject: bug#48492: master ab20f38: Fix `custom-delayed-init-variables' problem when re-dumping emacs
Date: Tue, 18 May 2021 10:48:16 -0400 [thread overview]
Message-ID: <jwv1ra4p0gu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20210518143810.4DA8920947@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 18 May 2021 10:38:09 -0400 (EDT)")
> * lisp/startup.el (command-line): Don't bug out on redumping Emacs
> (bug#48492).
[...]
> @@ -1197,11 +1197,11 @@ please check its value")
>
> ;; Re-evaluate predefined variables whose initial value depends on
> ;; the runtime context.
> - (setq custom-delayed-init-variables
> - ;; Initialize them in the same order they were loaded, in case there
> - ;; are dependencies between them.
> - (nreverse custom-delayed-init-variables))
> - (mapc #'custom-reevaluate-setting custom-delayed-init-variables)
> + (when (listp custom-delayed-init-variables)
> + (mapc #'custom-reevaluate-setting
> + ;; Initialize them in the same order they were loaded, in
> + ;; case there are dependencies between them.
> + (reverse custom-delayed-init-variables)))
> (setq custom-delayed-init-variables t)
>
> ;; Warn for invalid user name.
While this is a good short term fix, I think what we would ideally want
instead is that those settings be re-evaluated yet-again when we start
the re-dumped Emacs.
So maybe instead of setting the var to t, we should use another var to
denote that we've already init'd those vars (and re-set that other var
some time when we redump).
Stefan
next parent reply other threads:[~2021-05-18 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210518143808.11815.577@vcs0.savannah.gnu.org>
[not found] ` <20210518143810.4DA8920947@vcs0.savannah.gnu.org>
2021-05-18 14:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-05-18 15:13 ` bug#48492: master ab20f38: Fix `custom-delayed-init-variables' problem when re-dumping emacs Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1ra4p0gu.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=48492@debbugs.gnu.org \
--cc=gongqijian@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).