From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48492: master ab20f38: Fix `custom-delayed-init-variables' problem when re-dumping emacs Date: Tue, 18 May 2021 10:48:16 -0400 Message-ID: References: <20210518143808.11815.577@vcs0.savannah.gnu.org> <20210518143810.4DA8920947@vcs0.savannah.gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4848"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gong Qijian To: 48492@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 18 16:56:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lj192-00016J-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 16:56:28 +0200 Original-Received: from localhost ([::1]:49614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj191-0001H9-Je for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 10:56:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj11q-00071w-Lc for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 10:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lj11q-00051R-BW for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 10:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lj11q-0001qW-5g for bug-gnu-emacs@gnu.org; Tue, 18 May 2021 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 May 2021 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48492 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 48492-submit@debbugs.gnu.org id=B48492.16213493067054 (code B ref 48492); Tue, 18 May 2021 14:49:02 +0000 Original-Received: (at 48492) by debbugs.gnu.org; 18 May 2021 14:48:26 +0000 Original-Received: from localhost ([127.0.0.1]:56878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj11G-0001pi-Ft for submit@debbugs.gnu.org; Tue, 18 May 2021 10:48:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:26414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lj11E-0001pS-9j for 48492@debbugs.gnu.org; Tue, 18 May 2021 10:48:25 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AAA5310028A; Tue, 18 May 2021 10:48:18 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 38BEE100068; Tue, 18 May 2021 10:48:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1621349297; bh=plRsFUtkWJ34thxQIUpeLRkFh+kSovlDmM/eKLlRJCg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PdjGRfzfwfT7ulHwALlyJrxXwArqi5CbltI+cY7N0KqSZBR82Fvg6EXdR+9PYH3rV NkAWi37xrLWAUvgPnATRVCDxYlSsOd0ruTXa5ciOX89xyZ5LtDILvT5zPox4yXmJcG hPZi38IaxXIfg/ZMZZzXm8B2XBRwUzT0Vv4bEG2M0bwqZoJiLtBza2jjR/uLEZgnv1 lwDhE7xjCUONJn2tYkxwDpX7zBpwCpd3HvopjHDNOJKZFngCa380AQP5pWA8fJuOeR IDUlzr0xSCyJNRXm3/WodbZDG5A5tCCuK+w2IGiyQMUZ9RzpjKhAW2/ZWyUyY19Zlf /OElDKFxPo3zA== Original-Received: from alfajor (76-10-140-76.dsl.teksavvy.com [76.10.140.76]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 116B7120552; Tue, 18 May 2021 10:48:17 -0400 (EDT) In-Reply-To: <20210518143810.4DA8920947@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 18 May 2021 10:38:09 -0400 (EDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206789 Archived-At: > * lisp/startup.el (command-line): Don't bug out on redumping Emacs > (bug#48492). [...] > @@ -1197,11 +1197,11 @@ please check its value") > > ;; Re-evaluate predefined variables whose initial value depends on > ;; the runtime context. > - (setq custom-delayed-init-variables > - ;; Initialize them in the same order they were loaded, in case there > - ;; are dependencies between them. > - (nreverse custom-delayed-init-variables)) > - (mapc #'custom-reevaluate-setting custom-delayed-init-variables) > + (when (listp custom-delayed-init-variables) > + (mapc #'custom-reevaluate-setting > + ;; Initialize them in the same order they were loaded, in > + ;; case there are dependencies between them. > + (reverse custom-delayed-init-variables))) > (setq custom-delayed-init-variables t) > > ;; Warn for invalid user name. While this is a good short term fix, I think what we would ideally want instead is that those settings be re-evaluated yet-again when we start the re-dumped Emacs. So maybe instead of setting the var to t, we should use another var to denote that we've already init'd those vars (and re-set that other var some time when we redump). Stefan