From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
Lars Ingebrigtsen <larsi@gnus.org>,
54079@debbugs.gnu.org
Subject: bug#54079: 29.0.50; Method dispatching eratically fails
Date: Tue, 08 Mar 2022 14:53:07 -0500 [thread overview]
Message-ID: <jwv1qzcgr9v.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <YieuW4vFclpvgofI@ACM> (Alan Mackenzie's message of "Tue, 8 Mar 2022 19:28:27 +0000")
> diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
> index 9be44a8d5a..fb9f70bd67 100644
> --- a/lisp/emacs-lisp/bytecomp.el
> +++ b/lisp/emacs-lisp/bytecomp.el
> @@ -499,9 +499,10 @@ byte-compile-initial-macro-environment
> (byte-compile-new-defuns
> byte-compile-new-defuns))
> (setf result
> - (byte-compile-eval
> + (byte-run-strip-symbol-positions
> + (byte-compile-eval
> (byte-compile-top-level
> - (byte-compile-preprocess form)))))))
> + (byte-compile-preprocess form))))))))
I'd expect the reverse: strip first and then eval the result.
Why should we not strip the form passed to `byte-compile-eval`?
Does `byte-compile-top-level` already return a stripped form of code?
And why bother stripping the result of `byte-compile-eval`?
> @@ -512,9 +513,10 @@ byte-compile-initial-macro-environment
> ;; or byte-compile-file-form.
> (let* ((print-symbols-bare t) ; Possibly redundant binding.
> (expanded
> - (macroexpand--all-toplevel
> - form
> - macroexpand-all-environment)))
> + (byte-run-strip-symbol-positions
> + (macroexpand--all-toplevel
> + form
> + macroexpand-all-environment))))
> (eval expanded lexical-binding)
> expanded)))))
> (with-suppressed-warnings
Fundamentally, `eval` should always strip before doing its job. Yes,
I know, it might be a bit expensive, but we should probably define
a local function in `bytecomp.el` which does strip+eval and use that
instead of `eval` (both here and in `byte-compile-eval`).
WDYT?
Stefan
next prev parent reply other threads:[~2022-03-08 19:53 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 0:12 bug#54079: 29.0.50; Method dispatching eratically fails Michael Heerdegen
2022-02-21 1:14 ` Michael Heerdegen
2022-03-04 16:12 ` Lars Ingebrigtsen
2022-02-21 3:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-21 4:21 ` Michael Heerdegen
2022-02-22 23:55 ` Michael Heerdegen
2022-02-23 0:27 ` Michael Heerdegen
2022-02-23 0:47 ` Michael Heerdegen
2022-03-04 2:08 ` Michael Heerdegen
2022-03-04 19:11 ` Alan Mackenzie
2022-03-05 16:37 ` Alan Mackenzie
2022-03-05 17:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-05 19:00 ` Alan Mackenzie
2022-03-05 23:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-05 18:19 ` Eli Zaretskii
2022-03-05 19:07 ` Alan Mackenzie
2022-03-06 2:19 ` Michael Heerdegen
2022-03-08 19:28 ` Alan Mackenzie
2022-03-08 19:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-03-08 20:48 ` Alan Mackenzie
2022-03-08 21:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-09 17:42 ` Alan Mackenzie
2022-03-09 18:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-09 20:32 ` Alan Mackenzie
2022-03-09 22:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-11 22:01 ` Alan Mackenzie
2022-03-12 4:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-13 16:49 ` Alan Mackenzie
2022-03-14 12:10 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-09 4:10 ` Michael Heerdegen
2022-03-09 17:29 ` Alan Mackenzie
2022-03-16 1:44 ` Michael Heerdegen
2022-03-16 11:52 ` Alan Mackenzie
2022-03-16 19:22 ` Michael Heerdegen
2022-03-17 2:58 ` Michael Heerdegen
2022-03-16 19:29 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1qzcgr9v.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=54079@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=larsi@gnus.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).