From: Spencer Baugh <sbaugh@janestreet.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@catern.com, 66326@debbugs.gnu.org
Subject: bug#66326: 29.1.50; There should be a way to promote warnings to errors
Date: Thu, 19 Oct 2023 11:18:53 -0400 [thread overview]
Message-ID: <ier5y324p42.fsf@janestreet.com> (raw)
In-Reply-To: <83cyxatzva.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Oct 2023 18:07:21 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Spencer Baugh <sbaugh@janestreet.com>
>> Cc: sbaugh@catern.com, 66326@debbugs.gnu.org
>> Date: Thu, 19 Oct 2023 10:50:59 -0400
>>
>> >> What is the good reason that we delay warnings?
>> >
>> > Because Emacs is not yet able to display stuff reliably, for example.
>> > Or the display environment was not yet set up completely.
>>
>> Right. But that is not a concern for errors.
>
> It is a concern for displaying anything and everything.
Could you be more specific? Is there a way to signal an error during
startup, which won't be displayed?
>> So there's no need to do extra work to delay errors in warnings.el.
>
> Yes, there is.
Can you please elaborate? What exactly will go wrong if we don't delay
errors in warnings.el?
>> >> But OK, attached is a new patch which adds an option to immediately
>> >> raise the warnings converted into errors during startup, instead of
>> >> delaying them. So the default is to delay the error until after
>> >> startup. Does this work?
>> >
>> > Did you test that? If you did, what happens with delayed warnings
>> > when the new option is nil?
>>
>> They continue to be delayed. If a warning is turned into an error, the
>> error is signaled by delayed-warnings-hook, run by after-init-hook.
>
> Delayed and shown how? Can you show a screenshot or post the contents
> of the buffer with the error message?
With
(setq warning-to-error-types t)
;;(setq warning-signal-errors-during-startup nil) ; default
(warn "foo")
The following appears in the echo area and in *Messages*:
warning-to-error: Warning (emacs): foo
Error in delayed-warnings-hook (display-delayed-warnings): (error "Warning (emacs): foo")
next prev parent reply other threads:[~2023-10-19 15:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 16:38 bug#66326: 29.1.50; There should be a way to promote warnings to errors Spencer Baugh
2023-10-03 18:39 ` Spencer Baugh
2023-10-03 18:57 ` Eli Zaretskii
2023-10-03 19:16 ` sbaugh
2023-10-04 5:59 ` Eli Zaretskii
2023-10-04 12:20 ` Spencer Baugh
2023-10-14 7:27 ` Eli Zaretskii
2023-10-14 22:25 ` sbaugh
2023-10-15 5:45 ` Eli Zaretskii
2023-10-16 19:26 ` Spencer Baugh
2023-10-19 12:13 ` Eli Zaretskii
2023-10-19 14:50 ` Spencer Baugh
2023-10-19 15:07 ` Eli Zaretskii
2023-10-19 15:18 ` Spencer Baugh [this message]
2023-10-19 15:42 ` Eli Zaretskii
2023-10-19 16:15 ` Spencer Baugh
2023-10-20 7:20 ` Eli Zaretskii
2023-10-21 9:12 ` Stefan Kangas
2023-10-21 13:43 ` sbaugh
2023-11-10 21:40 ` Spencer Baugh
2023-11-11 7:02 ` Eli Zaretskii
2023-11-11 14:37 ` Spencer Baugh
2023-11-11 14:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ier5y324p42.fsf@janestreet.com \
--to=sbaugh@janestreet.com \
--cc=66326@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).