bug#66326: 29.1.50; There should be a way to promote warnings to errors

[Eli Zaretskii <eliz@gnu.org>]

> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: sbaugh@catern.com,  66326@debbugs.gnu.org
> Date: Thu, 19 Oct 2023 11:18:53 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > It is a concern for displaying anything and everything.
> 
> Could you be more specific?  Is there a way to signal an error during
> startup, which won't be displayed?

What worries me more is that there's a way to signal an error that
could crash Emacs during these early stages of startup.

> >> So there's no need to do extra work to delay errors in warnings.el.
> >
> > Yes, there is.
> 
> Can you please elaborate?  What exactly will go wrong if we don't delay
> errors in warnings.el?

See above.  You seem to be summarily dismissing what I'm saying, so I
have little motivation to elaborate.

> > Delayed and shown how?  Can you show a screenshot or post the contents
> > of the buffer with the error message?
> 
> With
> (setq warning-to-error-types t)
> ;;(setq warning-signal-errors-during-startup nil) ; default
> (warn "foo")
> 
> The following appears in the echo area and in *Messages*:
> 
> warning-to-error: Warning (emacs): foo
> Error in delayed-warnings-hook (display-delayed-warnings): (error "Warning (emacs): foo")

Sounds like in these cases there's no reason to raise an error, since
the information is not different from a mere delayed-warning?