bug#16595: registers can now end up with non-character names

bug#16595: registers can now end up with non-character names

[Glenn Morris]

Package: emacs
Version: 24.3.50

In Emacs 24.3 under X:

emacs -Q
M-x point-to-register RET <right-arrow>
  -> Non-character input-event

In current trunk under X:

emacs -Q
M-x point-to-register RET <right-arrow>
  -> accepted with no complaints

;; Add a second register to show the list-registers problem.
M-x point-to-register RET a

M-x list-registers
  -> sort: Wrong type argument: number-or-marker-p, right

bug#16595: registers can now end up with non-character names

[Glenn Morris]

This is due to register-read-with-preview, which use read-event and does
no sanity checking of the result. Why does it not use read-char?

Also on this subject, register-preview-functions is undocumented and unused.
Does it need to exist? Does it need to be a hook, as opposed to a
-function variable? Should it not exist until there is a use-case for it?

bug#16595: registers can now end up with non-character names

[Leo Liu]

On 2014-01-31 10:51 +0800, Glenn Morris wrote:
> This is due to register-read-with-preview, which use read-event and does
> no sanity checking of the result. Why does it not use read-char?

It is due to handling help-event-list to allow f1 to manually bring up
the preview window, but this may not be important. Changing to read-char
looks fine to me.

> Also on this subject, register-preview-functions is undocumented and
>unused. Does it need to exist? Does it need to be a hook, as opposed to
>a -function variable? Should it not exist until there is a use-case for
>it?

This was left as a hook for registers-list.el (from ELPA). It seems
Bastien was going to do something with it. Bastien, what do you think?

It seems -hook or -function would be a better fit; the latter even
provides more flexibility with add-function

Leo

bug#16595: registers can now end up with non-character names

[Bastien]

Hi Leo,

Leo Liu <sdl.web@gmail.com> writes:

> This was left as a hook for registers-list.el (from ELPA). It seems
> Bastien was going to do something with it. Bastien, what do you
> think?

My time in the last two months was swallowed by fixing Org bugs,
I didn't have time to integrate features from register-list.el
into register.el.

For now, I suggest register.el should behave independently of
register-list.el, ignoring it completely.

When I've time to merge some features, I'll do so.

-- 
 Bastien