bug#4657: 23.1.50; duplicate entries in file-name-history from read-file-name

bug#4657: 23.1.50; duplicate entries in file-name-history from read-file-name

[Roland Winkler]

In a fresh emacs -q load and execute the command foo in order to
read the file name ~/foo/bar

(defun foo ()
  (interactive)
  (read-file-name "File: (default ~/foo/bar) " "~/foo/" "~/foo/bar")
  (message "%s" file-name-history))

If I explicitly enter ~/foo/bar in the minibuffer, multiple
executions of this command add this file to file-name-history only
once. If I am lazy and just use the default value, each execution
will add one more entry ~/foo/bar to file-name-history. I would
expect that multiple equal entries in succession should always be
avoided in file-name-history.



In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2009-08-03 on foo

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: en_GB.utf8
  value of $LANG: en_US.ISO-8859-15
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-9-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

bug#4657: marked as done (23.1.50; duplicate entries in file-name-history from read-file-name)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Your message dated Sun, 18 Oct 2009 18:26:50 -0400
with message-id <871vl05oet.fsf@stupidchicken.com>
and subject line Re: 23.1.50; duplicate entries in file-name-history from read-file-name
has caused the Emacs bug report #4657,
regarding 23.1.50; duplicate entries in file-name-history from read-file-name
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4657: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4657
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2998 bytes --]

From: "Roland Winkler" <Roland.Winkler@physik.uni-erlangen.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.1.50; duplicate entries in file-name-history from read-file-name
Date: Wed, 07 Oct 2009 00:26:39 +0200
Message-ID: <m3eipggnvk.fsf@tfkp07.physik.uni-erlangen.de>

In a fresh emacs -q load and execute the command foo in order to
read the file name ~/foo/bar

(defun foo ()
  (interactive)
  (read-file-name "File: (default ~/foo/bar) " "~/foo/" "~/foo/bar")
  (message "%s" file-name-history))

If I explicitly enter ~/foo/bar in the minibuffer, multiple
executions of this command add this file to file-name-history only
once. If I am lazy and just use the default value, each execution
will add one more entry ~/foo/bar to file-name-history. I would
expect that multiple equal entries in succession should always be
avoided in file-name-history.



In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2009-08-03 on foo

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: en_GB.utf8
  value of $LANG: en_US.ISO-8859-15
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-9-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction


[-- Attachment #3: Type: message/rfc822, Size: 2016 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Roland Winkler" <Roland.Winkler@physik.uni-erlangen.de>
Cc: 4657-done@emacsbugs.donarmstrong.com
Subject: Re: 23.1.50; duplicate entries in file-name-history from read-file-name
Date: Sun, 18 Oct 2009 18:26:50 -0400
Message-ID: <871vl05oet.fsf@stupidchicken.com>

> (defun foo ()
>   (interactive)
>   (read-file-name "File: (default ~/foo/bar) " "~/foo/" "~/foo/bar")
>   (message "%s" file-name-history))

> If I explicitly enter ~/foo/bar in the minibuffer, multiple
> executions of this command add this file to file-name-history only
> once. If I am lazy and just use the default value, each execution
> will add one more entry ~/foo/bar to file-name-history. I would
> expect that multiple equal entries in succession should always be
> avoided in file-name-history.

I've checked in a fix.