bug#4624: 23.1.50; rmail-edit may add incorrect content-type header

bug#4624: 23.1.50; rmail-edit may add incorrect content-type header

[Markus Rost]

In rmail look at a message (from an mbox file) with content-type
multipart, e. g., with headers like

Content-Type: multipart/alternative; boundary="bbbbbbbbbbb"

Edit that message within rmail as usual with
rmail-edit-current-message and rmail-cease-edit.  After saving, the
message has an *additional* header like

Content-type: text/plain; charset=us-ascii

This is bad, since mail readers may not handle the message correctly
as multipart anymore.

The reason is that rmail-cease-edit uses rmail-mime-charset-pattern to
identify content-type headers, but rmail-mime-charset-pattern will match
by default only text/plain.

I am not sure how to fix this.  Ideally rmail-cease-edit should walk
through all the parts of a message when handling the coding, but that
looks very complicated.  Maybe for now rmail-cease-edit should handle
the coding only if there is no content-type header or if the
content-type is matched by rmail-mime-charset-pattern, leaving the
other cases to the responsibilty of the user.


In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.16.1)
 of 2009-10-02 on laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10600000
configured using `configure  '--prefix=/home/rost/local/cvs''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

bug#4624: marked as done (23.1.50; rmail-edit may add incorrect content-type header)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

Your message dated Mon, 05 Oct 2009 22:37:33 -0400
with message-id <gp7hv9qmc2.fsf@fencepost.gnu.org>
and subject line Re: bug#4624: 23.1.50; rmail-edit may add incorrect content-type header
has caused the Emacs bug report #4624,
regarding 23.1.50; rmail-edit may add incorrect content-type header
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4624: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4624
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3660 bytes --]

From: Markus Rost <rost@math.uni-bielefeld.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.1.50; rmail-edit may add incorrect content-type header
Date: Sat,  3 Oct 2009 16:55:21 +0200 (CEST)
Message-ID: <20091003145521.27A06288A0AB@xen12.math.uni-bielefeld.de>


In rmail look at a message (from an mbox file) with content-type
multipart, e. g., with headers like

Content-Type: multipart/alternative; boundary="bbbbbbbbbbb"

Edit that message within rmail as usual with
rmail-edit-current-message and rmail-cease-edit.  After saving, the
message has an *additional* header like

Content-type: text/plain; charset=us-ascii

This is bad, since mail readers may not handle the message correctly
as multipart anymore.

The reason is that rmail-cease-edit uses rmail-mime-charset-pattern to
identify content-type headers, but rmail-mime-charset-pattern will match
by default only text/plain.

I am not sure how to fix this.  Ideally rmail-cease-edit should walk
through all the parts of a message when handling the coding, but that
looks very complicated.  Maybe for now rmail-cease-edit should handle
the coding only if there is no content-type header or if the
content-type is matched by rmail-mime-charset-pattern, leaving the
other cases to the responsibilty of the user.


In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.16.1)
 of 2009-10-02 on laptop
Windowing system distributor `The X.Org Foundation', version 11.0.10600000
configured using `configure  '--prefix=/home/rost/local/cvs''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t



[-- Attachment #3: Type: message/rfc822, Size: 1737 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 4624-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4624: 23.1.50; rmail-edit may add incorrect content-type header
Date: Mon, 05 Oct 2009 22:37:33 -0400
Message-ID: <gp7hv9qmc2.fsf@fencepost.gnu.org>

Markus Rost wrote:

> Maybe for now rmail-cease-edit should handle the coding only if
> there is no content-type header or if the content-type is matched by
> rmail-mime-charset-pattern, leaving the other cases to the
> responsibilty of the user.

I made it do this. Thanks for the report.