unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#4577: [PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
@ 2009-09-28 11:20 ` Jari Aalto
  2009-10-17  3:20   ` bug#4577: marked as done ([PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring) Emacs bug Tracking System
  0 siblings, 1 reply; 2+ messages in thread
From: Jari Aalto @ 2009-09-28 11:20 UTC (permalink / raw)
  To: submit

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

Tags: patch

The documentation of flyspell-get-word reads that there are no required
parameters. All are optional. The patch updates to code according to
docstring.

2009-09-28  Jari Aalto  <jari.aalto@cante.net>

        * textmodes/flyspell.el (flyspell-get-word): Correct function argment
        list according to docstring. Parameter `following' is optional
        (flyspell-external-point-words): Remove `nil' argument from call
        to `flyspell-get-word'.
        (flyspell-auto-correct-word): Remove `nil' argument from call to
        `flyspell-get-word'.
        (flyspell-correct-word-before-point): Remove `nil' argument from
        call to `flyspell-get-word'.
        (flyspell-word-search-forward): Remove `nil' argument from call to
        `flyspell-get-word'.
        (flyspell-word-search-backward): Remove `nil' argument from call to
        `flyspell-get-word'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-textmodes-flyspell.el-flyspell-get-word-Correct.patch --]
[-- Type: text/x-diff, Size: 3082 bytes --]

From a225dd1077da59791bddd77b9f62e43e1c02a9cb Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Mon, 28 Sep 2009 14:18:05 +0300
Subject: [PATCH] lisp/textmodes/flyspell.el: (flyspell-get-word): Correct function argment list according to docstring


Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 lisp/textmodes/flyspell.el |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
index eff19e6..8ee0220 100644
--- a/lisp/textmodes/flyspell.el
+++ b/lisp/textmodes/flyspell.el
@@ -986,7 +986,7 @@ Mostly we check word delimiters."
 	  (inhibit-point-motion-hooks t)
 	  p)
       (while (and (not r) (setq p (search-backward word bound t)))
-	(let ((lw (flyspell-get-word '())))
+	(let ((lw (flyspell-get-word)))
 	  (if (and (consp lw) (string-equal (car lw) word))
 	      (setq r p)
 	    (goto-char p))))
@@ -1001,7 +1001,7 @@ Mostly we check word delimiters."
 	  (inhibit-point-motion-hooks t)
 	  p)
       (while (and (not r) (setq p (search-forward word bound t)))
-	(let ((lw (flyspell-get-word '())))
+	(let ((lw (flyspell-get-word))
 	  (if (and (consp lw) (string-equal (car lw) word))
 	      (setq r p)
 	    (goto-char (1+ p)))))
@@ -1250,7 +1250,7 @@ this function changes the last char of the `ispell-casechars' string."
 ;;*---------------------------------------------------------------------*/
 ;;*    flyspell-get-word ...                                            */
 ;;*---------------------------------------------------------------------*/
-(defun flyspell-get-word (following &optional extra-otherchars)
+(defun flyspell-get-word (&optional following extra-otherchars)
   "Return the word for spell-checking according to Ispell syntax.
 If optional argument FOLLOWING is non-nil or if `flyspell-following-word'
 is non-nil when called interactively, then the following word
@@ -1394,7 +1394,7 @@ The buffer to mark them in is `flyspell-large-region-buffer'."
 			      ;; Move back into the match
 			      ;; so flyspell-get-word will find it.
 			      (forward-char -1)
-			      (flyspell-get-word nil)))
+			      (flyspell-get-word)))
 			   (found (car found-list))
 			   (found-length (length found))
 			   (misspell-length (length word)))
@@ -1887,7 +1887,7 @@ This command proposes various successive corrections for the current word."
 	  (flyspell-ajust-cursor-point pos (point) old-max)
 	  (setq flyspell-auto-correct-pos (point)))
       ;; fetch the word to be checked
-      (let ((word (flyspell-get-word nil)))
+      (let ((word (flyspell-get-word)))
 	(if (consp word)
 	    (let ((start (car (cdr word)))
 		  (end (car (cdr (cdr word))))
@@ -2049,7 +2049,7 @@ If OPOINT is non-nil, restore point there after adjusting it for replacement."
   (flyspell-accept-buffer-local-defs)
   (or opoint (setq opoint (point)))
   (let ((cursor-location (point))
-	(word (flyspell-get-word nil)))
+	(word (flyspell-get-word)))
     (if (consp word)
 	(let ((start (car (cdr word)))
 	      (end (car (cdr (cdr word))))
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#4577: marked as done ([PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring)
  2009-09-28 11:20 ` bug#4577: [PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring Jari Aalto
@ 2009-10-17  3:20   ` Emacs bug Tracking System
  0 siblings, 0 replies; 2+ messages in thread
From: Emacs bug Tracking System @ 2009-10-17  3:20 UTC (permalink / raw)
  To: Glenn Morris

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

Your message dated Fri, 16 Oct 2009 23:10:33 -0400
with message-id <qjhbtyg1g6.fsf@fencepost.gnu.org>
and subject line Re: Bug#4577: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
has caused the Emacs bug report #4577,
regarding [PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4577: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4577
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5880 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 890 bytes --]

Tags: patch

The documentation of flyspell-get-word reads that there are no required
parameters. All are optional. The patch updates to code according to
docstring.

2009-09-28  Jari Aalto  <jari.aalto@cante.net>

        * textmodes/flyspell.el (flyspell-get-word): Correct function argment
        list according to docstring. Parameter `following' is optional
        (flyspell-external-point-words): Remove `nil' argument from call
        to `flyspell-get-word'.
        (flyspell-auto-correct-word): Remove `nil' argument from call to
        `flyspell-get-word'.
        (flyspell-correct-word-before-point): Remove `nil' argument from
        call to `flyspell-get-word'.
        (flyspell-word-search-forward): Remove `nil' argument from call to
        `flyspell-get-word'.
        (flyspell-word-search-backward): Remove `nil' argument from call to
        `flyspell-get-word'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: 0001-lisp-textmodes-flyspell.el-flyspell-get-word-Correct.patch --]
[-- Type: text/x-diff, Size: 3082 bytes --]

From a225dd1077da59791bddd77b9f62e43e1c02a9cb Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Mon, 28 Sep 2009 14:18:05 +0300
Subject: [PATCH] lisp/textmodes/flyspell.el: (flyspell-get-word): Correct function argment list according to docstring


Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 lisp/textmodes/flyspell.el |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
index eff19e6..8ee0220 100644
--- a/lisp/textmodes/flyspell.el
+++ b/lisp/textmodes/flyspell.el
@@ -986,7 +986,7 @@ Mostly we check word delimiters."
 	  (inhibit-point-motion-hooks t)
 	  p)
       (while (and (not r) (setq p (search-backward word bound t)))
-	(let ((lw (flyspell-get-word '())))
+	(let ((lw (flyspell-get-word)))
 	  (if (and (consp lw) (string-equal (car lw) word))
 	      (setq r p)
 	    (goto-char p))))
@@ -1001,7 +1001,7 @@ Mostly we check word delimiters."
 	  (inhibit-point-motion-hooks t)
 	  p)
       (while (and (not r) (setq p (search-forward word bound t)))
-	(let ((lw (flyspell-get-word '())))
+	(let ((lw (flyspell-get-word))
 	  (if (and (consp lw) (string-equal (car lw) word))
 	      (setq r p)
 	    (goto-char (1+ p)))))
@@ -1250,7 +1250,7 @@ this function changes the last char of the `ispell-casechars' string."
 ;;*---------------------------------------------------------------------*/
 ;;*    flyspell-get-word ...                                            */
 ;;*---------------------------------------------------------------------*/
-(defun flyspell-get-word (following &optional extra-otherchars)
+(defun flyspell-get-word (&optional following extra-otherchars)
   "Return the word for spell-checking according to Ispell syntax.
 If optional argument FOLLOWING is non-nil or if `flyspell-following-word'
 is non-nil when called interactively, then the following word
@@ -1394,7 +1394,7 @@ The buffer to mark them in is `flyspell-large-region-buffer'."
 			      ;; Move back into the match
 			      ;; so flyspell-get-word will find it.
 			      (forward-char -1)
-			      (flyspell-get-word nil)))
+			      (flyspell-get-word)))
 			   (found (car found-list))
 			   (found-length (length found))
 			   (misspell-length (length word)))
@@ -1887,7 +1887,7 @@ This command proposes various successive corrections for the current word."
 	  (flyspell-ajust-cursor-point pos (point) old-max)
 	  (setq flyspell-auto-correct-pos (point)))
       ;; fetch the word to be checked
-      (let ((word (flyspell-get-word nil)))
+      (let ((word (flyspell-get-word)))
 	(if (consp word)
 	    (let ((start (car (cdr word)))
 		  (end (car (cdr (cdr word))))
@@ -2049,7 +2049,7 @@ If OPOINT is non-nil, restore point there after adjusting it for replacement."
   (flyspell-accept-buffer-local-defs)
   (or opoint (setq opoint (point)))
   (let ((cursor-location (point))
-	(word (flyspell-get-word nil)))
+	(word (flyspell-get-word)))
     (if (consp word)
 	(let ((start (car (cdr word)))
 	      (end (car (cdr (cdr word))))
-- 
1.6.3.3


[-- Attachment #3: Type: message/rfc822, Size: 1507 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 4577-done@emacsbugs.donarmstrong.com
Subject: Re: Bug#4577: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring
Date: Fri, 16 Oct 2009 23:10:33 -0400
Message-ID: <qjhbtyg1g6.fsf@fencepost.gnu.org>


Thanks; applied (with paren typo corrected).

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-17  3:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <qjhbtyg1g6.fsf@fencepost.gnu.org>
2009-09-28 11:20 ` bug#4577: [PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring Jari Aalto
2009-10-17  3:20   ` bug#4577: marked as done ([PATCH] Emacs CVS: flyspell.el: (flyspell-get-word): Correct function argment list according to docstring) Emacs bug Tracking System

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).