bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)

bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)

[Matthieu Moy]

Hi,

Short version: whether I enable dbus or not, newest Emacs fails to
compile on my system.

Longer version:
With the same configuration I used to succeed in compiling Emacs on my
machine, I now get this error at link time:

dbusbind.o: In function `xd_remove_watch':
/home/moy/local/usr/src/emacs/src/dbusbind.c:766: undefined reference to `dbus_watch_get_unix_fd'
/home/moy/local/usr/src/emacs/src/dbusbind.c:768: undefined reference to `dbus_watch_get_socket'
dbusbind.o: In function `xd_add_watch':
/home/moy/local/usr/src/emacs/src/dbusbind.c:741: undefined reference to `dbus_watch_get_unix_fd'
/home/moy/local/usr/src/emacs/src/dbusbind.c:743: undefined reference to `dbus_watch_get_socket'
collect2: ld returned 1 exit status

Fine, I thought, my dbus is too old, I don't need it, I'll disable it.
But compiling with --without-dbus, it doesn't work either:

Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc
Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el
Loading tramp...

In toplevel form:
../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus
make[2]: *** [...] Error 1

Reproducible with a fresh checkout.

Ideally, Emacs should be tought not to use inexisting functions in
libdbus, but at least, fixing the build with --without-dbus should be
done.

Thanks in advance,

$ uname -a
Linux bauges 2.6.29.3-686 #1 SMP PREEMPT Thu May 14 12:01:17 CEST 2009 i686 GNU/Linux
$ cat /etc/debian_version 
4.0

(rest of message mostly irrelevant, since I'm posting from another
Emacs instance)

In GNU Emacs 23.0.91.2 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2009-03-17 on bauges
Windowing system distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  '--prefix=/home/moy/local/usr/''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Term

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  erc-track-mode: t
  recentf-mode: t
  global-whitespace-mode: t
  global-hl-line-mode: t
  icomplete-mode: t
  auto-image-file-mode: t
  which-function-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: (only)

Recent input:
[...]

Recent messages:
nndiary: Reading incoming mail from file...
nndiary: Reading incoming mail (no new mail)...done
Reading active file via nndiary...done
Reading active file from archive via nnfolder...done
Checking new news...done
(No changes need to be saved)
No more unread newsgroups [2 times]
(No changes need to be saved)
Mark set
(No changes need to be saved)

-- 
Matthieu

bug#4201: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)

[Matthieu Moy]

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> Fine, I thought, my dbus is too old, I don't need it, I'll disable it.
> But compiling with --without-dbus, it doesn't work either:
>
> Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc
> Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el
> Loading tramp...
>
> In toplevel form:
> ../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus
> make[2]: *** [...] Error 1

This happens since this revision below (thanks to 'git bisect' ;-) ).
Reverting it fixes the problem for me. I guess the important part was
the

  (when (and (featurep 'dbusbind) (not (featurep 'dbus)))

which got lost in the process.


commit f1a6beaaeea05ae21131f38ed5ff243046fb29f2
Author: Michael Albinus <michael.albinus@gmx.de>
Date:   Wed Aug 19 07:08:57 2009 +0000

    * net/dbus.el (top): Apply `dbus-init-bus' for the :session bus
    only if it is running already.

diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el
index c1222a6..159fcb6 100644
--- a/lisp/net/dbus.el
+++ b/lisp/net/dbus.el
@@ -41,15 +41,6 @@
 (defvar dbus-debug)
 (defvar dbus-registered-functions-table)
 
-;; Initialize :system and :session buses.  This adds their file
-;; descriptors to input_wait_mask, in order to detect incoming
-;; messages immediately.
-;; We must avoid to call the function twice for a bus, because the
-;; DBusWatch will be removed then.
-(when (and (featurep 'dbusbind) (not (featurep 'dbus)))
-  (dbus-init-bus :system)
-  (dbus-init-bus :session))
-
 ;; Pacify byte compiler.
 (eval-when-compile
   (require 'cl))
@@ -841,6 +832,14 @@ name of the property, and its value.  If there are no properties,
 	 (cons property (dbus-get-property bus service path interface property))
 	 'append)))))
 
+;; Initialize :system and :session buses.  This adds their file
+;; descriptors to input_wait_mask, in order to detect incoming
+;; messages immediately.
+(dbus-ignore-errors
+  (dbus-init-bus :system)
+  (when (getenv "DBUS_SESSION_BUS_ADDRESS")
+    (dbus-init-bus :session)))
+
 (provide 'dbus)
 
 ;; arch-tag: a47caf84-9162-4811-90cc-5d388e37b9bd

-- 
Matthieu

bug#4186: marked as done (23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Your message dated Fri, 21 Aug 2009 10:55:44 +0200
with message-id <nqws4xo8a7.fsf@alcatel-lucent.de>
and subject line Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
has caused the Emacs bug report #4186,
regarding 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4186: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4186
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5947 bytes --]

From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
Date: Wed, 19 Aug 2009 14:21:05 +0200
Message-ID: <vpqy6pgngem.fsf@bauges.imag.fr>

Hi,

Short version: whether I enable dbus or not, newest Emacs fails to
compile on my system.

Longer version:
With the same configuration I used to succeed in compiling Emacs on my
machine, I now get this error at link time:

dbusbind.o: In function `xd_remove_watch':
/home/moy/local/usr/src/emacs/src/dbusbind.c:766: undefined reference to `dbus_watch_get_unix_fd'
/home/moy/local/usr/src/emacs/src/dbusbind.c:768: undefined reference to `dbus_watch_get_socket'
dbusbind.o: In function `xd_add_watch':
/home/moy/local/usr/src/emacs/src/dbusbind.c:741: undefined reference to `dbus_watch_get_unix_fd'
/home/moy/local/usr/src/emacs/src/dbusbind.c:743: undefined reference to `dbus_watch_get_socket'
collect2: ld returned 1 exit status

Fine, I thought, my dbus is too old, I don't need it, I'll disable it.
But compiling with --without-dbus, it doesn't work either:

Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc
Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el
Loading tramp...

In toplevel form:
../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus
make[2]: *** [...] Error 1

Reproducible with a fresh checkout.

Ideally, Emacs should be tought not to use inexisting functions in
libdbus, but at least, fixing the build with --without-dbus should be
done.

Thanks in advance,

$ uname -a
Linux bauges 2.6.29.3-686 #1 SMP PREEMPT Thu May 14 12:01:17 CEST 2009 i686 GNU/Linux
$ cat /etc/debian_version 
4.0

(rest of message mostly irrelevant, since I'm posting from another
Emacs instance)

In GNU Emacs 23.0.91.2 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2009-03-17 on bauges
Windowing system distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  '--prefix=/home/moy/local/usr/''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Term

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  erc-track-mode: t
  recentf-mode: t
  global-whitespace-mode: t
  global-hl-line-mode: t
  icomplete-mode: t
  auto-image-file-mode: t
  which-function-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: (only)

Recent input:
[...]

Recent messages:
nndiary: Reading incoming mail from file...
nndiary: Reading incoming mail (no new mail)...done
Reading active file via nndiary...done
Reading active file from archive via nnfolder...done
Checking new news...done
(No changes need to be saved)
No more unread newsgroups [2 times]
(No changes need to be saved)
Mark set
(No changes need to be saved)

-- 
Matthieu


[-- Attachment #3: Type: message/rfc822, Size: 2237 bytes --]

From: Michael Albinus <michael.albinus@gmx.de>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: <4186-done@emacsbugs.donarmstrong.com>
Subject: Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
Date: Fri, 21 Aug 2009 10:55:44 +0200
Message-ID: <nqws4xo8a7.fsf@alcatel-lucent.de>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

>> Both functions have been added in D-Bus 1.1.1. I've committed a fix,
>> which checks the availability of these functions.
>
> [...]
>
>> Yes, I've reenabled the check for (featurep 'dbusbind)
>
> Great job, Emacs compiles both --with and --without-dbus now.

OK, so I close the ticket.

> Thanks a lot!

Best regards, Michael.

bug#4201: marked as done (23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem))

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Your message dated Fri, 21 Aug 2009 10:55:44 +0200
with message-id <nqws4xo8a7.fsf@alcatel-lucent.de>
and subject line Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
has caused the Emacs bug report #4186,
regarding 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4186: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4186
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5147 bytes --]

From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
Date: Wed, 19 Aug 2009 15:41:01 +0200
Message-ID: <vpqr5v7ncpe.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> Fine, I thought, my dbus is too old, I don't need it, I'll disable it.
> But compiling with --without-dbus, it doesn't work either:
>
> Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc
> Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el
> Loading tramp...
>
> In toplevel form:
> ../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus
> make[2]: *** [...] Error 1

This happens since this revision below (thanks to 'git bisect' ;-) ).
Reverting it fixes the problem for me. I guess the important part was
the

  (when (and (featurep 'dbusbind) (not (featurep 'dbus)))

which got lost in the process.


commit f1a6beaaeea05ae21131f38ed5ff243046fb29f2
Author: Michael Albinus <michael.albinus@gmx.de>
Date:   Wed Aug 19 07:08:57 2009 +0000

    * net/dbus.el (top): Apply `dbus-init-bus' for the :session bus
    only if it is running already.

diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el
index c1222a6..159fcb6 100644
--- a/lisp/net/dbus.el
+++ b/lisp/net/dbus.el
@@ -41,15 +41,6 @@
 (defvar dbus-debug)
 (defvar dbus-registered-functions-table)
 
-;; Initialize :system and :session buses.  This adds their file
-;; descriptors to input_wait_mask, in order to detect incoming
-;; messages immediately.
-;; We must avoid to call the function twice for a bus, because the
-;; DBusWatch will be removed then.
-(when (and (featurep 'dbusbind) (not (featurep 'dbus)))
-  (dbus-init-bus :system)
-  (dbus-init-bus :session))
-
 ;; Pacify byte compiler.
 (eval-when-compile
   (require 'cl))
@@ -841,6 +832,14 @@ name of the property, and its value.  If there are no properties,
 	 (cons property (dbus-get-property bus service path interface property))
 	 'append)))))
 
+;; Initialize :system and :session buses.  This adds their file
+;; descriptors to input_wait_mask, in order to detect incoming
+;; messages immediately.
+(dbus-ignore-errors
+  (dbus-init-bus :system)
+  (when (getenv "DBUS_SESSION_BUS_ADDRESS")
+    (dbus-init-bus :session)))
+
 (provide 'dbus)
 
 ;; arch-tag: a47caf84-9162-4811-90cc-5d388e37b9bd

-- 
Matthieu


[-- Attachment #3: Type: message/rfc822, Size: 2237 bytes --]

From: Michael Albinus <michael.albinus@gmx.de>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: <4186-done@emacsbugs.donarmstrong.com>
Subject: Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
Date: Fri, 21 Aug 2009 10:55:44 +0200
Message-ID: <nqws4xo8a7.fsf@alcatel-lucent.de>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

>> Both functions have been added in D-Bus 1.1.1. I've committed a fix,
>> which checks the availability of these functions.
>
> [...]
>
>> Yes, I've reenabled the check for (featurep 'dbusbind)
>
> Great job, Emacs compiles both --with and --without-dbus now.

OK, so I close the ticket.

> Thanks a lot!

Best regards, Michael.