* bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared @ 2009-06-22 20:40 ` Yavor Doganov 2009-06-25 21:33 ` Stefan Monnier 2009-07-23 14:50 ` bug#3652: marked as done (FTBFS: " Emacs bug Tracking System 0 siblings, 2 replies; 8+ messages in thread From: Yavor Doganov @ 2009-06-22 20:40 UTC (permalink / raw) To: emacs-pretest-bug Package: emacs,ns Severity: serious Tags: patch The GNUstep port fails to build currently following this change: 2009-06-08 Adrian Robert <Adrian.B.Robert@gmail.com> Changes to support :script/:lang/:otf in NS font driver. ... I believe it's a bug in GNUstep GUI which I'll report to their tracker. For now, I suggest the workaround below. What's worse is that the NSFontDescriptor class was implemented in GUI 0.13, while gNewSense DeltaH has 0.12. Do you consider it important enough to add a fallback code? Changelog: 2009-06-22 Yavor Doganov <yavor@gnu.org> * configure.in: Check for <AppKit/NSFontdescriptor.h>. *** configure.in 22 юни 2009 22:30:12 +0300 1.599 --- configure.in 22 юни 2009 23:29:18 +0300 *************** *** 1257,1262 **** --- 1257,1264 ---- AC_CHECK_HEADER([AppKit/AppKit.h], [HAVE_NS=yes], [AC_MSG_ERROR([`--with-ns' was specified, but the include files are missing or cannot be compiled.])]) + AC_CHECK_HEADER([AppKit/NSFontDescriptor.h], [], + [AC_MSG_ERROR([NSFontDescriptor is required.])]) NS_HAVE_NSINTEGER=yes AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <Foundation/NSObjCRuntime.h>], [NSInteger i;])], src/ChangeLog: 2009-06-22 Yavor Doganov <yavor@gnu.org> * nsfont.m: Import <AppKit/NSFontDescriptor.h>. *** nsfont.m 18 юни 2009 12:35:30 +0300 1.26 --- nsfont.m 22 юни 2009 22:35:30 +0300 *************** *** 37,42 **** --- 37,47 ---- #include "character.h" #include "font.h" + /* This header is not included from GNUstep's (0.16.0) AppKit.h. */ + #ifdef NS_IMPL_GNUSTEP + #import <AppKit/NSFontDescriptor.h> + #endif + #define NSFONT_TRACE 0 extern Lisp_Object Qns; ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared 2009-06-22 20:40 ` bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Yavor Doganov @ 2009-06-25 21:33 ` Stefan Monnier 2009-06-25 21:55 ` Yavor Doganov 2009-07-23 14:50 ` bug#3652: marked as done (FTBFS: " Emacs bug Tracking System 1 sibling, 1 reply; 8+ messages in thread From: Stefan Monnier @ 2009-06-25 21:33 UTC (permalink / raw) To: Yavor Doganov; +Cc: emacs-pretest-bug, 3652 > What's worse is that the NSFontDescriptor class was implemented in GUI > 0.13, while gNewSense DeltaH has 0.12. Do you consider it important > enough to add a fallback code? Given that the GNUStep code is not yet functional, I'd rather not worry about such fallback code. Stefan ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared 2009-06-25 21:33 ` Stefan Monnier @ 2009-06-25 21:55 ` Yavor Doganov [not found] ` <handler.3652.B3652.124596691916601.ackinfo@emacsbugs.donarmstrong.com> 0 siblings, 1 reply; 8+ messages in thread From: Yavor Doganov @ 2009-06-25 21:55 UTC (permalink / raw) To: Stefan Monnier; +Cc: Yavor Doganov, 3652 Stefan Monnier wrote: > > NSFontDescriptor class was implemented in GUI 0.13, while > > gNewSense DeltaH has 0.12. > > Given that the GNUStep code is not yet functional, I'd rather not worry > about such fallback code. OK, this is undestandable and makes sense (especially having in mind that the majority of the GNUstep users compile SVN trunk; 0.12 is an "ancient" GUI release by all standards). (I'll revert Adrian's changes as a local patch to my unofficial gNS package then, with all the bad things that this implies...) ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <handler.3652.B3652.124596691916601.ackinfo@emacsbugs.donarmstrong.com>]
* bug#3652: Info received (bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared) [not found] ` <handler.3652.B3652.124596691916601.ackinfo@emacsbugs.donarmstrong.com> @ 2009-06-25 22:43 ` Yavor Doganov 2009-06-25 22:50 ` Processed: " Emacs bug Tracking System 2009-06-25 22:53 ` Yavor Doganov 0 siblings, 2 replies; 8+ messages in thread From: Yavor Doganov @ 2009-06-25 22:43 UTC (permalink / raw) To: 3652; +Cc: Yavor Doganov reopen 3652 found 3652 23.0.95 thanks I'm not sure why this bug got closed. Regardless of what I said about gNewSense and its lack of NSFontDescriptor implementation, the GNUstep port of Emacs still fails to build on a fairly modern Debian system with the latest GNUstep stable release installed: $ dpkg -l libgnustep-gui-dev Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err: uppercase=bad) ||/ Name Version Description +++-==============-==============-============================================ ii libgnustep-gui 0.16.0-2 GNUstep GUI header files and static librarie This is only because the type definitions and method declarations are in NSFontDescriptor.h, which is not included neither from AppKit.h nor from the related NSFont headers. A simple #import of this header in nsfont.m fixes this. Not an Emacs bug, I believe, but easy to workaround, at least temporarily. The specific error message follows. nsfont.m: In function ‘ns_attribute_fvalue’: nsfont.m:117: error: ‘NSFontTraitsAttribute’ undeclared (first use in this func\ tion) nsfont.m:117: error: (Each undeclared identifier is reported only once nsfont.m:117: error: for each function it appears in.) nsfont.m: In function ‘ns_spec_to_descriptor’: nsfont.m:148: error: ‘NSFontWeightTrait’ undeclared (first use in this function\ ) nsfont.m:152: error: ‘NSFontSlantTrait’ undeclared (first use in this function) nsfont.m:156: error: ‘NSFontWidthTrait’ undeclared (first use in this function) nsfont.m:158: error: ‘NSFontTraitsAttribute’ undeclared (first use in this func\ tion) nsfont.m:160: warning: no ‘+fontDescriptorWithFontAttributes:’ method found nsfont.m:160: warning: (Messages without a matching method signature nsfont.m:160: warning: will be assumed to return ‘id’ and accept nsfont.m:160: warning: ‘...’ as arguments.) nsfont.m:162: warning: no ‘-fontDescriptorWithFamily:’ method found nsfont.m: In function ‘ns_descriptor_to_entity’: nsfont.m:173: error: ‘NSFontFamilyAttribute’ undeclared (first use in this func\ tion) nsfont.m:175: warning: no ‘-symbolicTraits’ method found nsfont.m:175: warning: initialization makes integer from pointer without a cast nsfont.m:185: error: ‘NSFontBoldTrait’ undeclared (first use in this function) nsfont.m:190: error: ‘NSFontItalicTrait’ undeclared (first use in this function\ ) nsfont.m:195: error: ‘NSFontCondensedTrait’ undeclared (first use in this funct\ ion) nsfont.m:195: error: ‘NSFontExpandedTrait’ undeclared (first use in this functi\ on) nsfont.m:204: warning: no ‘-symbolicTraits’ method found nsfont.m:175: warning: initialization makes integer from pointer without a cast nsfont.m:185: error: ‘NSFontBoldTrait’ undeclared (first use in this function) nsfont.m:190: error: ‘NSFontItalicTrait’ undeclared (first use in this function\ ) nsfont.m:195: error: ‘NSFontCondensedTrait’ undeclared (first use in this funct\ ion) nsfont.m:195: error: ‘NSFontExpandedTrait’ undeclared (first use in this functi\ on) nsfont.m:204: warning: no ‘-symbolicTraits’ method found nsfont.m:204: error: ‘NSFontMonoSpaceTrait’ undeclared (first use in this funct\ ion) nsfont.m: In function ‘ns_findfonts’: nsfont.m:477: warning: no ‘-fontAttributes’ method found nsfont.m:479: error: ‘NSFontFamilyAttribute’ undeclared (first use in this func\ tion) nsfont.m:481: warning: no ‘-matchingFontDescriptorsWithMandatoryKeys:’ method f\ ound nsfont.m:494: error: ‘NSFontSlantTrait’ undeclared (first use in this function) nsfont.m:503: error: ‘NSFontItalicTrait’ undeclared (first use in this function\ ) nsfont.m:503: warning: no ‘-fontDescriptorWithSymbolicTraits:’ method found nsfont.m:504: warning: no ‘-fontDescriptorWithFamily:’ method found nsfont.m: In function ‘nsfont_open’: nsfont.m:670: error: ‘NSFontWeightTrait’ undeclared (first use in this function\ ) nsfont.m:672: error: ‘NSFontSlantTrait’ undeclared (first use in this function) nsfont.m:797: warning: incompatible implicit declaration of built-in function ‘\ lrint’ nsfont.m: In function ‘ns_glyph_metrics’: nsfont.m:1375: warning: incompatible implicit declaration of built-in function \ ‘lrint’ nsfont.m:1380: warning: incompatible implicit declaration of built-in function \ ‘round’ make[1]: *** [nsfont.o] Error 1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Processed: Re: bug#3652: Info received (bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared) 2009-06-25 22:43 ` bug#3652: Info received (bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared) Yavor Doganov @ 2009-06-25 22:50 ` Emacs bug Tracking System 2009-06-25 22:53 ` Yavor Doganov 1 sibling, 0 replies; 8+ messages in thread From: Emacs bug Tracking System @ 2009-06-25 22:50 UTC (permalink / raw) To: Yavor Doganov; +Cc: Emacs Bugs, ns for {3652} Processing commands for control@emacsbugs.donarmstrong.com: > reopen 3652 bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared bug is already open, cannot reopen. > found 3652 23.0.95 bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Warning: Unknown package 'ns' bug marked as found in version 23.0.95. > thanks Stopping processing here. Please contact me if you need assistance. Don Armstrong (administrator, Emacs bugs database) ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#3652: Info received (bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared) 2009-06-25 22:43 ` bug#3652: Info received (bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared) Yavor Doganov 2009-06-25 22:50 ` Processed: " Emacs bug Tracking System @ 2009-06-25 22:53 ` Yavor Doganov 1 sibling, 0 replies; 8+ messages in thread From: Yavor Doganov @ 2009-06-25 22:53 UTC (permalink / raw) To: 3652, Yavor Doganov Явор Доганов wrote: > I'm not sure why this bug got closed. I sincerely apologize. It was not closed. I simply got confused by the "ACK" message from the BTS as I'm used to receiving these only from Debian's BTS... :/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#3652: marked as done (FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared) 2009-06-22 20:40 ` bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Yavor Doganov 2009-06-25 21:33 ` Stefan Monnier @ 2009-07-23 14:50 ` Emacs bug Tracking System 1 sibling, 0 replies; 8+ messages in thread From: Emacs bug Tracking System @ 2009-07-23 14:50 UTC (permalink / raw) To: Adrian Robert [-- Attachment #1: Type: text/plain, Size: 908 bytes --] Your message dated Thu, 23 Jul 2009 10:43:36 -0400 with message-id <EFE22F66-15B5-49AD-B1F8-F241D3ED6C8A@gmail.com> and subject line Re: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared has caused the Emacs bug report #3652, regarding FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 3652: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3652 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 4832 bytes --] From: Yavor Doganov <yavor@gnu.org> To: emacs-pretest-bug@gnu.org Subject: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Date: Mon, 22 Jun 2009 23:40:22 +0300 Message-ID: <87hby86lzd.GNU's_Not_Unix!%yavor@gnu.org> Package: emacs,ns Severity: serious Tags: patch The GNUstep port fails to build currently following this change: 2009-06-08 Adrian Robert <Adrian.B.Robert@gmail.com> Changes to support :script/:lang/:otf in NS font driver. ... I believe it's a bug in GNUstep GUI which I'll report to their tracker. For now, I suggest the workaround below. What's worse is that the NSFontDescriptor class was implemented in GUI 0.13, while gNewSense DeltaH has 0.12. Do you consider it important enough to add a fallback code? Changelog: 2009-06-22 Yavor Doganov <yavor@gnu.org> * configure.in: Check for <AppKit/NSFontdescriptor.h>. *** configure.in 22 юни 2009 22:30:12 +0300 1.599 --- configure.in 22 юни 2009 23:29:18 +0300 *************** *** 1257,1262 **** --- 1257,1264 ---- AC_CHECK_HEADER([AppKit/AppKit.h], [HAVE_NS=yes], [AC_MSG_ERROR([`--with-ns' was specified, but the include files are missing or cannot be compiled.])]) + AC_CHECK_HEADER([AppKit/NSFontDescriptor.h], [], + [AC_MSG_ERROR([NSFontDescriptor is required.])]) NS_HAVE_NSINTEGER=yes AC_COMPILE_IFELSE([AC_LANG_PROGRAM([#include <Foundation/NSObjCRuntime.h>], [NSInteger i;])], src/ChangeLog: 2009-06-22 Yavor Doganov <yavor@gnu.org> * nsfont.m: Import <AppKit/NSFontDescriptor.h>. *** nsfont.m 18 юни 2009 12:35:30 +0300 1.26 --- nsfont.m 22 юни 2009 22:35:30 +0300 *************** *** 37,42 **** --- 37,47 ---- #include "character.h" #include "font.h" + /* This header is not included from GNUstep's (0.16.0) AppKit.h. */ + #ifdef NS_IMPL_GNUSTEP + #import <AppKit/NSFontDescriptor.h> + #endif + #define NSFONT_TRACE 0 extern Lisp_Object Qns; [-- Attachment #3: Type: message/rfc822, Size: 2787 bytes --] From: Adrian Robert <adrian.b.robert@gmail.com> To: 3652-done@emacsbugs.donarmstrong.com Subject: Re: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Date: Thu, 23 Jul 2009 10:43:36 -0400 Message-ID: <EFE22F66-15B5-49AD-B1F8-F241D3ED6C8A@gmail.com> Closing. I've checked in Yavor's change to nsfont.m to include NSFontDescriptor.h, but am leaving out the configure.in change -- it will slow down the configure for all NS builds for a condition that is hopefully temporary, and anyway the compile error message should be clear enough for builders. ^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#3652: Fwd: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared [not found] <EFE22F66-15B5-49AD-B1F8-F241D3ED6C8A@gmail.com> 2009-06-22 20:40 ` bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Yavor Doganov @ 2009-07-24 16:22 ` Adrian Robert 1 sibling, 0 replies; 8+ messages in thread From: Adrian Robert @ 2009-07-24 16:22 UTC (permalink / raw) To: 3652; +Cc: Yavor Doganov I tried to close it but the bug tracker didn't want to listen. Anyway, I've checked in the change to #include NSFontDescriptor.h, but let's leave this open now to track the fact that a workaround is needed for GNUstep's lack of a working NSFontDescriptor-matchingFontDescriptorsWithMandatoryKeys:. http://article.gmane.org/gmane.emacs.devel/113101 ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-07-24 16:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <EFE22F66-15B5-49AD-B1F8-F241D3ED6C8A@gmail.com>
2009-06-22 20:40 ` bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Yavor Doganov
2009-06-25 21:33 ` Stefan Monnier
2009-06-25 21:55 ` Yavor Doganov
[not found] ` <handler.3652.B3652.124596691916601.ackinfo@emacsbugs.donarmstrong.com>
2009-06-25 22:43 ` bug#3652: Info received (bug#3652: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared) Yavor Doganov
2009-06-25 22:50 ` Processed: " Emacs bug Tracking System
2009-06-25 22:53 ` Yavor Doganov
2009-07-23 14:50 ` bug#3652: marked as done (FTBFS: " Emacs bug Tracking System
2009-07-24 16:22 ` bug#3652: Fwd: FTBFS: nsfont.m: 'NSFontTraitsAttribute' undeclared Adrian Robert
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).