bug#3570: 23.0.94; vc-default-revision-granularity missing argument

bug#3570: 23.0.94; vc-default-revision-granularity missing argument

[Magnus Henoch]

Package: emacs,vc
Severity: minor

The function vc-default-revision-granularity should accept a backend
argument, but doesn't.  This gives users of outdated third-party VC
backends confusing error messages at times.

To reproduce:
(progn
  (provide 'vc-foo)
  (vc-call-backend 'foo 'revision-granularity))

Expected: (error "Your backend will not work with this version of VC mode.")
Actual result: wrong-number-of-arguments

Regards,
Magnus

bug#3570: marked as done (23.0.94; vc-default-revision-granularity missing argument)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]


Your message dated Mon, 15 Jun 2009 16:57:30 -0400
with message-id <jwvski1jjxi.fsf-monnier+emacsbugreports@gnu.org>
and subject line Re: bug#3570: 23.0.94; vc-default-revision-granularity missing argument
has caused the Emacs bug report #3570,
regarding 23.0.94; vc-default-revision-granularity missing argument
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3570: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3570
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2558 bytes --]

From: Magnus Henoch <magnus.henoch@gmail.com>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.94; vc-default-revision-granularity missing argument
Date: Mon, 15 Jun 2009 12:26:25 +0100
Message-ID: <84iqix4u1q.fsf@linux-b2a3.site>

Package: emacs,vc
Severity: minor

The function vc-default-revision-granularity should accept a backend
argument, but doesn't.  This gives users of outdated third-party VC
backends confusing error messages at times.

To reproduce:
(progn
  (provide 'vc-foo)
  (vc-call-backend 'foo 'revision-granularity))

Expected: (error "Your backend will not work with this version of VC mode.")
Actual result: wrong-number-of-arguments

Regards,
Magnus


[-- Attachment #3: Type: message/rfc822, Size: 1859 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Magnus Henoch <magnus.henoch@gmail.com>
Cc: 3570-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3570: 23.0.94; vc-default-revision-granularity missing argument
Date: Mon, 15 Jun 2009 16:57:30 -0400
Message-ID: <jwvski1jjxi.fsf-monnier+emacsbugreports@gnu.org>

> The function vc-default-revision-granularity should accept a backend
> argument, but doesn't.  This gives users of outdated third-party VC
> backends confusing error messages at times.

Thanks.  I've simply removed it, since the default error message works
just as well (and better than `wrong arg number' in any case).


        Stefan