bug#3432: [h-e-w] 23.0.93; dired encoding

bug#3432: [h-e-w] 23.0.93; dired encoding

[Lennart Borgman]

Hi again Konstantin, please use the unpatched version for the bug
report. That will send it to Emacs maintainers and not here.


On Sun, May 31, 2009 at 4:51 PM, Konstantin <Kostafey@yandex.ru> wrote:
> Hi, Emacs maintainers!
>
> I'he got the following trouble/bug.
>
> I've tested it on emacs-from-cvs-090503, OS WinXP Home SP2.
>
> On type M-x dired emacs shows \316\362\361\363\362\361\362\342\363\345\362 instead of root.
>
> Here is example:
>
> drwxrwxrwx  1 Administrators SYSTEM                                         0 05-30 13:34 Common Files
> drwxrwxrwx  1 User           \316\362\361\363\362\361\362\342\363\345\362   0 01-19 00:10 Comodo
>
> Emacs 22.3 if free of it:
>
> drwxrwxrwx  1 User           root        0 05-30 13:34 Common Files
> drwxrwxrwx  1 User           root        0 01-19 00:10 Comodo
>
> My codepage is 1251.
>
> I try to add my .emacs somthing like this:
> (setq file-name-coding-system 'utf-8)
> or
> (setq file-name-coding-system 'cp1251)
> but nothing changed.
>
> ---------------------------------------------
>
> In GNU Emacs 23.0.93.1 (i386-mingw-nt5.1.2600)
>  of 2009-05-03 on LENNART-69DE564
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping'
>
> Important settings:
>  value of $LC_ALL: nil
>  value of $LC_COLLATE: nil
>  value of $LC_CTYPE: nil
>  value of $LC_MESSAGES: nil
>  value of $LC_MONETARY: nil
>  value of $LC_NUMERIC: nil
>  value of $LC_TIME: nil
>  value of $LANG: ru
>  value of $XMODIFIERS: nil
>  locale-coding-system: cp1251
>  default-enable-multibyte-characters: t
>
> Major mode: Dired by name
>
> Minor modes in effect:
>  tooltip-mode: t
>  tool-bar-mode: t
>  mouse-wheel-mode: t
>  menu-bar-mode: t
>  file-name-shadow-mode: t
>  global-font-lock-mode: t
>  font-lock-mode: t
>  blink-cursor-mode: t
>  global-auto-composition-mode: t
>  auto-composition-mode: t
>  auto-encryption-mode: t
>  auto-compression-mode: t
>  line-number-mode: t
>  transient-mark-mode: t
>
> Recent input:
> M-x d i r e d <return> <return> <help-echo> M-x r e
> p o r t - e m a c s - b u g <return>
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
>
> --
> Konstantin <Kostafey@yandex.ru>
>
>
>

bug#3433: [h-e-w] 23.0.93; dired encoding

[Jason Rumney]

Konstantin wrote:
> On type M-x dired emacs shows \316\362\361\363\362\361\362\342\363\345\362 instead of root.
>   

> My codepage is 1251.


Would Отсутствует be correct? The "root" that 22.3 reported was 
hardcoded, as 22.3 did not try to report file ownership on Windows.

bug#3443: [h-e-w] 23.0.93; dired encoding

[Eli Zaretskii]

> Date: Sun, 31 May 2009 23:09:52 +0800
> From: Jason Rumney <jasonr@gnu.org>
> Cc: emacs-pretest-bug@gnu.org, help-emacs-windows@gnu.org
> 
> Konstantin wrote:
> > On type M-x dired emacs shows \316\362\361\363\362\361\362\342\363\345\362 instead of root.
> >   
> 
> > My codepage is 1251.
> 
> 
> Would Отсутствует be correct?

Unless I'm blind, `file-attributes' does not decode the user and group
names by the locale's encoding, is that true?  It should, IMO.

If I'm right, this problem should show on other platforms as well, not
just on Windows, when the owner's or group's names include non-ASCII
characters.

bug#3432: [h-e-w] 23.0.93; dired encoding

[Jason Rumney]

Eli Zaretskii wrote:

> If I'm right, this problem should show on other platforms as well, not
> just on Windows, when the owner's or group's names include non-ASCII
> characters.
>   

Other platforms don't in general use the internal ls-lisp implementation 
to generate dired buffers, and most systems use utf-8 encoding in the 
locale these days, so even if file-attributes is called somewhere else 
with 'string as its second argument, there is a good chance that Emacs 
23 will display the username correctly without decoding.

Also, while trying to test this, adduser refused to work, advising:

adduser: To avoid problems, the username should consist only of
letters, digits, underscores, periods, at signs and dashes, and not 
start with
a dash (as defined by IEEE Std 1003.1-2001).

So the probability of users on other systems running into this bug are 
fairly low.

bug#3432: [h-e-w] 23.0.93; dired encoding

[Eli Zaretskii]

> Date: Mon, 01 Jun 2009 23:25:25 +0800
> From: Jason Rumney <jasonr@gnu.org>
> CC: Kostafey@yandex.ru, 3432@emacsbugs.donarmstrong.com
> 
> Other platforms don't in general use the internal ls-lisp implementation 
> to generate dired buffers, and most systems use utf-8 encoding in the 
> locale these days, so even if file-attributes is called somewhere else 
> with 'string as its second argument, there is a good chance that Emacs 
> 23 will display the username correctly without decoding.
> 
> Also, while trying to test this, adduser refused to work, advising:
> 
> adduser: To avoid problems, the username should consist only of
> letters, digits, underscores, periods, at signs and dashes, and not 
> start with
> a dash (as defined by IEEE Std 1003.1-2001).
> 
> So the probability of users on other systems running into this bug are 
> fairly low.

OK, but the solution should still be general, in `file-attributes',
and it is to decode the string by locale-coding-system, don't you
agree?

bug#3432: [h-e-w] 23.0.93; dired encoding

[Jason Rumney]

Eli Zaretskii wrote:

> OK, but the solution should still be general, in `file-attributes',
> and it is to decode the string by locale-coding-system, don't you
> agree?
>   

Yes, DECODE_SYSTEM should be used here.

bug#3432: marked as done ([h-e-w] 23.0.93; dired encoding)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]


Your message dated Wed, 08 Jul 2009 20:32:48 +0300
with message-id <83k52jyta7.fsf@gnu.org>
and subject line Re: bug#3443: [h-e-w] 23.0.93; dired encoding
has caused the Emacs bug report #3432,
regarding [h-e-w] 23.0.93; dired encoding
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3432: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3432
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5799 bytes --]

From: Lennart Borgman <lennart.borgman@gmail.com>
To: Konstantin <Kostafey@yandex.ru>
Cc: emacs-pretest-bug@gnu.org, help-emacs-windows@gnu.org
Subject: Re: [h-e-w] 23.0.93; dired encoding
Date: Sun, 31 May 2009 17:00:38 +0200
Message-ID: <e01d8a50905310800i173745ceo462d912cd01b73b7@mail.gmail.com>

Hi again Konstantin, please use the unpatched version for the bug
report. That will send it to Emacs maintainers and not here.


On Sun, May 31, 2009 at 4:51 PM, Konstantin <Kostafey@yandex.ru> wrote:
> Hi, Emacs maintainers!
>
> I'he got the following trouble/bug.
>
> I've tested it on emacs-from-cvs-090503, OS WinXP Home SP2.
>
> On type M-x dired emacs shows \316\362\361\363\362\361\362\342\363\345\362 instead of root.
>
> Here is example:
>
> drwxrwxrwx  1 Administrators SYSTEM                                         0 05-30 13:34 Common Files
> drwxrwxrwx  1 User           \316\362\361\363\362\361\362\342\363\345\362   0 01-19 00:10 Comodo
>
> Emacs 22.3 if free of it:
>
> drwxrwxrwx  1 User           root        0 05-30 13:34 Common Files
> drwxrwxrwx  1 User           root        0 01-19 00:10 Comodo
>
> My codepage is 1251.
>
> I try to add my .emacs somthing like this:
> (setq file-name-coding-system 'utf-8)
> or
> (setq file-name-coding-system 'cp1251)
> but nothing changed.
>
> ---------------------------------------------
>
> In GNU Emacs 23.0.93.1 (i386-mingw-nt5.1.2600)
>  of 2009-05-03 on LENNART-69DE564
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping'
>
> Important settings:
>  value of $LC_ALL: nil
>  value of $LC_COLLATE: nil
>  value of $LC_CTYPE: nil
>  value of $LC_MESSAGES: nil
>  value of $LC_MONETARY: nil
>  value of $LC_NUMERIC: nil
>  value of $LC_TIME: nil
>  value of $LANG: ru
>  value of $XMODIFIERS: nil
>  locale-coding-system: cp1251
>  default-enable-multibyte-characters: t
>
> Major mode: Dired by name
>
> Minor modes in effect:
>  tooltip-mode: t
>  tool-bar-mode: t
>  mouse-wheel-mode: t
>  menu-bar-mode: t
>  file-name-shadow-mode: t
>  global-font-lock-mode: t
>  font-lock-mode: t
>  blink-cursor-mode: t
>  global-auto-composition-mode: t
>  auto-composition-mode: t
>  auto-encryption-mode: t
>  auto-compression-mode: t
>  line-number-mode: t
>  transient-mark-mode: t
>
> Recent input:
> M-x d i r e d <return> <return> <help-echo> M-x r e
> p o r t - e m a c s - b u g <return>
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
>
> --
> Konstantin <Kostafey@yandex.ru>
>
>
>


[-- Attachment #3: Type: message/rfc822, Size: 2048 bytes --]

From: Eli Zaretskii <eliz@gnu.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: Kostafey@yandex.ru, 3432-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3443: [h-e-w] 23.0.93; dired encoding
Date: Wed, 08 Jul 2009 20:32:48 +0300
Message-ID: <83k52jyta7.fsf@gnu.org>

> Date: Mon, 01 Jun 2009 23:37:36 +0800
> From: Jason Rumney <jasonr@gnu.org>
> CC: Kostafey@yandex.ru, 3432@emacsbugs.donarmstrong.com
> 
> Eli Zaretskii wrote:
> 
> > OK, but the solution should still be general, in `file-attributes',
> > and it is to decode the string by locale-coding-system, don't you
> > agree?
> >   
> 
> Yes, DECODE_SYSTEM should be used here.

Done (trunk and branch).

bug#3431: marked as done (23.0.93; dired encoding)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]


Your message dated Wed, 08 Jul 2009 20:32:48 +0300
with message-id <83k52jyta7.fsf@gnu.org>
and subject line Re: bug#3443: [h-e-w] 23.0.93; dired encoding
has caused the Emacs bug report #3432,
regarding 23.0.93; dired encoding
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3432: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3432
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4499 bytes --]

From: Konstantin <Kostafey@yandex.ru>
To: emacs-pretest-bug@gnu.org, help-emacs-windows@gnu.org
Subject: 23.0.93; dired encoding
Date: Sun, 31 May 2009 18:51:08 +0400
Message-ID: <20090531185108.d39b518c.Kostafey@yandex.ru>

Hi, Emacs maintainers!

I'he got the following trouble/bug.

I've tested it on emacs-from-cvs-090503, OS WinXP Home SP2.

On type M-x dired emacs shows \316\362\361\363\362\361\362\342\363\345\362 instead of root.

Here is example:

drwxrwxrwx  1 Administrators SYSTEM                                         0 05-30 13:34 Common Files
drwxrwxrwx  1 User           \316\362\361\363\362\361\362\342\363\345\362   0 01-19 00:10 Comodo

Emacs 22.3 if free of it:

drwxrwxrwx  1 User           root        0 05-30 13:34 Common Files
drwxrwxrwx  1 User           root        0 01-19 00:10 Comodo

My codepage is 1251.

I try to add my .emacs somthing like this:
(setq file-name-coding-system 'utf-8)
or
(setq file-name-coding-system 'cp1251)
but nothing changed.

---------------------------------------------

In GNU Emacs 23.0.93.1 (i386-mingw-nt5.1.2600)
 of 2009-05-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ru
  value of $XMODIFIERS: nil
  locale-coding-system: cp1251
  default-enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x d i r e d <return> <return> <help-echo> M-x r e 
p o r t - e m a c s - b u g <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

-- 
Konstantin <Kostafey@yandex.ru>


[-- Attachment #3: Type: message/rfc822, Size: 2048 bytes --]

From: Eli Zaretskii <eliz@gnu.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: Kostafey@yandex.ru, 3432-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3443: [h-e-w] 23.0.93; dired encoding
Date: Wed, 08 Jul 2009 20:32:48 +0300
Message-ID: <83k52jyta7.fsf@gnu.org>

> Date: Mon, 01 Jun 2009 23:37:36 +0800
> From: Jason Rumney <jasonr@gnu.org>
> CC: Kostafey@yandex.ru, 3432@emacsbugs.donarmstrong.com
> 
> Eli Zaretskii wrote:
> 
> > OK, but the solution should still be general, in `file-attributes',
> > and it is to decode the string by locale-coding-system, don't you
> > agree?
> >   
> 
> Yes, DECODE_SYSTEM should be used here.

Done (trunk and branch).

bug#3433: marked as done ([h-e-w] 23.0.93; dired encoding)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]


Your message dated Wed, 08 Jul 2009 20:32:48 +0300
with message-id <83k52jyta7.fsf@gnu.org>
and subject line Re: bug#3443: [h-e-w] 23.0.93; dired encoding
has caused the Emacs bug report #3432,
regarding [h-e-w] 23.0.93; dired encoding
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3432: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3432
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3786 bytes --]

From: Jason Rumney <jasonr@gnu.org>
To: Konstantin <Kostafey@yandex.ru>
Cc: emacs-pretest-bug@gnu.org, help-emacs-windows@gnu.org
Subject: Re: [h-e-w] 23.0.93; dired encoding
Date: Sun, 31 May 2009 23:09:52 +0800
Message-ID: <4A229DC0.1000102@gnu.org>

Konstantin wrote:
> On type M-x dired emacs shows \316\362\361\363\362\361\362\342\363\345\362 instead of root.
>   

> My codepage is 1251.


Would Отсутствует be correct? The "root" that 22.3 reported was 
hardcoded, as 22.3 did not try to report file ownership on Windows.




[-- Attachment #3: Type: message/rfc822, Size: 2066 bytes --]

From: Eli Zaretskii <eliz@gnu.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: Kostafey@yandex.ru, 3432-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3443: [h-e-w] 23.0.93; dired encoding
Date: Wed, 08 Jul 2009 20:32:48 +0300
Message-ID: <83k52jyta7.fsf@gnu.org>

> Date: Mon, 01 Jun 2009 23:37:36 +0800
> From: Jason Rumney <jasonr@gnu.org>
> CC: Kostafey@yandex.ru, 3432@emacsbugs.donarmstrong.com
> 
> Eli Zaretskii wrote:
> 
> > OK, but the solution should still be general, in `file-attributes',
> > and it is to decode the string by locale-coding-system, don't you
> > agree?
> >   
> 
> Yes, DECODE_SYSTEM should be used here.

Done (trunk and branch).

bug#3443: marked as done ([h-e-w] 23.0.93; dired encoding)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]


Your message dated Wed, 08 Jul 2009 21:15:46 +0300
with message-id <83fxd7yral.fsf@gnu.org>
and subject line Re: bug#3443: [h-e-w] 23.0.93; dired encoding
has caused the Emacs bug report #3443,
regarding [h-e-w] 23.0.93; dired encoding
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3443: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3443
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2162 bytes --]

From: Eli Zaretskii <eliz@gnu.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: Kostafey@yandex.ru, emacs-pretest-bug@gnu.org, help-emacs-windows@gnu.org
Subject: Re: [h-e-w] 23.0.93; dired encoding
Date: Mon, 01 Jun 2009 10:55:19 -0400
Message-ID: <E1MB8v1-0007WR-9u@fencepost.gnu.org>

> Date: Sun, 31 May 2009 23:09:52 +0800
> From: Jason Rumney <jasonr@gnu.org>
> Cc: emacs-pretest-bug@gnu.org, help-emacs-windows@gnu.org
> 
> Konstantin wrote:
> > On type M-x dired emacs shows \316\362\361\363\362\361\362\342\363\345\362 instead of root.
> >   
> 
> > My codepage is 1251.
> 
> 
> Would Отсутствует be correct?

Unless I'm blind, `file-attributes' does not decode the user and group
names by the locale's encoding, is that true?  It should, IMO.

If I'm right, this problem should show on other platforms as well, not
just on Windows, when the owner's or group's names include non-ASCII
characters.


[-- Attachment #3: Type: message/rfc822, Size: 1434 bytes --]

From: Eli Zaretskii <eliz@gnu.org>
To: 3443-done@emacsbugs.donarmstrong.com
Subject: Re: bug#3443: [h-e-w] 23.0.93; dired encoding
Date: Wed, 08 Jul 2009 21:15:46 +0300
Message-ID: <83fxd7yral.fsf@gnu.org>

Fixed (see #3432 for details).