bug#272: indentation error in ada-mode

bug#272: indentation error in ada-mode

[Allan Gottlieb]

ran emacs -Q

Following file is /tmp/tt.adb

procedure test(X : Integer) is
   Y : Integer;
begin
   case X is
      when 1 =>                         --  xxx
         if X > 5 then
         Y := 5;
         end if;
      when 2 =>
         if X > 5 then
            Y := 5;
         end if;
   end case;

The second when clause is indented properly the first is not.
The "cause" is the comment xxx.  If it is removed, indentation
is correct.

Thank you for emacs and for ada-mode; both of which are great.


In GNU Emacs 22.2.1 (i686-pc-linux-gnu, GTK+ Version 2.12.8)
 of 2008-05-15 on ajglap
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--prefix=/usr' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-22' '--infodir=/usr/share/info/emacs-22' '--without-carbon' '--with-sound' '--with-x' '--with-toolkit-scroll-bars' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' '--with-xpm' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--build=i686-pc-linux-gnu' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-O2 -march=prescott -pipe''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Ada

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
<tab> <down> <tab> <down> <tab> <down> <tab> <down> 
<down> <tab> <down> <tab> <down> <tab> <down> <tab> 
<down> <tab> <down> <tab> <backspace> <backspace> <tab> 
<down> <tab> <down> <tab> <down> <tab> <tab> <backspace> 
<backspace> <backspace> C-x C-s M-x e m a c s - b u 
g <return> <backspace> <backspace> <backspace> <backspace> 
SPC SPC <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> b u g <tab> C-g C-g M-x a p 
r <return> b u g <return> <down-mouse-5> <mouse-5> 
<down-mouse-5> <mouse-5> <down-mouse-5> <mouse-5> <double-down-mouse-5> 
<double-mouse-5> <down-mouse-5> <mouse-5> <double-down-mouse-5> 
<double-mouse-5> <down-mouse-5> <mouse-5> <double-down-mouse-5> 
<double-mouse-5> <triple-down-mouse-5> <triple-mouse-5> 
<down-mouse-5> <mouse-5> <double-down-mouse-5> <double-mouse-5> 
<down-mouse-5> <mouse-5> <double-down-mouse-5> <double-mouse-5> 
<down-mouse-4> <mouse-4> <double-down-mouse-4> <double-mouse-4> 
<help-echo> M-x r e p o r t - e m <tab> <return>

Recent messages:
Loading advice...done
Loading ada-mode...done
Loading tabify...done
Wrote /tmp/tt.adb
Making completion list...
Quit [2 times]
Loading apropos...done
Loading emacsbug...
Loading regexp-opt...done
Loading emacsbug...done

bug#272: marked as done (indentation error in ada-mode)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]


Your message dated Mon, 28 Jul 2008 13:07:45 +0200
with message-id <f7ccd24b0807280407w2cf21689u6cfc2394e8a7ee34@mail.gmail.com>
and subject line 
has caused the Emacs bug report #272,
regarding indentation error in ada-mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
272: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=272
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5262 bytes --]

From: Allan Gottlieb <gottlieb@nyu.edu>
To: bug-gnu-emacs@gnu.org
Subject: indentation error in ada-mode
Date: Sat, 17 May 2008 18:20:14 -0400 (EDT)
Message-ID: <20080517222014.2A09719D92E@ajglap.localdomain>

ran emacs -Q

Following file is /tmp/tt.adb

procedure test(X : Integer) is
   Y : Integer;
begin
   case X is
      when 1 =>                         --  xxx
         if X > 5 then
         Y := 5;
         end if;
      when 2 =>
         if X > 5 then
            Y := 5;
         end if;
   end case;

The second when clause is indented properly the first is not.
The "cause" is the comment xxx.  If it is removed, indentation
is correct.

Thank you for emacs and for ada-mode; both of which are great.


In GNU Emacs 22.2.1 (i686-pc-linux-gnu, GTK+ Version 2.12.8)
 of 2008-05-15 on ajglap
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--prefix=/usr' '--host=i686-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--program-suffix=-emacs-22' '--infodir=/usr/share/info/emacs-22' '--without-carbon' '--with-sound' '--with-x' '--with-toolkit-scroll-bars' '--with-jpeg' '--with-tiff' '--with-gif' '--with-png' '--with-xpm' '--with-x-toolkit=gtk' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--build=i686-pc-linux-gnu' 'build_alias=i686-pc-linux-gnu' 'host_alias=i686-pc-linux-gnu' 'CFLAGS=-O2 -march=prescott -pipe''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Ada

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
<tab> <down> <tab> <down> <tab> <down> <tab> <down> 
<down> <tab> <down> <tab> <down> <tab> <down> <tab> 
<down> <tab> <down> <tab> <backspace> <backspace> <tab> 
<down> <tab> <down> <tab> <down> <tab> <tab> <backspace> 
<backspace> <backspace> C-x C-s M-x e m a c s - b u 
g <return> <backspace> <backspace> <backspace> <backspace> 
SPC SPC <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> b u g <tab> C-g C-g M-x a p 
r <return> b u g <return> <down-mouse-5> <mouse-5> 
<down-mouse-5> <mouse-5> <down-mouse-5> <mouse-5> <double-down-mouse-5> 
<double-mouse-5> <down-mouse-5> <mouse-5> <double-down-mouse-5> 
<double-mouse-5> <down-mouse-5> <mouse-5> <double-down-mouse-5> 
<double-mouse-5> <triple-down-mouse-5> <triple-mouse-5> 
<down-mouse-5> <mouse-5> <double-down-mouse-5> <double-mouse-5> 
<down-mouse-5> <mouse-5> <double-down-mouse-5> <double-mouse-5> 
<down-mouse-4> <mouse-4> <double-down-mouse-4> <double-mouse-4> 
<help-echo> M-x r e p o r t - e m <tab> <return>

Recent messages:
Loading advice...done
Loading ada-mode...done
Loading tabify...done
Wrote /tmp/tt.adb
Making completion list...
Quit [2 times]
Loading apropos...done
Loading emacsbug...
Loading regexp-opt...done
Loading emacsbug...done




[-- Attachment #3: Type: message/rfc822, Size: 2417 bytes --]

From: "Juanma Barranquero" <lekktu@gmail.com>
To: 272-done@emacsbugs.donarmstrong.com
Subject: 
Date: Mon, 28 Jul 2008 13:07:45 +0200
Message-ID: <f7ccd24b0807280407w2cf21689u6cfc2394e8a7ee34@mail.gmail.com>

Fixed by this change:

2008-07-28  Stephen Leake  <stephen_leake@stephe-leake.org>

        * progmodes/ada-mode.el (ada-mode): Clean up XEmacs handling.
        Add support for add-log.
        (ada-end-stmt-re): Fix bug - allow comment after 'when'.