bug#2453: elint args for encode-time

bug#2453: elint args for encode-time

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]

In a buffer containing

    (encode-time 0 0 0 1 1 2009)

the commands

    M-x elint-initialize
    M-x elint-current-buffer

leave in the *Elint* buffer an error

    Wrong number of args: (encode-time 0 0 0 1 1 2009), (second minute hour day month year zone &rest args)

where I believe 6 args to encode-time is right, and should pass the
checks.

I suspect it's elint-unknown-builtin-args making the "zone" arg
mandatory, per below.


Incidentally, can some of the overrides in that list be handled in the
code nowadays?  Running

    (elint-find-builtin-args '(encode-time))

gives back `fn' instead of the function name, matched out of the
docstring (documentation 'encode-time).  Maybe that could be
transformed, or maybe some of the help funcs can do that already.




In GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-10 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs22:/etc/emacs:/usr/local/share/emacs/22.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  iswitchb-mode: t
  show-paren-mode: t
  encoded-kbd-mode: t
  file-name-shadow-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t


2009-02-24  Kevin Ryde  <user42@zip.com.au>

	* emacs-lisp/elint.el (elint-unknown-builtin-args): Correction to args
	for encode-time.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: elint.el.unknown-builtin.diff --]
[-- Type: text/x-diff, Size: 623 bytes --]

*** elint.el	07 Jan 2009 11:29:25 +1100	1.23
--- elint.el	24 Feb 2009 08:46:25 +1100	
***************
*** 107,113 ****
      (if cond then &rest else)
      (apply function &rest args)
      (format string &rest args)
!     (encode-time second minute hour day month year zone &rest args)
      (min &rest args)
      (logand &rest args)
      (logxor &rest args)
--- 107,113 ----
      (if cond then &rest else)
      (apply function &rest args)
      (format string &rest args)
!     (encode-time second minute hour day month year &optional zone)
      (min &rest args)
      (logand &rest args)
      (logxor &rest args)

bug#2453: marked as done (elint args for encode-time)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]


Your message dated Mon, 23 Feb 2009 22:30:40 -0500
with message-id <e5bpss1pgf.fsf@fencepost.gnu.org>
and subject line Re: bug#2453: elint args for encode-time
has caused the Emacs bug report #2453,
regarding elint args for encode-time
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2453: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2453
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5342 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 2239 bytes --]

In a buffer containing

    (encode-time 0 0 0 1 1 2009)

the commands

    M-x elint-initialize
    M-x elint-current-buffer

leave in the *Elint* buffer an error

    Wrong number of args: (encode-time 0 0 0 1 1 2009), (second minute hour day month year zone &rest args)

where I believe 6 args to encode-time is right, and should pass the
checks.

I suspect it's elint-unknown-builtin-args making the "zone" arg
mandatory, per below.


Incidentally, can some of the overrides in that list be handled in the
code nowadays?  Running

    (elint-find-builtin-args '(encode-time))

gives back `fn' instead of the function name, matched out of the
docstring (documentation 'encode-time).  Maybe that could be
transformed, or maybe some of the help funcs can do that already.




In GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-10 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs22:/etc/emacs:/usr/local/share/emacs/22.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  iswitchb-mode: t
  show-paren-mode: t
  encoded-kbd-mode: t
  file-name-shadow-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t


2009-02-24  Kevin Ryde  <user42@zip.com.au>

	* emacs-lisp/elint.el (elint-unknown-builtin-args): Correction to args
	for encode-time.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: elint.el.unknown-builtin.diff --]
[-- Type: text/x-diff, Size: 623 bytes --]

*** elint.el	07 Jan 2009 11:29:25 +1100	1.23
--- elint.el	24 Feb 2009 08:46:25 +1100	
***************
*** 107,113 ****
      (if cond then &rest else)
      (apply function &rest args)
      (format string &rest args)
!     (encode-time second minute hour day month year zone &rest args)
      (min &rest args)
      (logand &rest args)
      (logxor &rest args)
--- 107,113 ----
      (if cond then &rest else)
      (apply function &rest args)
      (format string &rest args)
!     (encode-time second minute hour day month year &optional zone)
      (min &rest args)
      (logand &rest args)
      (logxor &rest args)

[-- Attachment #3: Type: message/rfc822, Size: 1611 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 2453-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2453: elint args for encode-time
Date: Mon, 23 Feb 2009 22:30:40 -0500
Message-ID: <e5bpss1pgf.fsf@fencepost.gnu.org>

Kevin Ryde wrote:

> I suspect it's elint-unknown-builtin-args making the "zone" arg
> mandatory, per below.

Fixed.

>     (elint-find-builtin-args '(encode-time))
>
> gives back `fn' instead of the function name

Fixed.

bug#2453: closed by Glenn Morris <rgm@gnu.org> (Re: bug#2453: elint args for encode-time)

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Glenn Morris <rgm@gnu.org> writes:
>
>>     (elint-find-builtin-args '(encode-time))
>>
>> gives back `fn' instead of the function name
>
> Fixed.

With that change the entry in elint-unknown-builtin-args for encode-time
is not needed at all ...


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: elint.el.encode-time-2.diff --]
[-- Type: text/x-diff, Size: 379 bytes --]

*** elint.el	25 Feb 2009 07:37:52 +1100	1.24
--- elint.el	25 Feb 2009 07:57:41 +1100	
***************
*** 107,113 ****
      (if cond then &rest else)
      (apply function &rest args)
      (format string &rest args)
-     (encode-time second minute hour day month year &optional zone)
      (min &rest args)
      (logand &rest args)
      (logxor &rest args)
--- 107,112 ----

bug#2453: closed by Glenn Morris <rgm@gnu.org> (Re: bug#2453: elint args for encode-time)

[Stefan Monnier]

> With that change the entry in elint-unknown-builtin-args for encode-time
> is not needed at all ...

IIUC elint-unknown-builtin-args shouldn't be needed at all.


        Stefan

bug#2453: closed by Glenn Morris <rgm@gnu.org> (Re: bug#2453: elint args for encode-time)

[Glenn Morris]

Stefan Monnier wrote:

> IIUC elint-unknown-builtin-args shouldn't be needed at all.

Probably; I think post-23.1 elint.el can be tidied up.

bug#2453: closed by Glenn Morris <rgm@gnu.org> (Re: bug#2453: elint args for encode-time)

[Kevin Ryde]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
> IIUC elint-unknown-builtin-args shouldn't be needed at all.

Looks like elint-find-builtin-args doesn't currently recognise the "..."
part of say (documentation 'while) or (documentation 'and) ... those two
being in the elint-unknown-builtin-args list as yet.  No doubt it could
be made to do so.  Unless `subr-arity' gives a better answer for
checking, with a text form just for an error message.