bug#2266: Superfluous linking against fontconfig

bug#2266: Superfluous linking against fontconfig

[Yavor Doganov]

Tags: patch

This change

2008-10-30  Emanuele Giaquinta  <emanuele.giaquinta@gmail.com>

	* configure.in: Check fontconfig always.

causes unnecessary linking with libfontconfig when configured
--without-x or --with-ns:

$ ldd -u -r src/emacs
Unused direct dependencies:
	
	/usr/lib/libfontconfig.so.1

For Emacs.app, it can't be even removed with -Wl,--as-needed since
user-defined LDFLAGS do not propagate to the link rule (yet).  A
straightforward solution seems to be the following:

2009-02-10  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* configure.in: Check for fontconfig only if HAVE_X11=yes.

--- configure.in	10 фев 2009 09:37:08 +0200	1.585
+++ configure.in	10 фев 2009 11:16:38 +0200	
@@ -1825,7 +1825,9 @@
 fi
 
 ### Start of font-backend section.
-PKG_CHECK_MODULES(FONTCONFIG, fontconfig >= 2.2.0, HAVE_FC=yes, HAVE_FC=no)
+if test "${HAVE_X11}" = yes; then
+  PKG_CHECK_MODULES(FONTCONFIG, fontconfig >= 2.2.0, HAVE_FC=yes, HAVE_FC=no)
+fi
 test "${HAVE_FC}" = "no" && with_freetype=no
 
 ## Use -lXft if available, unless `--with-freetype=no' nor `--with-xft=no'.

bug#2266: marked as done (Superfluous linking against fontconfig)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]


Your message dated Fri, 27 Feb 2009 16:54:06 -0500
with message-id <odd4d3sg01.fsf@fencepost.gnu.org>
and subject line Re: bug#2266: Superfluous linking against fontconfig
has caused the Emacs bug report #2266,
regarding Superfluous linking against fontconfig
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2266: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2266
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3951 bytes --]

From: Yavor Doganov <yavor@gnu.org>
To: bug-gnu-emacs@gnu.org
Subject: Superfluous linking against fontconfig
Date: Tue, 10 Feb 2009 11:24:18 +0200
Message-ID: <87iqni7igt.GNU's_Not_Unix!%yavor@gnu.org>

Tags: patch

This change

2008-10-30  Emanuele Giaquinta  <emanuele.giaquinta@gmail.com>

	* configure.in: Check fontconfig always.

causes unnecessary linking with libfontconfig when configured
--without-x or --with-ns:

$ ldd -u -r src/emacs
Unused direct dependencies:
	
	/usr/lib/libfontconfig.so.1

For Emacs.app, it can't be even removed with -Wl,--as-needed since
user-defined LDFLAGS do not propagate to the link rule (yet).  A
straightforward solution seems to be the following:

2009-02-10  Yavor Doganov  <yavor@gnu.org>  (tiny change)

	* configure.in: Check for fontconfig only if HAVE_X11=yes.

--- configure.in	10 фев 2009 09:37:08 +0200	1.585
+++ configure.in	10 фев 2009 11:16:38 +0200	
@@ -1825,7 +1825,9 @@
 fi
 
 ### Start of font-backend section.
-PKG_CHECK_MODULES(FONTCONFIG, fontconfig >= 2.2.0, HAVE_FC=yes, HAVE_FC=no)
+if test "${HAVE_X11}" = yes; then
+  PKG_CHECK_MODULES(FONTCONFIG, fontconfig >= 2.2.0, HAVE_FC=yes, HAVE_FC=no)
+fi
 test "${HAVE_FC}" = "no" && with_freetype=no
 
 ## Use -lXft if available, unless `--with-freetype=no' nor `--with-xft=no'.






[-- Attachment #3: Type: message/rfc822, Size: 1951 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 2266-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2266: Superfluous linking against fontconfig
Date: Fri, 27 Feb 2009 16:54:06 -0500
Message-ID: <odd4d3sg01.fsf@fencepost.gnu.org>

Yavor Doganov wrote:

> 2008-10-30  Emanuele Giaquinta  <emanuele.giaquinta@gmail.com>
>
> 	* configure.in: Check fontconfig always.
>
> causes unnecessary linking with libfontconfig when configured
> --without-x or --with-ns:


2009-02-23  Adrian Robert  <Adrian.B.Robert@gmail.com>

     * configure.in (HAVE_XFT, HAVE_FREETYPE, HAVE_LIBOTF)
     (HAVE_M17N_FLT): Don't check for these unless HAVE_X11.