bug#1949: comment-dwim freezes emacs while in css-mode

bug#1949: comment-dwim freezes emacs while in css-mode

[xah lee]

To reproduce,

• start emacs with /Applications/Emacs.app/Contents/MacOS/Emacs -q

• create this file (contet between the dashes):

------------------------
@import "../../lang.css";

div.cmt {display:table; padding:1ex; background-color:#ffdab9}
span.cmt {background-color:#ffdab9}
----------------------

• name it “ff.css”. Now, open the file, M-x css-mode.

• Place your cursor in the blank line there, then M-x comment-dwim.

• Emacs seems to freeze. Type Ctrl+g to unfreeze.

This bug is reproducible when starting emacs with

   Xah
∑ http://xahlee.org/

☄

In GNU Emacs 22.2.1 (powerpc-apple-darwin8.11.0, Carbon Version 1.6.0)
  of 2008-04-05 on g5.tokyo.stp.isas.jaxa.jp
Windowing system distributor `Apple Inc.', version 10.4.11
configured using `configure  '--prefix=/Applications/Emacs.app/ 
Contents/Resources' '--with-carbon' '--without-x' '--libexecdir=/ 
Volumes/Emacs/Emacs.app/Contents/MacOS/libexec' 'CFLAGS=-Os -arch  
i386 -arch ppc -isysroot /Developer/SDKs/MacOSX10.4u.sdk -DUSE_ATSUI - 
DUSE_MAC_TSM''


Major mode: CSS

Minor modes in effect:
   encoded-kbd-mode: t
   command-frequency-autosave-mode: t
   command-frequency-mode: t
   yas/minor-mode: t
   desktop-save-mode: t
   recentf-mode: t
   show-paren-mode: t
   delete-selection-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   unify-8859-on-encoding-mode: t
   utf-translate-cjk-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t
   abbrev-mode: t

bug#1949: marked as done (comment-dwim freezes emacs while in css-mode)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]


Your message dated Mon, 19 Jan 2009 09:20:15 +0100
with message-id <f7ccd24b0901190020t3cb9b233h9bd2b4aa38d47f6c@mail.gmail.com>
and subject line Re: bug#1949: comment-dwim freezes emacs while in css-mode
has caused the Emacs bug report #1949,
regarding comment-dwim freezes emacs while in css-mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1949: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1949
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3861 bytes --]

From: xah lee <xah@xahlee.org>
To: bug-gnu-emacs@gnu.org
Subject: comment-dwim freezes emacs while in css-mode
Date: Sun, 18 Jan 2009 12:42:17 -0800
Message-ID: <AFDE0316-9E43-45B9-B2CE-90E4BF77B18B@xahlee.org>

To reproduce,

• start emacs with /Applications/Emacs.app/Contents/MacOS/Emacs -q

• create this file (contet between the dashes):

------------------------
@import "../../lang.css";

div.cmt {display:table; padding:1ex; background-color:#ffdab9}
span.cmt {background-color:#ffdab9}
----------------------

• name it “ff.css”. Now, open the file, M-x css-mode.

• Place your cursor in the blank line there, then M-x comment-dwim.

• Emacs seems to freeze. Type Ctrl+g to unfreeze.

This bug is reproducible when starting emacs with

   Xah
∑ http://xahlee.org/

☄

In GNU Emacs 22.2.1 (powerpc-apple-darwin8.11.0, Carbon Version 1.6.0)
  of 2008-04-05 on g5.tokyo.stp.isas.jaxa.jp
Windowing system distributor `Apple Inc.', version 10.4.11
configured using `configure  '--prefix=/Applications/Emacs.app/ 
Contents/Resources' '--with-carbon' '--without-x' '--libexecdir=/ 
Volumes/Emacs/Emacs.app/Contents/MacOS/libexec' 'CFLAGS=-Os -arch  
i386 -arch ppc -isysroot /Developer/SDKs/MacOSX10.4u.sdk -DUSE_ATSUI - 
DUSE_MAC_TSM''


Major mode: CSS

Minor modes in effect:
   encoded-kbd-mode: t
   command-frequency-autosave-mode: t
   command-frequency-mode: t
   yas/minor-mode: t
   desktop-save-mode: t
   recentf-mode: t
   show-paren-mode: t
   delete-selection-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   unify-8859-on-encoding-mode: t
   utf-translate-cjk-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t
   abbrev-mode: t





[-- Attachment #3: Type: message/rfc822, Size: 3196 bytes --]

From: Juanma Barranquero <lekktu@gmail.com>
To: xah lee <xah@xahlee.org>
Cc: 1949-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1949: comment-dwim freezes emacs while in css-mode
Date: Mon, 19 Jan 2009 09:20:15 +0100
Message-ID: <f7ccd24b0901190020t3cb9b233h9bd2b4aa38d47f6c@mail.gmail.com>

On Sun, Jan 18, 2009 at 21:42, xah lee <xah@xahlee.org> wrote:

> • name it "ff.css". Now, open the file, M-x css-mode.
>
> • Place your cursor in the blank line there, then M-x comment-dwim.
>
> • Emacs seems to freeze. Type Ctrl+g to unfreeze.

Fixed in the sources.

Try the attached patch, against your 22.2.

  Juanma


--- lisp\textmodes\css-mode.el.orig	2008-03-01 20:28:16.000000000 +0100
+++ lisp\textmodes\css-mode.el	2009-01-19 09:14:55.138125000 +0100
@@ -369,5 +369,5 @@
                           (forward-comment (- (point-max)))
                           ;; FIXME: We should also skip punctuation.
-                          (not (memq (char-before) '(?\; ?\{)))))))))))
+                          (not (or (bobp) (memq (char-before) '(?\;
?\{))))))))))))

 (defun css-forward-sexp (n)