* bug#1638: got "invalid-function imenu-progress-message" in objc-mode
@ 2008-12-19 6:30 ` Meteor Liu
2009-02-18 9:30 ` bug#1638: marked as done (got "invalid-function imenu-progress-message" in objc-mode) Emacs bug Tracking System
0 siblings, 1 reply; 5+ messages in thread
From: Meteor Liu @ 2008-12-19 6:30 UTC (permalink / raw)
To: bug-cc-mode; +Cc: bug-gnu-emacs
[-- Attachment #1: Type: text/html, Size: 469 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2357: imenu-add-menubar-index fails in Objective-C mode
@ 2009-02-17 12:22 ` Juanma Barranquero
2009-02-18 2:57 ` Stefan Monnier
2009-02-18 9:30 ` bug#2357: marked as done (imenu-add-menubar-index fails in Objective-C mode) Emacs bug Tracking System
0 siblings, 2 replies; 5+ messages in thread
From: Juanma Barranquero @ 2009-02-17 12:22 UTC (permalink / raw)
To: Emacs Bug Tracker
Package: emacs,cc-mode
[This part is a bugfix]
emacs -Q --visit nsfns.m --f imenu-add-menubar-index
=> Error in menu-bar-update-hook: (invalid-function imenu-progress-message)
The reason is that progmodes/cc-menus.el does
(cc-bytecomp-defun imenu-progress-message)
to avoid loading imenu.el, and then uses `imenu-progress-message' in
Objective-C specific code (cc-imenu-objc-function). But it is a macro,
so it fails.
I think the best way to fix it is just removing the cc-bytecomp-defun
and all calls to imenu-progress-message from cc-menus.el. That macro
has been defined as a no-op since 2004-10-27 and I don't think it is
worth jumping around hoops just to make cc-menus.el successfully
define something that goes unused.
[This part is not a bugfix, so not needed now]
Additionally, there are useless calls to `imenu-progress-message' in
imenu.el, erc/erc-imenu.el and net/smtp-mode.el. For the latter two,
removing the macro calls would also remove the need to require imenu.
Juanma
2009-02-17 Juanma Barranquero <lekktu@gmail.com>
* progmodes/cc-menus.el (imenu-progress-message):
Remove (bogus and useless) cc-bytecomp-defun.
(cc-imenu-objc-function): Don't call `imenu-progress-message'.
Don't let-bind unused variable `stupid'.
Index: lisp/progmodes/cc-menus.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/cc-menus.el,v
retrieving revision 1.42
diff -u -2 -r1.42 cc-menus.el
--- lisp/progmodes/cc-menus.el 17 Feb 2009 10:59:14 -0000 1.42
+++ lisp/progmodes/cc-menus.el 17 Feb 2009 11:51:30 -0000
@@ -48,5 +48,4 @@
(cc-bytecomp-defvar imenu-generic-expression)
(cc-bytecomp-defvar imenu-create-index-function)
-(cc-bytecomp-defun imenu-progress-message)
\f
@@ -317,5 +316,4 @@
(classcount 0)
toplist
- stupid
str
str2
@@ -331,8 +329,6 @@
'buffer-substring)))
(goto-char (point-max))
- (imenu-progress-message stupid 0)
;;
(while (re-search-backward cc-imenu-objc-generic-expression nil t)
- (imenu-progress-message stupid)
(setq langnum (if (match-beginning OBJC)
OBJC
@@ -386,5 +382,4 @@
methodlist nil))))
;;
- (imenu-progress-message stupid 100)
(if (eq (car toplist) nil)
(setq toplist (cdr toplist)))
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2357: imenu-add-menubar-index fails in Objective-C mode
2009-02-17 12:22 ` bug#2357: imenu-add-menubar-index fails in Objective-C mode Juanma Barranquero
@ 2009-02-18 2:57 ` Stefan Monnier
2009-02-18 9:30 ` bug#2357: marked as done (imenu-add-menubar-index fails in Objective-C mode) Emacs bug Tracking System
1 sibling, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2009-02-18 2:57 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs Bug Tracker, 2357
> -(cc-bytecomp-defun imenu-progress-message)
Removing uses of cc-bytecomp-* is always a reason for rejoycing.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#1638: marked as done (got "invalid-function imenu-progress-message" in objc-mode)
2008-12-19 6:30 ` bug#1638: got "invalid-function imenu-progress-message" in objc-mode Meteor Liu
@ 2009-02-18 9:30 ` Emacs bug Tracking System
0 siblings, 0 replies; 5+ messages in thread
From: Emacs bug Tracking System @ 2009-02-18 9:30 UTC (permalink / raw)
To: Juanma Barranquero
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Your message dated Wed, 18 Feb 2009 10:24:08 +0100
with message-id <f7ccd24b0902180124n7f94606ax4248bd23046d984c@mail.gmail.com>
and subject line Re: bug#2357: imenu-add-menubar-index fails in Objective-C mode
has caused the Emacs bug report #1638,
regarding got "invalid-function imenu-progress-message" in objc-mode
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
1638: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1638
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 3720 bytes --]
[-- Attachment #2.1.1: Type: text/html, Size: 469 bytes --]
[-- Attachment #3: Type: message/rfc822, Size: 2597 bytes --]
From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 1638-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2357: imenu-add-menubar-index fails in Objective-C mode
Date: Wed, 18 Feb 2009 10:24:08 +0100
Message-ID: <f7ccd24b0902180124n7f94606ax4248bd23046d984c@mail.gmail.com>
On Wed, Feb 18, 2009 at 03:57, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Removing uses of cc-bytecomp-* is always a reason for rejoycing.
Ok, installed.
Juanma
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2357: marked as done (imenu-add-menubar-index fails in Objective-C mode)
2009-02-17 12:22 ` bug#2357: imenu-add-menubar-index fails in Objective-C mode Juanma Barranquero
2009-02-18 2:57 ` Stefan Monnier
@ 2009-02-18 9:30 ` Emacs bug Tracking System
1 sibling, 0 replies; 5+ messages in thread
From: Emacs bug Tracking System @ 2009-02-18 9:30 UTC (permalink / raw)
To: Juanma Barranquero
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
Your message dated Wed, 18 Feb 2009 10:24:08 +0100
with message-id <f7ccd24b0902180124n7f94606ax4248bd23046d984c@mail.gmail.com>
and subject line Re: bug#2357: imenu-add-menubar-index fails in Objective-C mode
has caused the Emacs bug report #1638,
regarding imenu-add-menubar-index fails in Objective-C mode
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
1638: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1638
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 4611 bytes --]
From: Juanma Barranquero <lekktu@gmail.com>
To: Emacs Bug Tracker <submit@emacsbugs.donarmstrong.com>
Subject: imenu-add-menubar-index fails in Objective-C mode
Date: Tue, 17 Feb 2009 13:22:21 +0100
Message-ID: <f7ccd24b0902170422s486b8726m753c738c4cb59967@mail.gmail.com>
Package: emacs,cc-mode
[This part is a bugfix]
emacs -Q --visit nsfns.m --f imenu-add-menubar-index
=> Error in menu-bar-update-hook: (invalid-function imenu-progress-message)
The reason is that progmodes/cc-menus.el does
(cc-bytecomp-defun imenu-progress-message)
to avoid loading imenu.el, and then uses `imenu-progress-message' in
Objective-C specific code (cc-imenu-objc-function). But it is a macro,
so it fails.
I think the best way to fix it is just removing the cc-bytecomp-defun
and all calls to imenu-progress-message from cc-menus.el. That macro
has been defined as a no-op since 2004-10-27 and I don't think it is
worth jumping around hoops just to make cc-menus.el successfully
define something that goes unused.
[This part is not a bugfix, so not needed now]
Additionally, there are useless calls to `imenu-progress-message' in
imenu.el, erc/erc-imenu.el and net/smtp-mode.el. For the latter two,
removing the macro calls would also remove the need to require imenu.
Juanma
2009-02-17 Juanma Barranquero <lekktu@gmail.com>
* progmodes/cc-menus.el (imenu-progress-message):
Remove (bogus and useless) cc-bytecomp-defun.
(cc-imenu-objc-function): Don't call `imenu-progress-message'.
Don't let-bind unused variable `stupid'.
Index: lisp/progmodes/cc-menus.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/cc-menus.el,v
retrieving revision 1.42
diff -u -2 -r1.42 cc-menus.el
--- lisp/progmodes/cc-menus.el 17 Feb 2009 10:59:14 -0000 1.42
+++ lisp/progmodes/cc-menus.el 17 Feb 2009 11:51:30 -0000
@@ -48,5 +48,4 @@
(cc-bytecomp-defvar imenu-generic-expression)
(cc-bytecomp-defvar imenu-create-index-function)
-(cc-bytecomp-defun imenu-progress-message)
\f
@@ -317,5 +316,4 @@
(classcount 0)
toplist
- stupid
str
str2
@@ -331,8 +329,6 @@
'buffer-substring)))
(goto-char (point-max))
- (imenu-progress-message stupid 0)
;;
(while (re-search-backward cc-imenu-objc-generic-expression nil t)
- (imenu-progress-message stupid)
(setq langnum (if (match-beginning OBJC)
OBJC
@@ -386,5 +382,4 @@
methodlist nil))))
;;
- (imenu-progress-message stupid 100)
(if (eq (car toplist) nil)
(setq toplist (cdr toplist)))
[-- Attachment #3: Type: message/rfc822, Size: 2597 bytes --]
From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 1638-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2357: imenu-add-menubar-index fails in Objective-C mode
Date: Wed, 18 Feb 2009 10:24:08 +0100
Message-ID: <f7ccd24b0902180124n7f94606ax4248bd23046d984c@mail.gmail.com>
On Wed, Feb 18, 2009 at 03:57, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Removing uses of cc-bytecomp-* is always a reason for rejoycing.
Ok, installed.
Juanma
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-02-18 9:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <f7ccd24b0902180124n7f94606ax4248bd23046d984c@mail.gmail.com>
2008-12-19 6:30 ` bug#1638: got "invalid-function imenu-progress-message" in objc-mode Meteor Liu
2009-02-18 9:30 ` bug#1638: marked as done (got "invalid-function imenu-progress-message" in objc-mode) Emacs bug Tracking System
2009-02-17 12:22 ` bug#2357: imenu-add-menubar-index fails in Objective-C mode Juanma Barranquero
2009-02-18 2:57 ` Stefan Monnier
2009-02-18 9:30 ` bug#2357: marked as done (imenu-add-menubar-index fails in Objective-C mode) Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).