bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Drew Adams]

Create two files /dir/buf001.txt and /dir/buf002.txt.
 
emacs -Q
(setq enable-recursive-minibuffers t)
(find-file "/dir/buf001.txt")
(find-file-other-frame "/dir/buf002.txt")
(switch-to-buffer-other-frame "buf001.txt")
 
M-x M-: (buffer-list)
 
This returns: 
(#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> 
 #<buffer buf002.txt> #<buffer buf001.txt>...)
 
In previous Emacs releases (e.g. 22.3) it returns this:
(#<buffer  *Minibuf-1*> #<buffer buf001.txt> 
 #<buffer buf002.txt> ... #<buffer  *Minibuf-0*>...)
 
The problems are that in Emacs 23 the last sentence in this section of
the Elisp manual is not respected:
 
  Function: buffer-list &optional frame
     This function returns the buffer list, including all buffers, even
     those whose names begin with a space.  The elements are actual
     buffers, not their names.
 
     If FRAME is a frame, this returns FRAME's buffer list.  If FRAME
     is `nil', the fundamental Emacs buffer list is used: all the
     buffers appear in order of most recent selection, regardless of
     which frames they were selected in.
 
That is, the buffers are not in order of most recent selection. The
minibuffer of the current frame should be first, followed by the
buffer that was selected before entering the minibuffer. Instead,
buffers on another frame come before these buffers.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t
 
Major mode: Fundamental
 
Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
 
Recent input:
C-x C-f t e s t c <tab> <return> <down-mouse-1> <mouse-1> 
<down-mouse-3> <mouse-3> M-x e v a l - r e g <return> 
<switch-frame> <switch-frame> M-x M-: ( b u f f e r 
- l i s t ) <return> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <menu-bar> 
<help-menu> <send-emacs-bug-report>
 
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
(#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> #<buffer buf002.txt> #<buffer
buf001.txt> #<buffer testcase.el> #<buffer drews-lisp-20> #<buffer *scratch*>
#<buffer  *Minibuf-0*> #<buffer *Messages*> #<buffer  *code-conversion-work*>
#<buffer  *Echo Area 0*> #<buffer  *Echo Area 1*>)

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Juanma Barranquero]

On Wed, Oct 8, 2008 at 21:00, Drew Adams <drew.adams@oracle.com> wrote:

> emacs -Q
> (setq enable-recursive-minibuffers t)
> (find-file "/dir/buf001.txt")
> (find-file-other-frame "/dir/buf002.txt")
> (switch-to-buffer-other-frame "buf001.txt")
>
> M-x M-: (buffer-list)

How are you running these commands?

I've done:

 emacs -Q
 M-: (setq enable-recursive-minibuffers t) <ENTER>
 C-x f /dir/buf001.txt <ENTER>
 C-x 5 f /dir/buf002.txt <ENTER>
 C-x 5 b buf001.txt <ENTER>
 M-: (buffer-list) <ENTER>

> This returns:
> (#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*>
>  #<buffer buf002.txt> #<buffer buf001.txt>...)
>
> In previous Emacs releases (e.g. 22.3) it returns this:
> (#<buffer  *Minibuf-1*> #<buffer buf001.txt>
>  #<buffer buf002.txt> ... #<buffer  *Minibuf-0*>...)

I get

(#<buffer buf001.txt> #<buffer  *Minibuf-1*> #<buffer buf002.txt>
#<buffer *scratch*> #<buffer  *Minibuf-0*> ...)

M-x emacs-version

"GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-10-08 on JUANMAB"

  Juanma

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Drew Adams]

> > emacs -Q
> > (setq enable-recursive-minibuffers t)
> > (find-file "/dir/buf001.txt")
> > (find-file-other-frame "/dir/buf002.txt")
> > (switch-to-buffer-other-frame "buf001.txt")
> >
> > M-x M-: (buffer-list)
> 
> How are you running these commands?

Put them (after emacs -Q) in a buffer, visit the buffer, `eval-buffer'. But the
way you used will work also. The key, however, is the last line above: evaluate
(buffer-list) from the minibuffer - e.g. during M-x or C-x C-f. Use `M-x M-:',
not just `M-:'. (That was the point of setting `enable-recursive-minibuffers' to
t.)

The real use would be from a command bound to a key in a minibuffer keymap. If
it examines the `buffer-list' the result is very different in Emacs 23 from
Emacs 20, 21, and 22.

> I've done:
>  emacs -Q
>  M-: (setq enable-recursive-minibuffers t) <ENTER>
>  C-x f /dir/buf001.txt <ENTER>
>  C-x 5 f /dir/buf002.txt <ENTER>
>  C-x 5 b buf001.txt <ENTER>
>  M-: (buffer-list) <ENTER>
> 
> > This returns:
> > (#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*>
> >  #<buffer buf002.txt> #<buffer buf001.txt>...)
> >
> > In previous Emacs releases (e.g. 22.3) it returns this:
> > (#<buffer  *Minibuf-1*> #<buffer buf001.txt>
> >  #<buffer buf002.txt> ... #<buffer  *Minibuf-0*>...)
> 
> I get
> 
> (#<buffer buf001.txt> #<buffer  *Minibuf-1*> #<buffer buf002.txt>
> #<buffer *scratch*> #<buffer  *Minibuf-0*> ...)
> 
> M-x emacs-version
> 
> "GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-10-08 on JUANMAB"

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Juanma Barranquero]

On Thu, Oct 9, 2008 at 18:10, Drew Adams <drew.adams@oracle.com> wrote:

> Use `M-x M-:',
> not just `M-:'. (That was the point of setting `enable-recursive-minibuffers' to
> t.)

Aha. Sorry I missed that.

Yes, I get the same result as you do:

(#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> #<buffer buf002.txt>
#<buffer buf001.txt> #<buffer *scratch*> #<buffer  *Minibuf-0*> ...)

             Juanma

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

 > Yes, I get the same result as you do:
 >
 > (#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> #<buffer buf002.txt>
 > #<buffer buf001.txt> #<buffer *scratch*> #<buffer  *Minibuf-0*> ...)

I checked in a fix.  Could you please try whether it changes anything?

Drew.  Could you try the attached patch?

martin

[-- Attachment #2: 1121.diff --]
[-- Type: text/plain, Size: 1096 bytes --]

*** window.el.~1.155.~	2008-10-09 09:02:00.531250000 +0200
--- window.el	2008-10-10 16:56:50.343750000 +0200
***************
*** 1063,1072 ****
  	(old-frame (selected-frame))
  	new-window new-frame)
      (set-buffer buffer)
!     (setq new-window (display-buffer buffer other-window) norecord)
      (unless (eq new-window old-window)
        ;; `display-buffer' has chosen another window, select it.
!       (select-window new-window)
        (setq new-frame (window-frame new-window))
        (unless (eq new-frame old-frame)
  	;; `display-buffer' has chosen another frame, make sure it gets
--- 1063,1072 ----
  	(old-frame (selected-frame))
  	new-window new-frame)
      (set-buffer buffer)
!     (setq new-window (display-buffer buffer other-window))
      (unless (eq new-window old-window)
        ;; `display-buffer' has chosen another window, select it.
!       (select-window new-window norecord)
        (setq new-frame (window-frame new-window))
        (unless (eq new-frame old-frame)
  	;; `display-buffer' has chosen another frame, make sure it gets

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Drew Adams]

>  > Yes, I get the same result as you do:
>  >
>  > (#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> #<buffer buf002.txt>
>  > #<buffer buf001.txt> #<buffer *scratch*> #<buffer  
> *Minibuf-0*> ...)
> 
> I checked in a fix.  Could you please try whether it changes anything?
> Drew.  Could you try the attached patch?

Hi Martin; thanks for working on this.
I put the following in a file foo.el:

---------8<----------------------
(defun pop-to-buffer (buffer-or-name &optional other-window norecord)
  (let ((buffer
         (if (null buffer-or-name) (other-buffer (current-buffer))
           (or (get-buffer buffer-or-name)
               (let ((buf (get-buffer-create buffer-or-name)))
                 (set-buffer-major-mode buf)
                 buf))))
	(old-window (selected-window))
	(old-frame (selected-frame))
	new-window new-frame)
    (set-buffer buffer)
    ;; REMOVED norecord <===================
    (setq new-window (display-buffer buffer other-window))
    (unless (eq new-window old-window)
      ;; `display-buffer' has chosen another window, select it.
      ;; ADDED norecord <===================
      (select-window new-window norecord)
      (setq new-frame (window-frame new-window))
      (unless (eq new-frame old-frame)
	;; `display-buffer' has chosen another frame, make sure it gets
	;; input focus and is risen.
	(select-frame-set-input-focus new-frame)))
    buffer))

(setq enable-recursive-minibuffers t)
(find-file "c:/dir/buf001.txt")
(find-file-other-frame "c:/dir/buf002.txt")
(switch-to-buffer-other-frame "buf001.txt")
---------8<----------------------

I did emacs -Q, C-x C-f foo.el

I did M-x M-: (buffer-list) in buffer buf001.txt.

I got this (same as before):

(#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> #<buffer buf002.txt> #<buffer
buf001.txt> #<buffer testcase.el> #<buffer drews-lisp-20> #<buffer  *tip*>
#<buffer *scratch*> #<buffer  *Minibuf-0*> #<buffer *Messages*> #<buffer
*code-conversion-work*> #<buffer  *Echo Area 0*> ...)

IOW, there was no change; the problem is as before. Did it work for you?

Let me know if I'm not testing it correctly.

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[martin rudalics]

> I put the following in a file foo.el:
> 
> ---------8<----------------------
> (defun pop-to-buffer (buffer-or-name &optional other-window norecord)
[...]
>     buffer))

You did evaluate it?

martin

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Drew Adams]

> You did evaluate it?

Yes. Sorry, I forgot to say that I loaded the file (load-file) after visiting
it.

Do you get a different result when you do what I did?

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[martin rudalics]

 > Do you get a different result when you do what I did?

M-x M-: (buffer-list) gives

(#<buffer *Minibuf-1*> #<buffer *Minibuf-2*> #<buffer buf002.txt>
#<buffer buf001.txt> #<buffer foo.el> #<buffer *scratch*>
#<buffer *Minibuf-0*> #<buffer *Messages*> #<buffer
*code-conversion-work*> #<buffer *Echo Area 0*> #<buffer *Echo
Area 1*>)

similar to what you got.

martin

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[martin rudalics]

I suppose this issue has been fixed with the recent changes to
`save-selected-window' and friends.  Could someone please confirm with
Drew's original recipe (he doesn't build Emacs, so we would have to wait
till he gets Lennart's next release) given below.

Evaluate the forms following "emacs -Q" in *scratch*.  Note the use of
"M-x M-:".

Thanks, martin


Create two files /dir/buf001.txt and /dir/buf002.txt.

emacs -Q
(setq enable-recursive-minibuffers t)
(find-file "/dir/buf001.txt")
(find-file-other-frame "/dir/buf002.txt")
(switch-to-buffer-other-frame "buf001.txt")

M-x M-: (buffer-list)

This returns:
(#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*>
  #<buffer buf002.txt> #<buffer buf001.txt>...)

In previous Emacs releases (e.g. 22.3) it returns this:
(#<buffer  *Minibuf-1*> #<buffer buf001.txt>
  #<buffer buf002.txt> ... #<buffer  *Minibuf-0*>...)

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Juanma Barranquero]

On Tue, Nov 4, 2008 at 08:49, martin rudalics <rudalics@gmx.at> wrote:

> I suppose this issue has been fixed with the recent changes to
> `save-selected-window' and friends.  Could someone please confirm with
> Drew's original recipe (he doesn't build Emacs, so we would have to wait
> till he gets Lennart's next release) given below.
>
> Evaluate the forms following "emacs -Q" in *scratch*.  Note the use of
> "M-x M-:".

(#<buffer  *Minibuf-1*> #<buffer buf001.txt> #<buffer buf002.txt> ...
#<buffer  *Minibuf-0*> ...)

  Juanma

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[martin rudalics]

> (#<buffer  *Minibuf-1*> #<buffer buf001.txt> #<buffer buf002.txt> ...
> #<buffer  *Minibuf-0*> ...)

So I think that has been fixed.

Thanks for testing, martin.

bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order

[Drew Adams]

> So I think that has been fixed.

Thanks, guys.

bug#1121: marked as done (23.0.60; `buffer-list' returns buffers in wrong order)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]


Your message dated Mon, 17 Nov 2008 11:19:01 +0100
with message-id <49214515.6090300@gmx.at>
and subject line Re: bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order
has caused the Emacs bug report #1121,
regarding 23.0.60; `buffer-list' returns buffers in wrong order
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1121: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1121
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5495 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.60; `buffer-list' returns buffers in wrong order
Date: Wed, 8 Oct 2008 12:00:41 -0700
Message-ID: <005a01c92978$28f92240$c2b22382@us.oracle.com>

Create two files /dir/buf001.txt and /dir/buf002.txt.
 
emacs -Q
(setq enable-recursive-minibuffers t)
(find-file "/dir/buf001.txt")
(find-file-other-frame "/dir/buf002.txt")
(switch-to-buffer-other-frame "buf001.txt")
 
M-x M-: (buffer-list)
 
This returns: 
(#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> 
 #<buffer buf002.txt> #<buffer buf001.txt>...)
 
In previous Emacs releases (e.g. 22.3) it returns this:
(#<buffer  *Minibuf-1*> #<buffer buf001.txt> 
 #<buffer buf002.txt> ... #<buffer  *Minibuf-0*>...)
 
The problems are that in Emacs 23 the last sentence in this section of
the Elisp manual is not respected:
 
  Function: buffer-list &optional frame
     This function returns the buffer list, including all buffers, even
     those whose names begin with a space.  The elements are actual
     buffers, not their names.
 
     If FRAME is a frame, this returns FRAME's buffer list.  If FRAME
     is `nil', the fundamental Emacs buffer list is used: all the
     buffers appear in order of most recent selection, regardless of
     which frames they were selected in.
 
That is, the buffers are not in order of most recent selection. The
minibuffer of the current frame should be first, followed by the
buffer that was selected before entering the minibuffer. Instead,
buffers on another frame come before these buffers.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t
 
Major mode: Fundamental
 
Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
 
Recent input:
C-x C-f t e s t c <tab> <return> <down-mouse-1> <mouse-1> 
<down-mouse-3> <mouse-3> M-x e v a l - r e g <return> 
<switch-frame> <switch-frame> M-x M-: ( b u f f e r 
- l i s t ) <return> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <menu-bar> 
<help-menu> <send-emacs-bug-report>
 
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
(#<buffer  *Minibuf-1*> #<buffer  *Minibuf-2*> #<buffer buf002.txt> #<buffer
buf001.txt> #<buffer testcase.el> #<buffer drews-lisp-20> #<buffer *scratch*>
#<buffer  *Minibuf-0*> #<buffer *Messages*> #<buffer  *code-conversion-work*>
#<buffer  *Echo Area 0*> #<buffer  *Echo Area 1*>)





[-- Attachment #3: Type: message/rfc822, Size: 1910 bytes --]

From: martin rudalics <rudalics@gmx.at>
To: 1121-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1121: 23.0.60; `buffer-list' returns buffers in wrong order
Date: Mon, 17 Nov 2008 11:19:01 +0100
Message-ID: <49214515.6090300@gmx.at>

Seems to have been fixed as a side-effect of the changes to
`save-selected-window' from 2008-11-02 and 2008-11-04.

Thanks for the report, martin.