From: Randy Taylor <dev@rjt.dev>
To: "Йордан Миладинов" <yordanm@proton.me>
Cc: Eli Zaretskii <eliz@gnu.org>, 63708@debbugs.gnu.org, casouri@gmail.com
Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe
Date: Sat, 27 May 2023 03:00:09 +0000 [thread overview]
Message-ID: <hINrA-MaOXV7B2up1CNBtDIbjG4RZlb0ME1CWEJhUph0aufSnpGIN4gH6HbPWpnjyZkh3EK7Zh0-fIM1QVA1U26X0gLdHYFmKZIBTxOPYMA=@rjt.dev> (raw)
In-Reply-To: <8T8C4l5XryyVmB2cBTnmhGMnoELwHA2y1u1ZeMlg1WaQKzrPeOoe6L5hOQq3JPdsnG9r-puSlQfNZ091qBCGpVco-mC6ruhsQs0SvaPjkjQ=@proton.me>
On Friday, May 26th, 2023 at 15:14, Йордан Миладинов <yordanm@proton.me> wrote:
> Here's a patch that implements Randy's idea.
>
Thanks for working on this!
This fix is indeed what I had in mind and I see that you also fixed another bug, thanks!
Eli, the changes to the existing loop are needed to apply the correct syntax properties
to type_parameters, which were previously incorrectly considered punctuation.
I think this is the safest fix for Emacs 29.
I have some other comments about the patch below.
+ (put-text-property (match-beginning 0)
+ (match-end 0)
+ 'syntax-table
+ '(7))))
^^^
Do we want to use string-to-syntax here?
- "Apply syntax text property to template delimiters between BEG and END.
+ "Apply proper syntax properties to various special characters with
+double meaning in Rust code between BEG and END.
Maybe "Apply syntax properties to various special characters with contextual meaning between BEG and END."?
-< and > are usually punctuation, e.g., as greater/less-than. But
-when used for types, they should be considered pairs.
+Apostrophe (') is commonly treated as punctuation, but when used
+to define character literals, it should be treated as a string.
Maybe "Apostrophes (') are commonly treated as punctuation, but when used to define character literals, they should be treated as strings."?
next prev parent reply other threads:[~2023-05-27 3:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 21:40 bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-24 22:05 ` bug#63709: " yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-25 5:28 ` Eli Zaretskii
2023-05-25 5:31 ` bug#63708: " Eli Zaretskii
2023-05-25 12:52 ` Randy Taylor
2023-05-25 13:13 ` Eli Zaretskii
2023-05-26 2:21 ` Randy Taylor
2023-05-26 19:14 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-27 3:00 ` Randy Taylor [this message]
2023-05-28 19:51 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-28 19:52 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-29 11:25 ` Eli Zaretskii
2023-05-29 13:34 ` Randy Taylor
2023-05-29 1:29 ` Randy Taylor
2023-05-29 12:13 ` Eli Zaretskii
2023-05-29 12:18 ` Randy Taylor
2023-05-29 13:13 ` Eli Zaretskii
2023-05-29 13:20 ` Randy Taylor
2023-05-29 14:13 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-29 14:27 ` Eli Zaretskii
2023-05-29 14:54 ` Йордан Миладинов
2023-05-29 14:59 ` Eli Zaretskii
2023-05-30 0:14 ` Randy Taylor
2023-05-30 9:44 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-03 8:35 ` Eli Zaretskii
2023-05-30 9:10 ` Йордан Миладинов
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hINrA-MaOXV7B2up1CNBtDIbjG4RZlb0ME1CWEJhUph0aufSnpGIN4gH6HbPWpnjyZkh3EK7Zh0-fIM1QVA1U26X0gLdHYFmKZIBTxOPYMA=@rjt.dev' \
--to=dev@rjt.dev \
--cc=63708@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=yordanm@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).