From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe Date: Sat, 27 May 2023 03:00:09 +0000 Message-ID: References: <83pm6pm0yz.fsf@gnu.org> <2MdRTHLlZtWDlCx6Ky-LFtla6-aBBs4PlNgTuatIC-h4OIuKdPmsmWsIokUQ9LBMHNvH_ooIvMUlQH8F8XOjNrEUUdC9FtR1l_e6RZSy7xU=@rjt.dev> <837cswmu5a.fsf@gnu.org> <8T8C4l5XryyVmB2cBTnmhGMnoELwHA2y1u1ZeMlg1WaQKzrPeOoe6L5hOQq3JPdsnG9r-puSlQfNZ091qBCGpVco-mC6ruhsQs0SvaPjkjQ=@proton.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40615"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 63708@debbugs.gnu.org, casouri@gmail.com To: =?UTF-8?Q?=D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD_?= =?UTF-8?Q?=D0=9C=D0=B8=D0=BB=D0=B0=D0=B4=D0=B8=D0=BD=D0=BE=D0=B2?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 27 05:01:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2kBG-000ANY-3B for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 May 2023 05:01:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2kAy-0004Tm-7S; Fri, 26 May 2023 23:01:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2kAw-0004Tc-G9 for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 23:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2kAw-0005lc-8M for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 23:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2kAw-00087C-3l for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 23:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 May 2023 03:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63708 X-GNU-PR-Package: emacs Original-Received: via spool by 63708-submit@debbugs.gnu.org id=B63708.168515643031133 (code B ref 63708); Sat, 27 May 2023 03:01:02 +0000 Original-Received: (at 63708) by debbugs.gnu.org; 27 May 2023 03:00:30 +0000 Original-Received: from localhost ([127.0.0.1]:51128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2kAP-000865-Ou for submit@debbugs.gnu.org; Fri, 26 May 2023 23:00:30 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:34447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2kAL-00085h-7l for 63708@debbugs.gnu.org; Fri, 26 May 2023 23:00:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1685156418; x=1685415618; bh=E9jSO63zNsJwq2eLbGEeF06HEaVXd+/H1YJCUDr2rZc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=mgz3DuTwZTGp6jWxnyqPf07IL9VTJbJ5AuTl97+jOAjA2DR6e9/FEHlzNh7P073Ty t5V3aSIZcmXVwVgn5OkCpT1SR1eCXXKKTImbj9EijQjCT5PNjx0GUKSo8dIoR6SuAX r77z3CT2+nlEP0+YEen1Li4tQ7ot4eFtw3CaSZZ4ak/QshZZyU5VNHByfLnsVOm6Mb 4u/Zy8cY8Q7zyMW8/zrsTL4SAKfXtVFZZXJgrxeFUYOA6jzwcJhZjaZbiLCQQd+L7k Tvr4XTIy3uDwm5t5AEfuosC59bMK/EajfgOY6CuBNDwrZ2GTAxTZlwe+kfzr5P0CUx 2tj5819rHvP4g== In-Reply-To: <8T8C4l5XryyVmB2cBTnmhGMnoELwHA2y1u1ZeMlg1WaQKzrPeOoe6L5hOQq3JPdsnG9r-puSlQfNZ091qBCGpVco-mC6ruhsQs0SvaPjkjQ=@proton.me> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262456 Archived-At: On Friday, May 26th, 2023 at 15:14, =D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD = =D0=9C=D0=B8=D0=BB=D0=B0=D0=B4=D0=B8=D0=BD=D0=BE=D0=B2 = wrote: > Here's a patch that implements Randy's idea. >=20 Thanks for working on this! This fix is indeed what I had in mind and I see that you also fixed another= bug, thanks! Eli, the changes to the existing loop are needed to apply the correct synta= x properties to type_parameters, which were previously incorrectly considered punctuatio= n. I think this is the safest fix for Emacs 29. I have some other comments about the patch below. + (put-text-property (match-beginning 0) + (match-end 0) + 'syntax-table + '(7)))) ^^^ Do we want to use string-to-syntax here? - "Apply syntax text property to template delimiters between BEG and END. + "Apply proper syntax properties to various special characters with +double meaning in Rust code between BEG and END. Maybe "Apply syntax properties to various special characters with contextua= l meaning between BEG and END."? -< and > are usually punctuation, e.g., as greater/less-than. But -when used for types, they should be considered pairs. +Apostrophe (') is commonly treated as punctuation, but when used +to define character literals, it should be treated as a string. Maybe "Apostrophes (') are commonly treated as punctuation, but when used t= o define character literals, they should be treated as strings."?