unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
@ 2016-12-01 19:51 Glenn Morris
  2016-12-02  7:04 ` Eli Zaretskii
  2016-12-02 13:20 ` Nicolas Petton
  0 siblings, 2 replies; 9+ messages in thread
From: Glenn Morris @ 2016-12-01 19:51 UTC (permalink / raw)
  To: 25084

Package: emacs
Version: 25.1.90

In the 25.1.90 tarball, files.el is newer than files.elc.
This ought to be impossible, if the tarfile was created from a bootstrap.
It causes building to recompile files.el, which is harmless but should
not be needed in a release.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-01 19:51 bug#25084: 25.1.90 tarfile has files.el newer than files.elc Glenn Morris
@ 2016-12-02  7:04 ` Eli Zaretskii
  2016-12-02 13:20 ` Nicolas Petton
  1 sibling, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2016-12-02  7:04 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 25084

> From: Glenn Morris <rgm@gnu.org>
> Date: Thu, 01 Dec 2016 14:51:43 -0500
> 
> In the 25.1.90 tarball, files.el is newer than files.elc.
> This ought to be impossible, if the tarfile was created from a bootstrap.

Indeed, and there were a couple of other files with the same issue.
mule-cmds.el is one other, and also the ELisp manual was rebuilt
because one of its source files was newer.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-01 19:51 bug#25084: 25.1.90 tarfile has files.el newer than files.elc Glenn Morris
  2016-12-02  7:04 ` Eli Zaretskii
@ 2016-12-02 13:20 ` Nicolas Petton
  2016-12-07 15:46   ` Phillip Lord
  1 sibling, 1 reply; 9+ messages in thread
From: Nicolas Petton @ 2016-12-02 13:20 UTC (permalink / raw)
  To: Glenn Morris, 25084

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Glenn Morris <rgm@gnu.org> writes:

Hi Glenn,

> In the 25.1.90 tarball, files.el is newer than files.elc.
> This ought to be impossible, if the tarfile was created from a
> bootstrap.

It was, but I might have pulled a commit after bootstrapping (Eli
mentioned that reason to me, and while I don't remember doing that, it
has to be the case).

> It causes building to recompile files.el, which is harmless but should
> not be needed in a release.

Indeed.  I'll keep this bug report open until the next pretest.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-02 13:20 ` Nicolas Petton
@ 2016-12-07 15:46   ` Phillip Lord
  2016-12-07 18:01     ` Glenn Morris
  0 siblings, 1 reply; 9+ messages in thread
From: Phillip Lord @ 2016-12-07 15:46 UTC (permalink / raw)
  To: Nicolas Petton; +Cc: 25084

Nicolas Petton <nicolas@petton.fr> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
> Hi Glenn,
>
>> In the 25.1.90 tarball, files.el is newer than files.elc.
>> This ought to be impossible, if the tarfile was created from a
>> bootstrap.
>
> It was, but I might have pulled a commit after bootstrapping (Eli
> mentioned that reason to me, and while I don't remember doing that, it
> has to be the case).
>
>> It causes building to recompile files.el, which is harmless but should
>> not be needed in a release.
>
> Indeed.  I'll keep this bug report open until the next pretest.


Can we add something to the build that checks this before the tar step?

Phil





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-07 15:46   ` Phillip Lord
@ 2016-12-07 18:01     ` Glenn Morris
  2016-12-08  0:14       ` Glenn Morris
  0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2016-12-07 18:01 UTC (permalink / raw)
  To: Phillip Lord; +Cc: Nicolas Petton, 25084

Phillip Lord wrote:

> Can we add something to the build that checks this before the tar step?

I think "make-dist" should get a check for this (for each .elc. check it
is newer than the .el, probably also for .info and .texi),
which --snapshot should run by default.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-07 18:01     ` Glenn Morris
@ 2016-12-08  0:14       ` Glenn Morris
  2016-12-09 17:19         ` Phillip Lord
                           ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Glenn Morris @ 2016-12-08  0:14 UTC (permalink / raw)
  To: Phillip Lord; +Cc: 25084, Nicolas Petton

Glenn Morris wrote:

> I think "make-dist" should get a check for this (for each .elc. check it
> is newer than the .el, probably also for .info and .texi),
> which --snapshot should run by default.

Done in 129645a. (Necessarily on emacs-25 to benefit next pretest.)





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-08  0:14       ` Glenn Morris
@ 2016-12-09 17:19         ` Phillip Lord
  2016-12-10  1:11         ` Nicolas Petton
  2016-12-30 23:12         ` Nicolas Petton
  2 siblings, 0 replies; 9+ messages in thread
From: Phillip Lord @ 2016-12-09 17:19 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 25084, Nicolas Petton

Glenn Morris <rgm@gnu.org> writes:

> Glenn Morris wrote:
>
>> I think "make-dist" should get a check for this (for each .elc. check it
>> is newer than the .el, probably also for .info and .texi),
>> which --snapshot should run by default.
>
> Done in 129645a. (Necessarily on emacs-25 to benefit next pretest.)


Thanks!





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-08  0:14       ` Glenn Morris
  2016-12-09 17:19         ` Phillip Lord
@ 2016-12-10  1:11         ` Nicolas Petton
  2016-12-30 23:12         ` Nicolas Petton
  2 siblings, 0 replies; 9+ messages in thread
From: Nicolas Petton @ 2016-12-10  1:11 UTC (permalink / raw)
  To: Glenn Morris, Phillip Lord; +Cc: 25084

[-- Attachment #1: Type: text/plain, Size: 124 bytes --]

Glenn Morris <rgm@gnu.org> writes:

> Done in 129645a. (Necessarily on emacs-25 to benefit next pretest.)

Thank you!

Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#25084: 25.1.90 tarfile has files.el newer than files.elc
  2016-12-08  0:14       ` Glenn Morris
  2016-12-09 17:19         ` Phillip Lord
  2016-12-10  1:11         ` Nicolas Petton
@ 2016-12-30 23:12         ` Nicolas Petton
  2 siblings, 0 replies; 9+ messages in thread
From: Nicolas Petton @ 2016-12-30 23:12 UTC (permalink / raw)
  To: Glenn Morris, Phillip Lord; +Cc: 25084, 25084-done

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Glenn Morris <rgm@gnu.org> writes:

> Glenn Morris wrote:
>
>> I think "make-dist" should get a check for this (for each .elc. check it
>> is newer than the .el, probably also for .info and .texi),
>> which --snapshot should run by default.
>
> Done in 129645a. (Necessarily on emacs-25 to benefit next pretest.)

Now that the new pretest is out, I'm closing this issue.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-12-30 23:12 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-01 19:51 bug#25084: 25.1.90 tarfile has files.el newer than files.elc Glenn Morris
2016-12-02  7:04 ` Eli Zaretskii
2016-12-02 13:20 ` Nicolas Petton
2016-12-07 15:46   ` Phillip Lord
2016-12-07 18:01     ` Glenn Morris
2016-12-08  0:14       ` Glenn Morris
2016-12-09 17:19         ` Phillip Lord
2016-12-10  1:11         ` Nicolas Petton
2016-12-30 23:12         ` Nicolas Petton

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).