From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
To: 48026@debbugs.gnu.org
Subject: bug#48026: [PATCH] Possible typo in tramp-get-remote-gid
Date: Mon, 26 Apr 2021 09:10:27 +0200 [thread overview]
Message-ID: <fv2zoj35vdbjx8.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
Hi,
I was browsing through TRAMP's source code and noticed a possible typo
in tramp-get-remote-gid. Please note that I have almost no familiarity
with the code, so it may well not even be a typo.
Here is what I am talking about:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix typo in tramp-get-remote-gid --]
[-- Type: text/x-diff, Size: 969 bytes --]
From 87ed8e1e19fd4ddb0922d907a45569c61598369d Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
Date: Mon, 26 Apr 2021 09:01:51 +0200
Subject: [PATCH] Fix typo in tramp-get-remote-gid
* lisp/net/tramp.el (tramp-get-remote-gid): Pass the correct operation
to find-file-name-handler.
---
lisp/net/tramp.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index a411aaf..dc34b8f 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -5080,7 +5080,7 @@ ID-FORMAT valid values are `string' and `integer'."
(or (when-let
((handler
(find-file-name-handler
- (tramp-make-tramp-file-name vec) 'tramp-get-remote-uid)))
+ (tramp-make-tramp-file-name vec) 'tramp-get-remote-gid)))
(funcall handler #'tramp-get-remote-gid vec id-format))
;; Ensure there is a valid result.
(and (equal id-format 'integer) tramp-unknown-id-integer)
--
2.31.GIT
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
Best regards,
Dario
--
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid
next reply other threads:[~2021-04-26 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 7:10 Dario Gjorgjevski [this message]
2021-04-26 8:00 ` bug#48026: [PATCH] Possible typo in tramp-get-remote-gid Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fv2zoj35vdbjx8.fsf@gmail.com \
--to=dario.gjorgjevski@gmail.com \
--cc=48026@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).