From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dario Gjorgjevski Newsgroups: gmane.emacs.bugs Subject: bug#48026: [PATCH] Possible typo in tramp-get-remote-gid Date: Mon, 26 Apr 2021 09:10:27 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6326"; mail-complaints-to="usenet@ciao.gmane.io" To: 48026@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 26 09:11:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lavOt-0001QH-KB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Apr 2021 09:11:23 +0200 Original-Received: from localhost ([::1]:39590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lavOs-0001ng-NX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Apr 2021 03:11:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lavOY-0001nW-BA for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 03:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lavOY-0007yO-2R for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 03:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lavOX-0007WQ-T0 for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 03:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dario Gjorgjevski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Apr 2021 07:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161942103728881 (code B ref -1); Mon, 26 Apr 2021 07:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Apr 2021 07:10:37 +0000 Original-Received: from localhost ([127.0.0.1]:44316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lavO8-0007Vl-VG for submit@debbugs.gnu.org; Mon, 26 Apr 2021 03:10:37 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:41124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lavO7-0007Vd-Gl for submit@debbugs.gnu.org; Mon, 26 Apr 2021 03:10:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lavO7-0001jq-C7 for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 03:10:35 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:33433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lavO3-0007Wm-3j for bug-gnu-emacs@gnu.org; Mon, 26 Apr 2021 03:10:35 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id n2so1428821wrm.0 for ; Mon, 26 Apr 2021 00:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=5lW95ZJNrSEvmj0DChs6Eh19IinGRCpgKXdC8Yy4ieY=; b=LE/pww+v5idBJzsDowP+UWUdYk1fe9h37pBBqMGhEWYvtHZJ745DCit7fzOOq5RZFT JunaIOxJEuXj6fzUrASRpXvktFb11FmBIy1BOV6pds+rpc9OHAlid6q4WnLT0XKf8QGU dUPJMSTB45XeMlNsM2XBRZXqWTTlPTyXfs3AGqXAjsC/pPF63jstPKH4tfE2KnFVgn/n RSPUFiohWgjh15mLNVzUnPYNncKPUxnDGMVemQwavfZJFmnPwWEejWnHi0Ai+roy8mfe b2tkwGo5uXwN7EVFW4fM8e03fod3b1oy0UXT/pKf1fNE5IyURhCUrNQ6pjwgb3HpPw/D wcZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5lW95ZJNrSEvmj0DChs6Eh19IinGRCpgKXdC8Yy4ieY=; b=cHyqP4tEzNa5XPonw1F+C1GciHpFK0TOOeqpaMqRNDLUs/7BswBrPrMRv6RWQ7r1Ek Dw7yH9S8EVb/TfUHiSgJy04k6/3vVfJRC8HhLHmbBha+K3kcpxACQQt0FlHF5Bi3vZDM EA02Vzn3ez2+sKMrMTbWQBoGzdv4FAWAq4N1AXwzocKJaK9aRw/JYgY7H2lsa6kq8DCO RqDksztlNdFr1gbNcgcoBfLvklkn4Ww0/mwEQb2O5OxKirijTk11fbKL6B61hg3IUGOW JHoMaDovXTJWBYY/dVCTTNNjaNaAWPRVi/Gi292IzQyD+SMO4WGpzYfqa1I67zNrhClp 123Q== X-Gm-Message-State: AOAM531ITexW2a8lNyXMrPfatThTIwWzZih1ANFlghlP4hY8d2KXg4XJ 1Ws971TS2fZ9Bl0v8k7jn6Xh0RGQHAjiPA== X-Google-Smtp-Source: ABdhPJzAQ4i2/qc9cvMpEwt+532DY+D7N8+ptmcV/lqASb3BZepNhHfxXhLWWNPcxmXIzFBakO/F9A== X-Received: by 2002:adf:f7d2:: with SMTP id a18mr2521285wrq.198.1619421028626; Mon, 26 Apr 2021 00:10:28 -0700 (PDT) Original-Received: from ZALANDO-31298 (p200300e97702ce0f30e8472eb4351e58.dip0.t-ipconnect.de. [2003:e9:7702:ce0f:30e8:472e:b435:1e58]) by smtp.gmail.com with ESMTPSA id 61sm21226118wrm.52.2021.04.26.00.10.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Apr 2021 00:10:27 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=dario.gjorgjevski@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204936 Archived-At: --=-=-= Content-Type: text/plain Hi, I was browsing through TRAMP's source code and noticed a possible typo in tramp-get-remote-gid. Please note that I have almost no familiarity with the code, so it may well not even be a typo. Here is what I am talking about: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-typo-in-tramp-get-remote-gid.patch Content-Description: Fix typo in tramp-get-remote-gid >From 87ed8e1e19fd4ddb0922d907a45569c61598369d Mon Sep 17 00:00:00 2001 From: Dario Gjorgjevski Date: Mon, 26 Apr 2021 09:01:51 +0200 Subject: [PATCH] Fix typo in tramp-get-remote-gid * lisp/net/tramp.el (tramp-get-remote-gid): Pass the correct operation to find-file-name-handler. --- lisp/net/tramp.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el index a411aaf..dc34b8f 100644 --- a/lisp/net/tramp.el +++ b/lisp/net/tramp.el @@ -5080,7 +5080,7 @@ ID-FORMAT valid values are `string' and `integer'." (or (when-let ((handler (find-file-name-handler - (tramp-make-tramp-file-name vec) 'tramp-get-remote-uid))) + (tramp-make-tramp-file-name vec) 'tramp-get-remote-gid))) (funcall handler #'tramp-get-remote-gid vec id-format)) ;; Ensure there is a valid result. (and (equal id-format 'integer) tramp-unknown-id-integer) -- 2.31.GIT --=-=-= Content-Type: text/plain Best regards, Dario -- $ keyserver=hkps://hkps.pool.sks-keyservers.net $ keyid=744A4F0B4F1C9371 $ gpg --keyserver $keyserver --search-keys $keyid --=-=-=--