unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mauro Aranda <maurooaranda@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: Eli Zaretskii <eliz@gnu.org>, 65401@debbugs.gnu.org
Subject: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced
Date: Mon, 21 Aug 2023 11:41:48 -0300	[thread overview]
Message-ID: <ff71815d-25b7-1817-62e9-798efacf11f6@gmail.com> (raw)
In-Reply-To: <874jksj04c.fsf@posteo.net>

Philip Kaludercic <philipk@posteo.net> writes:

 > Mauro Aranda <maurooaranda@gmail.com> writes:
 >
 >>
 >> OK, thank you.  I attach the patch.
 >>
 >> From c34dea06956f2a3d098badf9cea089bee0f7b61b Mon Sep 17 00:00:00 2001
 >> From: Mauro Aranda <maurooaranda@gmail.com>
 >> Date: Sun, 20 Aug 2023 10:39:49 -0300
 >> Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401)
 >>
 >> * lisp/custom.el (custom-theme-directory): Make it of type directory.
 >> ---
 >>  lisp/custom.el | 4 ++--
 >>  1 file changed, 2 insertions(+), 2 deletions(-)
 >>
 >> diff --git a/lisp/custom.el b/lisp/custom.el
 >> index 083349e3591..5b244464d0b 100644
 >> --- a/lisp/custom.el
 >> +++ b/lisp/custom.el
 >> @@ -1208,9 +1208,9 @@ custom-theme-directory
 >>  directory.  By default, Emacs searches for custom themes in this
 >>  directory first---see `custom-theme-load-path'."
 >>    :initialize #'custom-initialize-delay
 >> -  :type 'string
 >> +  :type 'directory
 >>    :group 'customize
 >> -  :version "22.1")
 >> +  :version "30.1")
 >
 > Does the version tag have to be bumped, for a metadata change this like?
 >

I wasn't sure.  But now I can see why it was wrong to update it. Thank
you for noticing it.





      parent reply	other threads:[~2023-08-21 14:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-20 10:48 bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Mauro Aranda
2023-08-20 11:12 ` Eli Zaretskii
2023-08-20 11:28   ` Mauro Aranda
2023-08-20 12:26     ` Eli Zaretskii
2023-08-20 12:35       ` Mauro Aranda
2023-08-20 13:32         ` Eli Zaretskii
2023-08-20 13:43           ` Mauro Aranda
2023-08-21  8:00             ` Philip Kaludercic
2023-08-21 11:05               ` Eli Zaretskii
2023-08-21 12:39                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-21 14:46                   ` Mauro Aranda
2023-08-26  8:02                     ` Eli Zaretskii
2023-08-21 14:41               ` Mauro Aranda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff71815d-25b7-1817-62e9-798efacf11f6@gmail.com \
    --to=maurooaranda@gmail.com \
    --cc=65401@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).