From: Mauro Aranda <maurooaranda@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 65401@debbugs.gnu.org
Subject: bug#65401: 30.0.50; custom-theme-directory :type could be enhanced
Date: Sun, 20 Aug 2023 10:43:31 -0300 [thread overview]
Message-ID: <b7c208a6-8611-a035-7ad2-11559c27d918@gmail.com> (raw)
In-Reply-To: <83msylx2je.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Sun, 20 Aug 2023 09:35:17 -0300
>> Cc: 65401@debbugs.gnu.org
>> From: Mauro Aranda <maurooaranda@gmail.com>
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > If the directory doesn't have to exist, then what is the difference
>> > between :directory and :string?
>>
>> Completion when editing via Customize is the only one it comes to my
>> mind right now (useful when the user wants to edit it to some directory
>> it already exists).
>
> Then I don't see why would anyone object to the change you propose.
> It has no downsides, AFAICT.
>
> Thanks.
OK, thank you. I attach the patch.
[-- Attachment #2: 0001-Improve-type-of-custom-theme-directory-Bug-65401.patch --]
[-- Type: text/x-patch, Size: 933 bytes --]
From c34dea06956f2a3d098badf9cea089bee0f7b61b Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Sun, 20 Aug 2023 10:39:49 -0300
Subject: [PATCH] Improve type of custom-theme-directory (Bug#65401)
* lisp/custom.el (custom-theme-directory): Make it of type directory.
---
lisp/custom.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/custom.el b/lisp/custom.el
index 083349e3591..5b244464d0b 100644
--- a/lisp/custom.el
+++ b/lisp/custom.el
@@ -1208,9 +1208,9 @@ custom-theme-directory
directory. By default, Emacs searches for custom themes in this
directory first---see `custom-theme-load-path'."
:initialize #'custom-initialize-delay
- :type 'string
+ :type 'directory
:group 'customize
- :version "22.1")
+ :version "30.1")
(defvar custom-theme-load-path (list 'custom-theme-directory t)
"List of directories to search for custom theme files.
--
2.34.1
next prev parent reply other threads:[~2023-08-20 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 10:48 bug#65401: 30.0.50; custom-theme-directory :type could be enhanced Mauro Aranda
2023-08-20 11:12 ` Eli Zaretskii
2023-08-20 11:28 ` Mauro Aranda
2023-08-20 12:26 ` Eli Zaretskii
2023-08-20 12:35 ` Mauro Aranda
2023-08-20 13:32 ` Eli Zaretskii
2023-08-20 13:43 ` Mauro Aranda [this message]
2023-08-21 8:00 ` Philip Kaludercic
2023-08-21 11:05 ` Eli Zaretskii
2023-08-21 12:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-21 14:46 ` Mauro Aranda
2023-08-26 8:02 ` Eli Zaretskii
2023-08-21 14:41 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7c208a6-8611-a035-7ad2-11559c27d918@gmail.com \
--to=maurooaranda@gmail.com \
--cc=65401@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).