* bug#63317: 29.0.90; ediff-auto-refine is set at require-time rather than runtime
@ 2023-05-05 20:15 Peter Oliver
2023-05-06 6:11 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Peter Oliver @ 2023-05-05 20:15 UTC (permalink / raw)
To: 63317
If ediff is loaded from a GUI, ediff-auto-refine defaults to "on", which is the desired behaviour.
However, if your ~/.emacs contains "(require 'ediff)", and you start emacs with the --daemon option, variable ediff-auto-refine will instead default to "nix", even if you later try to use ediff from a GUI started with "emacsclient --create-frame".
--
Peter Oliver
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#63317: 29.0.90; ediff-auto-refine is set at require-time rather than runtime
2023-05-05 20:15 bug#63317: 29.0.90; ediff-auto-refine is set at require-time rather than runtime Peter Oliver
@ 2023-05-06 6:11 ` Eli Zaretskii
2023-05-08 10:30 ` Peter Oliver
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2023-05-06 6:11 UTC (permalink / raw)
To: Peter Oliver; +Cc: 63317
> Date: Fri, 5 May 2023 21:15:11 +0100 (BST)
> From: Peter Oliver <p.d.oliver@mavit.org.uk>
>
> If ediff is loaded from a GUI, ediff-auto-refine defaults to "on", which is the desired behaviour.
>
> However, if your ~/.emacs contains "(require 'ediff)", and you start emacs with the --daemon option, variable ediff-auto-refine will instead default to "nix", even if you later try to use ediff from a GUI started with "emacsclient --create-frame".
If you want the daemon session to do something that requires a GUI
frame, you need to have the relevant customizations in
server-after-make-frame-hook, so that the customizations run when such
a frame is already created. In this case, I suggest to have that hook
change the value of ediff-auto-refine depending on whether the created
frame is a GUI frame or a TTY frame. (Or, if you personally never
create TTY client frames, you can set ediff-auto-refine to "on"
unconditionally in that hook.)
Or maybe do that in some appropriate Ediff hook.
We cannot do this automatically, not via the default value of the
option, because a daemon session can be used for both GUI and TTY
frames (and can have frames of both types active at the same time in
the same session).
So I don't see a bug here, just a need for more elaborate
customizations in daemon sessions.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#63317: 29.0.90; ediff-auto-refine is set at require-time rather than runtime
2023-05-06 6:11 ` Eli Zaretskii
@ 2023-05-08 10:30 ` Peter Oliver
0 siblings, 0 replies; 3+ messages in thread
From: Peter Oliver @ 2023-05-08 10:30 UTC (permalink / raw)
To: 63317-done
Closing in favour of #63318.
--
Peter Oliver
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-08 10:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-05 20:15 bug#63317: 29.0.90; ediff-auto-refine is set at require-time rather than runtime Peter Oliver
2023-05-06 6:11 ` Eli Zaretskii
2023-05-08 10:30 ` Peter Oliver
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).