From: martin rudalics <rudalics@gmx.at>
To: Juri Linkov <juri@linkov.net>, 54028@debbugs.gnu.org
Subject: bug#54028: Window is not a valid window
Date: Mon, 21 Feb 2022 10:07:59 +0100 [thread overview]
Message-ID: <f9e6de93-98c9-8f94-e6a6-1a643d9ce282@gmx.at> (raw)
In-Reply-To: <68b4d9be-5e50-a541-9031-787fa7ce3b7c@gmx.at>
Eli, is the below OK to install on the release branch? It's a trivial
safety check that would fix this bug.
Thanks, martin
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -6394,7 +6394,8 @@ window-state-put
(window--state-put-2 ignore pixelwise))
(while window-state-put-stale-windows
(let ((window (pop window-state-put-stale-windows)))
- (when (eq (window-deletable-p window) t)
+ (when (and (window-valid-p window)
+ (eq (window-deletable-p window) t))
(delete-window window))))
(window--check frame))))
next prev parent reply other threads:[~2022-02-21 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 18:50 bug#54028: Window is not a valid window Juri Linkov
2022-02-17 10:06 ` martin rudalics
2022-02-17 17:34 ` Juri Linkov
2022-02-19 9:38 ` martin rudalics
2022-02-21 9:07 ` martin rudalics [this message]
2022-02-21 12:30 ` Eli Zaretskii
2022-02-21 16:50 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e6de93-98c9-8f94-e6a6-1a643d9ce282@gmx.at \
--to=rudalics@gmx.at \
--cc=54028@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).