From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#54028: Window is not a valid window Date: Mon, 21 Feb 2022 10:07:59 +0100 Message-ID: References: <865ypey7bz.fsf@mail.linkov.net> <68b4d9be-5e50-a541-9031-787fa7ce3b7c@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="336"; mail-complaints-to="usenet@ciao.gmane.io" To: Juri Linkov , 54028@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 21 10:10:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nM4hu-000AKB-RP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Feb 2022 10:10:10 +0100 Original-Received: from localhost ([::1]:57418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nM4ht-0000LY-05 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Feb 2022 04:10:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nM4go-0000Ho-VG for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 04:09:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nM4go-0005tb-L4 for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 04:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nM4go-00010t-Gv for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 04:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Feb 2022 09:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54028 X-GNU-PR-Package: emacs Original-Received: via spool by 54028-submit@debbugs.gnu.org id=B54028.16454344933803 (code B ref 54028); Mon, 21 Feb 2022 09:09:02 +0000 Original-Received: (at 54028) by debbugs.gnu.org; 21 Feb 2022 09:08:13 +0000 Original-Received: from localhost ([127.0.0.1]:35019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nM4g1-0000zC-Go for submit@debbugs.gnu.org; Mon, 21 Feb 2022 04:08:13 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:58635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nM4ft-0000yP-PO for 54028@debbugs.gnu.org; Mon, 21 Feb 2022 04:08:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645434480; bh=gFQtbJ4HDVjj/+hmi+pha6RkCiYHTrPv9R3eReYg7nk=; h=X-UI-Sender-Class:Date:Subject:From:To:References:Cc:In-Reply-To; b=V4v7f7eyhO6EscIatH4AdY8+fQqSzIwfPztXXcRojtp6ag/r+jrdawRQ2zPRAQo5w x/cv9m/QvjRgkRU0Pskjri4/6QcsWTyxceFiFx0ocKPdKV3eaT1EGSpT5GJyv7wrEK IrYYq0sAexyAwJH4MfWtW2KJ6jK+9IELjkbd9uBk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.226]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQ5rU-1nZBgF3DsW-00M5MQ; Mon, 21 Feb 2022 10:07:59 +0100 Content-Language: en-US In-Reply-To: <68b4d9be-5e50-a541-9031-787fa7ce3b7c@gmx.at> X-Provags-ID: V03:K1:iihgDkIuOZen8Qo0SSnWwtD8Jhk+1Ho0Lf9iwToBj/1xvpXc1Lm IyQa4TmjhAxjfNpYgCkxsZ+mnOfrsZ4qYpeDhjIYQl7jf1X5jn1Ckj/Xoko9w5BjH5VC8uf i6MBqH+IlQncL1I4bOyD7r1NBziLrveDJuJpH0hCkUOjp7DhXSVruqZVbpCdYGopWiHoFUD bkRzocnk2PKATt2nNCvkw== X-UI-Out-Filterresults: notjunk:1;V03:K0:zxtUkz+9mgQ=:2I247dnMiXwa9nQq4YF6ig NPF3zKrGv7I/PvSCOdweYDk2UZ4OLUv5AxUarS+O8GiHGFoGx1JpjOOrijGW1tpn8OX2kLqqf URbSLBTuO295oUgt2ARGeBzFpYFpGx2ZHgjjhV2R79WqkzQediMPQv520gnsVlvBcNUxhmvvY cTETcGfcaIWZsCdYh+O2zwEH2Ad4pR4gGkzAc1bsIeEU4UYXy03xvqpMNxLK5/vx3/yasz/YU ZTc6qw5KbeimCNglYX+Qo5iJkeEMaibj4pVCmv588pNHK7KqbYG/1Ejret9BiDpIJJIqi2nGb 2hs5HW5lhNMhZ5UL0PM8qu2vMil8UfUHpZnW3UmcchRWMpXKGx39VykPZCffu26SdAfJpQl9J Kxjrp9OTJ5f+t9zOIEHMcmUg0UGRc9HdKVVGJmzBQRMuchdzye0lS9cmgOIQ6y9/bPz2B6YKi oH3XRSTrcBQxHCM42b5esft1ng0tOzUvlFjPQKdAvBZ+PUHcy+SQXKZZaYZZ8zaBa914MPR1v +H6p3B7yz58Vh3lyAhahip59ZEkuU+D1PQ/vWQV6rq4QpkGCEAw01qqF5ipPrTywHCKqfWi/M 0WMdCvoJlJx8zct7K7CISFd6PHtmKqO9E+/XYgxDypwfqzWuzf+ZWusAY70L84Zp+8J4FA37m /A0pkTPSNi2QGIHhHjfo/yJjrsJYhS/3QtVy04W70LD3RW3Ct4nKbgf1HCOssOurTRJ0v+e7f /5iLsk+mEJ4BAGsmkLDq4y9TSQB8GtraWbkhx3MgIrYekFCD9QIZyXBQtu67NNhZe+HYsdjO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227311 Archived-At: Eli, is the below OK to install on the release branch? It's a trivial safety check that would fix this bug. Thanks, martin --- a/lisp/window.el +++ b/lisp/window.el @@ -6394,7 +6394,8 @@ window-state-put (window--state-put-2 ignore pixelwise)) (while window-state-put-stale-windows (let ((window (pop window-state-put-stale-windows))) - (when (eq (window-deletable-p window) t) + (when (and (window-valid-p window) + (eq (window-deletable-p window) t)) (delete-window window)))) (window--check frame))))