* bug#4218: Security assertion needs modification or more detail
@ 2009-08-20 23:40 Reuben Thomas
0 siblings, 0 replies; 2+ messages in thread
From: Reuben Thomas @ 2009-08-20 23:40 UTC (permalink / raw)
To: bug-emacs
The docstring for compile-command says: "This variable is safe as a
file local variable if its value satisfies the predicate `stringp'."
I'd say this is arguable, as it can be set to an arbitrary command
e.g. "send-me-all-your-passwords; make -k".
--
http://rrt.sc3d.org
Radiance is the appeasement of myth (Adorno)
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#4218: Security assertion needs modification or more detail
@ 2010-01-09 21:17 Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-01-09 21:17 UTC (permalink / raw)
To: Reuben Thomas; +Cc: 4218
> The docstring for compile-command says: "This variable is safe as a
> file local variable if its value satisfies the predicate `stringp'."
> I'd say this is arguable, as it can be set to an arbitrary command
> e.g. "send-me-all-your-passwords; make -k".
Thanks for the bug report.
I think the main risk occurs when the user has customized
compilation-read-command to nil, because then M-x compile does not issue
a prompt. So, I've changed the predicate to consider compile-command
unsafe if compilation-read-command is nil.
We could be more aggressive and always consider compilation-command
unsafe, but I'm not sure that's warranted. After all, there is the risk
that your makefile is malicious, anyway.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-09 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-20 23:40 bug#4218: Security assertion needs modification or more detail Reuben Thomas
-- strict thread matches above, loose matches on Subject: below --
2010-01-09 21:17 Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).