unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Jason Rumney <jasonr@f2s.com>
Cc: 2062@emacsbugs.donarmstrong.com
Subject: bug#2062: PATH can contain non-expanded variables
Date: Tue, 27 Jan 2009 09:34:26 +0100	[thread overview]
Message-ID: <f7ccd24b0901270034h14776d72xc876474d783045a7@mail.gmail.com> (raw)
In-Reply-To: <497E69EB.70609@f2s.com>

On Tue, Jan 27, 2009 at 02:56, Jason Rumney <jasonr@f2s.com> wrote:

> The right place to do this expansion is where the variable is read from the
> registry, and only when the type is REG_EXPAND_SZ.

The problem is, we don't read
"HKLM\Software\Microsoft\Windows\CurrentVersion\App
Paths\emacs.exe\Path", we find the PATH made for us and it contains
unexpanded variables.

My patch modifies decode_env_path, because it is used for PATH-like
variables, not generic environment variables. How likely is that such
a PATH-like variable contains a string like %VARIABLENAME%, meaning a
literal "%VARIABLENAME%" directory or filename (or part of it)? That's
a hypothetical problem, while my path containing such a variable is a
fact.

    Juanma






  reply	other threads:[~2009-01-27  8:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f7ccd24b0901280707u39a4364bk76339f2e5956fa5@mail.gmail.com>
2009-01-26 13:00 ` bug#2062: PATH can contain non-expanded variables Juanma Barranquero
2009-01-26 22:01   ` Lennart Borgman
2009-01-27  1:56   ` Jason Rumney
2009-01-27  8:34     ` Juanma Barranquero [this message]
2009-01-27  9:24       ` Jason Rumney
2009-01-27 10:25         ` Juanma Barranquero
2009-01-27 13:29           ` Jason Rumney
2009-01-27 14:42             ` Juanma Barranquero
2009-01-27 19:02             ` Stefan Monnier
2009-01-27 20:00               ` Juanma Barranquero
2009-01-28  8:39               ` Jason Rumney
2009-01-28  8:45                 ` Juanma Barranquero
2009-01-27 19:30           ` Eli Zaretskii
2009-01-27 19:55             ` Juanma Barranquero
2009-01-28  4:12               ` Eli Zaretskii
2009-01-28  8:36                 ` Juanma Barranquero
2009-01-28 14:24                   ` Stefan Monnier
2009-01-28 15:15   ` bug#2062: marked as done (PATH can contain non-expanded variables) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ccd24b0901270034h14776d72xc876474d783045a7@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=2062@emacsbugs.donarmstrong.com \
    --cc=jasonr@f2s.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).