From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#2062: PATH can contain non-expanded variables Date: Tue, 27 Jan 2009 09:34:26 +0100 Message-ID: References: <497E69EB.70609@f2s.com> Reply-To: Juanma Barranquero , 2062@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1233045965 28639 80.91.229.12 (27 Jan 2009 08:46:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Jan 2009 08:46:05 +0000 (UTC) Cc: 2062@emacsbugs.donarmstrong.com To: Jason Rumney Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 27 09:47:14 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LRjbD-0008Gs-O6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Jan 2009 09:47:12 +0100 Original-Received: from localhost ([127.0.0.1]:60776 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRjZv-0001Sm-VI for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Jan 2009 03:45:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRjXm-0000Dk-FD for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 03:43:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRjXi-0000Ar-A7 for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 03:43:36 -0500 Original-Received: from [199.232.76.173] (port=39254 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRjXg-0000AG-Ug for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 03:43:33 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38223) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRjXg-00020I-D1 for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 03:43:32 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0R8hT2K010224; Tue, 27 Jan 2009 00:43:30 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0R8e42m009140; Tue, 27 Jan 2009 00:40:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juanma Barranquero Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Tue, 27 Jan 2009 08:40:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2062 X-Emacs-PR-Package: emacs,w32 X-Emacs-PR-Keywords: Original-Received: via spool by 2062-submit@emacsbugs.donarmstrong.com id=B2062.12330452757764 (code B ref 2062); Tue, 27 Jan 2009 08:40:04 +0000 Original-Received: (at 2062) by emacsbugs.donarmstrong.com; 27 Jan 2009 08:34:35 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0R8YVFq007756 for <2062@emacsbugs.donarmstrong.com>; Tue, 27 Jan 2009 00:34:33 -0800 Original-Received: by ewy3 with SMTP id 3so8138883ewy.1 for <2062@emacsbugs.donarmstrong.com>; Tue, 27 Jan 2009 00:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=udvZpUpj4+c3vdXyKf/+Jib7YMO+4yU1Ho5fUdP8Cz4=; b=HOKGZgI5wi2nawjbm6XNi2jMdB6aYaukWQuJcYPkvY4hHV+ksPpmQimk5BiBZyZ9UN 0NZhUQJ+SmJtbaCd3YLDqbbmwiEe6uMziH63x/ONEw2zK3Qc4hS4qbAySSafhI2keca1 fHe4lliVy9zlD7EJNgOuiXS+Rd1ApqIabMyYA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=VX7G+Gty663mKvvXKLsxGFgNX2ifgU7z7sApt9TKxQ9FjuebHf8xvdZjWGgzvBxix1 meB3r/dMsTj3Gjah0Q4feomCOiakkbesxLUlUk8z/ldSvwxi8snq7L4zziT4wDLg6V81 4qq8dk0W1ZI3N7Am06GdOLYwpCmGXW4r+jskQ= Original-Received: by 10.210.66.13 with SMTP id o13mr5256914eba.21.1233045266162; Tue, 27 Jan 2009 00:34:26 -0800 (PST) In-Reply-To: <497E69EB.70609@f2s.com> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 27 Jan 2009 03:43:36 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24599 Archived-At: On Tue, Jan 27, 2009 at 02:56, Jason Rumney wrote: > The right place to do this expansion is where the variable is read from the > registry, and only when the type is REG_EXPAND_SZ. The problem is, we don't read "HKLM\Software\Microsoft\Windows\CurrentVersion\App Paths\emacs.exe\Path", we find the PATH made for us and it contains unexpanded variables. My patch modifies decode_env_path, because it is used for PATH-like variables, not generic environment variables. How likely is that such a PATH-like variable contains a string like %VARIABLENAME%, meaning a literal "%VARIABLENAME%" directory or filename (or part of it)? That's a hypothetical problem, while my path containing such a variable is a fact. Juanma