* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
@ 2009-08-04 14:55 Bostjan Vilfan
2019-10-01 13:10 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Bostjan Vilfan @ 2009-08-04 14:55 UTC (permalink / raw)
To: bug-gnu-emacs
[-- Attachment #1.1: Type: text/plain, Size: 5070 bytes --]
--text follows this line--
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.
Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug: The example that illustrates the bug
is in attachment
Hello,
I have the habit of attaching some commands to toolbar icons, thereby achieving one
click functionality. It is thus that I have noticed the following difference between
Emacs 22.3 and Emacs 23.1: After attaching some toolbar commands to a certain file
name, I visit that file. In Emacs 22.3 all additional icons are placed on the toolbar (if icons won't fit on the toolbar line, a new line is created), and one can do whatever one likes with the file. In Emacs 23.1, however, if an additional toolbar line is needed, the icons are not placed on the toolbar until one "does something" with the file (e.g. moves the slider). In my view the fact that something has to be done for the toolbar icons to appear is an inconvenience.
I created a small example illustrating this bug (or whatever). All necessary files
are found in example.zip. Instructions are located at the beginning of example.el.
Note that when the example is run, one must wait some time before the icons appear
(too many icons?). To repeat: in Emacs 22.3 all (10) icons appear not having to do
anything to the file while in Emacs 23.1 only one will appear, and only after moving
slider the remaining 9.
Regards,
bostjanv
If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
`bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
c:/Program Files/GNU/Emacs/emacs-23.1/etc/DEBUG for instructions.
In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
of 2009-07-30 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: ENU
value of $XMODIFIERS: nil
locale-coding-system: cp1250
default-enable-multibyte-characters: t
Major mode: Fundamental
Minor modes in effect:
tooltip-mode: t
tool-bar-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
blink-cursor-mode: t
global-auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
<help-echo> <switch-frame> <switch-frame> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<switch-frame> <tool-bar> <kill-buffer> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<down-mouse-1> <mouse-1> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<tool-bar> <one-window> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<menu-bar> <buffer> C-d <down-mouse-1> <mouse-1> <tab>
<down-mouse-1> <mouse-1> <tab> <down-mouse-1> <mouse-1>
<backspace> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <tool-bar>
<save-buffer> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> u t f - 8 <return> <help-echo>
<help-echo> <help-echo> <tool-bar> <kill-buffer> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<down-mouse-1> <mouse-1> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <down-mouse-1> <mouse-1> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <tool-bar> <help>
Recent messages:
Loading utilvilf...done
Mark set
OVERVIEW
For information about GNU Emacs and the GNU system, type C-h C-a.
CHILDREN [2 times]
Saving file c:/Documents and Settings/Bostjan/My Documents/.emacs.d/notes.org...
Wrote c:/Documents and Settings/Bostjan/My Documents/.emacs.d/notes.org
[-- Attachment #1.2: Type: text/html, Size: 6720 bytes --]
[-- Attachment #2: example.zip --]
[-- Type: application/zip, Size: 21942 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2009-08-04 14:55 bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?) Bostjan Vilfan
@ 2019-10-01 13:10 ` Lars Ingebrigtsen
2019-10-01 13:34 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-01 13:10 UTC (permalink / raw)
To: Bostjan Vilfan; +Cc: 4032
Bostjan Vilfan <bvilf@yahoo.com> writes:
[...]
> It is thus that I have noticed the following difference between Emacs
> 22.3 and Emacs 23.1: After attaching some toolbar commands to a
> certain file name, I visit that file. In Emacs 22.3 all additional
> icons are placed on the toolbar (if icons won't fit on the toolbar
> line, a new line is created), and one can do whatever one likes with
> the file. In Emacs 23.1, however, if an additional toolbar line is
> needed, the icons are not placed on the toolbar until one "does
> something" with the file (e.g. moves the slider). In my view the fact
> that something has to be done for the toolbar icons to appear is an
> inconvenience.
>
> I created a small example illustrating this bug (or whatever).
(I'm going through old bug reports that unfortunately didn't get any
response at the time.)
I tested this now in Emacs 27, and Emacs behaves differently now -- it
doesn't expand to several lines at all, but instead the "overflowing"
toolbar items just aren't displayed. If I expand the frame width, they
are shown.
Does anybody know whether this is the intended behaviour?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2019-10-01 13:10 ` Lars Ingebrigtsen
@ 2019-10-01 13:34 ` Eli Zaretskii
2019-10-01 13:57 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-10-01 13:34 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: bvilf, 4032
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 01 Oct 2019 15:10:12 +0200
> Cc: 4032@debbugs.gnu.org
>
> I tested this now in Emacs 27, and Emacs behaves differently now -- it
> doesn't expand to several lines at all, but instead the "overflowing"
> toolbar items just aren't displayed. If I expand the frame width, they
> are shown.
Is this a GTK build?
> Does anybody know whether this is the intended behaviour?
I do see all of the items here, with the native tool bar produced by
Emacs on MS-Windows.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2019-10-01 13:34 ` Eli Zaretskii
@ 2019-10-01 13:57 ` Lars Ingebrigtsen
2019-10-01 14:55 ` Eli Zaretskii
2019-10-02 8:54 ` martin rudalics
0 siblings, 2 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-01 13:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: bvilf, 4032
Eli Zaretskii <eliz@gnu.org> writes:
>> I tested this now in Emacs 27, and Emacs behaves differently now -- it
>> doesn't expand to several lines at all, but instead the "overflowing"
>> toolbar items just aren't displayed. If I expand the frame width, they
>> are shown.
>
> Is this a GTK build?
Yes.
>> Does anybody know whether this is the intended behaviour?
>
> I do see all of the items here, with the native tool bar produced by
> Emacs on MS-Windows.
Did you get two tool bar lines? The bug report was about the second
line not appearing until you do something, I think.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2019-10-01 13:57 ` Lars Ingebrigtsen
@ 2019-10-01 14:55 ` Eli Zaretskii
2019-10-02 11:50 ` Lars Ingebrigtsen
2019-10-02 8:54 ` martin rudalics
1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-10-01 14:55 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: bvilf, 4032
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: bvilf@yahoo.com, 4032@debbugs.gnu.org
> Date: Tue, 01 Oct 2019 15:57:59 +0200
>
> > I do see all of the items here, with the native tool bar produced by
> > Emacs on MS-Windows.
>
> Did you get two tool bar lines?
Yes.
> The bug report was about the second line not appearing until you do
> something, I think.
We don't redraw the tool bar unnecessarily, because that would cause
flickering. In my case, I needed to do "C-x b" to see the updated
tool bar. If this is a problem, I will have to see a real-life use
case where it happens and matters.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2019-10-01 13:57 ` Lars Ingebrigtsen
2019-10-01 14:55 ` Eli Zaretskii
@ 2019-10-02 8:54 ` martin rudalics
1 sibling, 0 replies; 9+ messages in thread
From: martin rudalics @ 2019-10-02 8:54 UTC (permalink / raw)
To: Lars Ingebrigtsen, Eli Zaretskii; +Cc: bvilf, 4032
>>> I tested this now in Emacs 27, and Emacs behaves differently now -- it
>>> doesn't expand to several lines at all, but instead the "overflowing"
>>> toolbar items just aren't displayed. If I expand the frame width, they
>>> are shown.
>>
>> Is this a GTK build?
>
> Yes.
The GTK tool bar does not expand to several lines. But it can be
shown on any side of a frame and can enlarge a frame when its items
won't fit.
martin
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2019-10-01 14:55 ` Eli Zaretskii
@ 2019-10-02 11:50 ` Lars Ingebrigtsen
2019-10-02 15:19 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-02 11:50 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: bvilf, 4032
Eli Zaretskii <eliz@gnu.org> writes:
> We don't redraw the tool bar unnecessarily, because that would cause
> flickering. In my case, I needed to do "C-x b" to see the updated
> tool bar.
I see, then the situation is unchanged since the user made the bug report.
> If this is a problem, I will have to see a real-life use
> case where it happens and matters.
The original bug report is a bit vague on the use case, but I think
perhaps they mean that they have modes that put a lot of entries in the
tool bar, and those aren't shown until you "do something"?
> Hello, I have the habit of attaching some commands to toolbar icons,
> thereby achieving one click functionality. It is thus that I have
> noticed the following difference between Emacs 22.3 and Emacs 23.1:
> After attaching some toolbar commands to a certain file name, I visit
> that file. In Emacs 22.3 all additional icons are placed on the toolbar
> (if icons won't fit on the toolbar line, a new line is created), and one
> can do whatever one likes with the file. In Emacs 23.1, however, if an
> additional toolbar line is needed, the icons are not placed on the
> toolbar until one "does something" with the file (e.g. moves the
> slider). In my view the fact that something has to be done for the
> toolbar icons to appear is an inconvenience.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2019-10-02 11:50 ` Lars Ingebrigtsen
@ 2019-10-02 15:19 ` Eli Zaretskii
2019-10-03 15:03 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2019-10-02 15:19 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: bvilf, 4032
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: bvilf@yahoo.com, 4032@debbugs.gnu.org
> Date: Wed, 02 Oct 2019 13:50:59 +0200
>
> > If this is a problem, I will have to see a real-life use
> > case where it happens and matters.
>
> The original bug report is a bit vague on the use case, but I think
> perhaps they mean that they have modes that put a lot of entries in the
> tool bar, and those aren't shown until you "do something"?
In general, they should nowadays call force-mode-line-update in these
cases, I think.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?)
2019-10-02 15:19 ` Eli Zaretskii
@ 2019-10-03 15:03 ` Lars Ingebrigtsen
0 siblings, 0 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2019-10-03 15:03 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: bvilf, 4032
Eli Zaretskii <eliz@gnu.org> writes:
>> The original bug report is a bit vague on the use case, but I think
>> perhaps they mean that they have modes that put a lot of entries in the
>> tool bar, and those aren't shown until you "do something"?
>
> In general, they should nowadays call force-mode-line-update in these
> cases, I think.
OK; then I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-10-03 15:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-04 14:55 bug#4032: 23.1; Minor inconvenience in toolbar implementation (perhaps only on Windows?) Bostjan Vilfan
2019-10-01 13:10 ` Lars Ingebrigtsen
2019-10-01 13:34 ` Eli Zaretskii
2019-10-01 13:57 ` Lars Ingebrigtsen
2019-10-01 14:55 ` Eli Zaretskii
2019-10-02 11:50 ` Lars Ingebrigtsen
2019-10-02 15:19 ` Eli Zaretskii
2019-10-03 15:03 ` Lars Ingebrigtsen
2019-10-02 8:54 ` martin rudalics
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).