From: Dmitry Gutov <dgutov@yandex.ru>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 58951@debbugs.gnu.org
Subject: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p'
Date: Wed, 2 Nov 2022 00:29:36 +0200 [thread overview]
Message-ID: <ed7feb06-a58d-0638-df10-3f920a647506@yandex.ru> (raw)
In-Reply-To: <87iljyco9v.fsf@posteo.net>
On 02.11.2022 00:18, Philip Kaludercic wrote:
> Dmitry Gutov<dgutov@yandex.ru> writes:
>
>> On 01.11.2022 21:36, Philip Kaludercic wrote:
>>> I believe this is preferable to fixing `show-paren-predicate', as this
>>> is the kind of issue a lot of people could trip over.
>>> This patch is based on the patch from bug#58950, but can be
>>> back-ported
>>> to the previous implementations if there are any issues with that report.
>> I do agree that (not foo) is more convenient than (not . foo). Though
>> the latter would be more regular compared to the rest of the syntax. I
>> made just that mistake yesterday.
>>
>> Let's change 'pcase' to 'pcase-exhaustive', though? So it will signal
>> an error on invalid syntax.
> Right, that is what I did in bug#58950 and what led me to notice the mistake.
Oh, sorry. I didn't review that patch in detail yet.
LGTM then.
next prev parent reply other threads:[~2022-11-01 22:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 19:36 bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Philip Kaludercic
[not found] ` <handler.58951.B.166733138129551.ack@debbugs.gnu.org>
2022-11-01 20:19 ` bug#58951: Acknowledgement ([PATCH] ; Fix handling of 'not' by 'buffer-match-p') Philip Kaludercic
[not found] ` <87pme6cts5.fsf@posteo.net>
2022-11-02 12:04 ` Eli Zaretskii
2022-12-31 14:05 ` bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Philip Kaludercic
2022-11-01 22:09 ` Dmitry Gutov
2022-11-01 22:18 ` Philip Kaludercic
2022-11-01 22:29 ` Dmitry Gutov [this message]
2022-12-31 16:26 ` Mattias Engdegård
2022-12-31 16:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed7feb06-a58d-0638-df10-3f920a647506@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58951@debbugs.gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).