From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: philipk@posteo.net, 58951@debbugs.gnu.org
Subject: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p'
Date: Sat, 31 Dec 2022 18:34:15 +0200 [thread overview]
Message-ID: <83mt734jnc.fsf@gnu.org> (raw)
In-Reply-To: <CAC1FC4C-A514-4E4A-80A7-F68F3C5E8C65@acm.org> (message from Mattias Engdegård on Sat, 31 Dec 2022 17:26:02 +0100)
> Cc: 58951@debbugs.gnu.org
> From: Mattias Engdegård <mattiase@acm.org>
> Date: Sat, 31 Dec 2022 17:26:02 +0100
>
> > (not . CONDITION)
> >
> > while it is more natural to write
> >
> > (not CONDITION)
>
> Shouldn't then the `derived-mode` and `major-mode` operators be changed in the same way?
In fact, that change cause errors in timer function of
show-paren-mode, so I've reverted it for now.
> And shouldn't there be tests? For all of `buffer-match-p`, in fact?
Ideally, yes.
prev parent reply other threads:[~2022-12-31 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 19:36 bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Philip Kaludercic
[not found] ` <handler.58951.B.166733138129551.ack@debbugs.gnu.org>
2022-11-01 20:19 ` bug#58951: Acknowledgement ([PATCH] ; Fix handling of 'not' by 'buffer-match-p') Philip Kaludercic
[not found] ` <87pme6cts5.fsf@posteo.net>
2022-11-02 12:04 ` Eli Zaretskii
2022-12-31 14:05 ` bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Philip Kaludercic
2022-11-01 22:09 ` Dmitry Gutov
2022-11-01 22:18 ` Philip Kaludercic
2022-11-01 22:29 ` Dmitry Gutov
2022-12-31 16:26 ` Mattias Engdegård
2022-12-31 16:34 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt734jnc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58951@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).