unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, Juri Linkov <juri@linkov.net>
Cc: 8186@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#8186: dired-font-lock-keywords should warn about SUID files too!
Date: Mon, 28 Oct 2019 07:23:01 -0700 (PDT)	[thread overview]
Message-ID: <eaea2ae9-e37b-45e4-bfb0-6db8dbb4455d@default> (raw)
In-Reply-To: <87mudlazka.fsf@gnus.org>

> > I checked the directory /run and there is:
> >   drwxrwsr-x  3 postgres postgres   120 postgresql
> > where 'w' in group is rightfully highlighted with the 'dired-perm-write' face,
> > but 's' in the same group is not highlighted with the 'dired-set-id' face.
> > Is this intentional?
> 
> No...  Do we need to add combinatorial versions of all the regexps to
> dired-font-lock-keywords or is there a better way?

FWIW -

If by that you mean highlight the different privileges
for each possible role (other, group, user), then
`dired+.el' has done that since sometime in the 90s.
(I suggested it for Emacs back then.)

Not a big deal:

(list (concat dired-re-maybe-mark dired-re-inode-size
              "[-dl]........\\([lsStT]\\)")  ; o misc
      '(1 diredp-other-priv))
(list (concat dired-re-maybe-mark dired-re-inode-size
              "[-dl].....\\([lsStT]\\)...")  ; g misc
      '(1 diredp-other-priv))
(list (concat dired-re-maybe-mark dired-re-inode-size
              "[-dl]..\\([lsStT]\\)...")     ; u misc
      '(1 diredp-other-priv))
(list (concat dired-re-maybe-mark dired-re-inode-size
              "\\([bcsmpS]\\)")              ; (rare)
      '(1 diredp-rare-priv keep))

https://www.emacswiki.org/emacs/download/dired%2b.el





  reply	other threads:[~2019-10-28 14:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-06  5:12 bug#8186: dired-font-lock-keywords should warn about SUID files too! jidanni
2011-03-06 18:15 ` Drew Adams
2011-03-06 21:23 ` jidanni
2011-03-06 21:45   ` Drew Adams
2019-10-14  1:32 ` Lars Ingebrigtsen
2019-10-27 21:28   ` Juri Linkov
2019-10-28 11:18     ` Lars Ingebrigtsen
2019-10-28 14:23       ` Drew Adams [this message]
2019-10-30 12:31     ` Lars Ingebrigtsen
2019-10-30 13:06       ` Andreas Schwab
2019-10-30 13:16         ` Lars Ingebrigtsen
2019-10-30 13:09       ` Peder O. Klingenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaea2ae9-e37b-45e4-bfb0-6db8dbb4455d@default \
    --to=drew.adams@oracle.com \
    --cc=8186@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).