From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#8186: dired-font-lock-keywords should warn about SUID files too! Date: Mon, 28 Oct 2019 07:23:01 -0700 (PDT) Message-ID: References: <87hbbg7ry5.fsf@jidanni.org> <87a7a4t8mn.fsf@gnus.org> <87tv7u87oj.fsf@mail.linkov.net> <87mudlazka.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="162726"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 8186@debbugs.gnu.org, jidanni@jidanni.org To: Lars Ingebrigtsen , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 28 15:26:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iP5yT-000gCh-K0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Oct 2019 15:26:25 +0100 Original-Received: from localhost ([::1]:54366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP5yS-0002XB-CA for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Oct 2019 10:26:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39460) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP5wC-0007q0-AH for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 10:24:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iP5wA-0001uD-Su for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 10:24:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37207) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iP5wA-0001tx-Ns for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 10:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iP5wA-0000hC-H3 for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2019 10:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Oct 2019 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 8186-submit@debbugs.gnu.org id=B8186.15722725932607 (code B ref 8186); Mon, 28 Oct 2019 14:24:02 +0000 Original-Received: (at 8186) by debbugs.gnu.org; 28 Oct 2019 14:23:13 +0000 Original-Received: from localhost ([127.0.0.1]:46028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP5vN-0000fz-6x for submit@debbugs.gnu.org; Mon, 28 Oct 2019 10:23:13 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:41314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iP5vK-0000fj-CN for 8186@debbugs.gnu.org; Mon, 28 Oct 2019 10:23:12 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9SELds1138664; Mon, 28 Oct 2019 14:23:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=gsIPReson1iqgWh/44N/tK/5Fb4byL8lRNrMCcmsEzM=; b=VxkuRiWK7dtj8gYhV8h8eJN3Vd83Ja5fgvdwgisB0Dx7YJgrLFgwOkDQvnblNibPuplA mJv4GXraEXcSVjJO7Eta/GkIm4c4RqPQdw9EciCyaE69EFmpDcj4vcH8Pj8TM9fYhIxv 2Xa9UUKnJwPsBbJWxuPb5Bz9RNC2amztkKpchd0iuj2x2UxXQlSsYMzb33k+eKoVJ3ih ECMv2Wmycv4zmG5zz7Ii2vVJ3hmoTFZvbAk8rDZ7MxeJIdV7iw7XIcU8OyRzKuIJAJw/ mE/hqGQDqZPe+M+ziKhMYr5BoS0KZy+Izobx3HENGBdbEG24rb4I22H7VCvRIceM8U+/ 3Q== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2vvdju2eyq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2019 14:23:04 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9SEM7GB174383; Mon, 28 Oct 2019 14:23:03 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2vwaky3240-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 28 Oct 2019 14:23:03 +0000 Original-Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9SEN2PR022869; Mon, 28 Oct 2019 14:23:02 GMT In-Reply-To: <87mudlazka.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9423 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910280148 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9423 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910280148 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170298 Archived-At: > > I checked the directory /run and there is: > > drwxrwsr-x 3 postgres postgres 120 postgresql > > where 'w' in group is rightfully highlighted with the 'dired-perm-write= ' face, > > but 's' in the same group is not highlighted with the 'dired-set-id' fa= ce. > > Is this intentional? >=20 > No... Do we need to add combinatorial versions of all the regexps to > dired-font-lock-keywords or is there a better way? FWIW - If by that you mean highlight the different privileges for each possible role (other, group, user), then `dired+.el' has done that since sometime in the 90s. (I suggested it for Emacs back then.) Not a big deal: (list (concat dired-re-maybe-mark dired-re-inode-size "[-dl]........\\([lsStT]\\)") ; o misc '(1 diredp-other-priv)) (list (concat dired-re-maybe-mark dired-re-inode-size "[-dl].....\\([lsStT]\\)...") ; g misc '(1 diredp-other-priv)) (list (concat dired-re-maybe-mark dired-re-inode-size "[-dl]..\\([lsStT]\\)...") ; u misc '(1 diredp-other-priv)) (list (concat dired-re-maybe-mark dired-re-inode-size "\\([bcsmpS]\\)") ; (rare) '(1 diredp-rare-priv keep)) https://www.emacswiki.org/emacs/download/dired%2b.el